Skip to content

Commit 5c18a61

Browse files
RKSimonLukacma
authored andcommitted
[CAS] OnDiskGraphDB - fix MSVC "not all control paths return a value" warnings. NFC. (llvm#164369)
1 parent 578c804 commit 5c18a61

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

llvm/include/llvm/CAS/OnDiskGraphDB.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,7 @@ class OnDiskGraphDB {
380380
case ObjectPresence::OnlyInUpstreamDB:
381381
return true;
382382
}
383+
llvm_unreachable("Unknown ObjectPresence enum");
383384
}
384385

385386
/// When \p load is called for a node that doesn't exist, this function tries

llvm/lib/CAS/OnDiskGraphDB.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -836,6 +836,7 @@ uint64_t DataRecordHandle::getDataSize() const {
836836
case DataSizeFlags::Uses8B:
837837
return support::endian::read64le(DataSizePtr);
838838
}
839+
llvm_unreachable("Unknown DataSizeFlags enum");
839840
}
840841

841842
void DataRecordHandle::skipDataSize(LayoutFlags LF, int64_t &RelOffset) const {
@@ -863,6 +864,7 @@ uint32_t DataRecordHandle::getNumRefs() const {
863864
case NumRefsFlags::Uses8B:
864865
return support::endian::read64le(NumRefsPtr);
865866
}
867+
llvm_unreachable("Unknown NumRefsFlags enum");
866868
}
867869

868870
void DataRecordHandle::skipNumRefs(LayoutFlags LF, int64_t &RelOffset) const {
@@ -1270,6 +1272,7 @@ Expected<bool> OnDiskGraphDB::isMaterialized(ObjectID Ref) {
12701272
return FaultInResult.takeError();
12711273
return true;
12721274
}
1275+
llvm_unreachable("Unknown ObjectPresence enum");
12731276
}
12741277

12751278
Expected<OnDiskGraphDB::ObjectPresence>

0 commit comments

Comments
 (0)