Skip to content

chore: add note on ui tests to contribution guide#489

Closed
leonqadirie wants to merge 1 commit intoLukeMathWalker:mainfrom
leonqadirie:chore-docs-advise-on-ui-tests
Closed

chore: add note on ui tests to contribution guide#489
leonqadirie wants to merge 1 commit intoLukeMathWalker:mainfrom
leonqadirie:chore-docs-advise-on-ui-tests

Conversation

@leonqadirie
Copy link
Contributor

Not sure about the seemingly conflicting sentences:

All tests are located in libs/pavex_cli/tests and are launched using a custom test runner that you can find in libs/pavex_test_runner.

and

UI tests are located in libs/ui_tests and need to invoke pavexc.

Maybe we should reword the first one as 'All tests are collected via libs/pavex_cli/tests'?

Also happy to close, the hint would have saved me some time, though :)

@LukeMathWalker
Copy link
Owner

I clarified the setup in 934991b. Thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants