fix: most other spelling errors#490
fix: most other spelling errors#490LukeMathWalker merged 7 commits intoLukeMathWalker:mainfrom leonqadirie:fix-rest-of-spelling-errors
Conversation
|
Each UI test is a Rust package, and the name of the package is derived from the hash of the test name. If the filenames change, the hash changes and therefore the expected package name changes. It's enough to change the crate name for the UI tests you changed to match what the runner expects. I could probably smoothen this out by having the runner taking care of the update. |
might be a breaking change, not investigated yet
|
This should be good to go. Regarding integrating Also, I'd ignore some 'false positives' for now. The most notable suggestions are:
(I don't yet unterstand this JSON and what happens with gimli) |
|
/ok-to-test d672e81 |
|
|
|
/ok-to-test sha=9fe3316 |
|
For CI: I'd say that we want a new workflow. You can use deny.yml as a reference example, since (if I understood correctly) there is no need to build the project to run |
Expanding on #488, mostly bundles spelling fixes for:
I'd be glad for pointers why the test-related dir/file name changes break the test runs with: