Skip to content

fix: most other spelling errors#490

Merged
LukeMathWalker merged 7 commits intoLukeMathWalker:mainfrom
leonqadirie:fix-rest-of-spelling-errors
May 30, 2025
Merged

fix: most other spelling errors#490
LukeMathWalker merged 7 commits intoLukeMathWalker:mainfrom
leonqadirie:fix-rest-of-spelling-errors

Conversation

@leonqadirie
Copy link
Contributor

Expanding on #488, mostly bundles spelling fixes for:

  • misc (had overlooked some)
  • tracing & config-related (this commit can't stand by itself, as this breaks a test)
  • very few actual function/macro names (have not yet checked whether they'd be breaking changes)
  • test-related incl. the aforementioned file names

I'd be glad for pointers why the test-related dir/file name changes break the test runs with:

Warming up the target directory
error: package ID specification `app_16375429` did not match any packages
Error: Failed to compile the test binaries

@LukeMathWalker
Copy link
Owner

Each UI test is a Rust package, and the name of the package is derived from the hash of the test name. If the filenames change, the hash changes and therefore the expected package name changes.
See this chunk as a reference.

It's enough to change the crate name for the UI tests you changed to match what the runner expects. I could probably smoothen this out by having the runner taking care of the update.

@leonqadirie
Copy link
Contributor Author

This should be good to go.
As far as I can see, e49296a is contained to pavexc and not a breaking change.


Regarding integrating typos-cli into the CI, I'd definitely need some pointers, though.

Also, I'd ignore some 'false positives' for now. The most notable suggestions are:

(I don't yet unterstand this JSON and what happens with gimli)

@leonqadirie leonqadirie marked this pull request as ready for review May 27, 2025 19:52
@LukeMathWalker
Copy link
Owner

/ok-to-test d672e81

@LukeMathWalker
Copy link
Owner

annotated.json was a stray check-in. Removed it in a6cadfa.

@LukeMathWalker
Copy link
Owner

/ok-to-test sha=9fe3316

@LukeMathWalker LukeMathWalker merged commit 18dcc61 into LukeMathWalker:main May 30, 2025
27 checks passed
@LukeMathWalker
Copy link
Owner

For CI: I'd say that we want a new workflow. You can use deny.yml as a reference example, since (if I understood correctly) there is no need to build the project to run typos-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants