More performance for nodes that have repeated names. Also fixed the replace nodes and naming conventions

Author: gavazquez

LunaConfigNode/CfgNode/CfgNodeValue.cs

@@ -1,6 +1,6 @@
 using System.Collections.Generic;
 
-namespace LunaConfigNode
+namespace LunaConfigNode.CfgNode
 {
     public class CfgNodeValue<T1, T2>
     {

LunaConfigNode/CfgNode/ConfigNode.cs

@@ -8,8 +8,8 @@ public partial class ConfigNode
         public string Name { get; set; } = string.Empty;
         public ConfigNode Parent { get; set; }
 
-        public MixedCollection<string, string> Values { get; } = new MixedCollection<string, string>();
-        public MixedCollection<string, ConfigNode> Nodes { get; } = new MixedCollection<string, ConfigNode>();
+        public MixedCollection<string, string> Values { get; private set; } = new MixedCollection<string, string>();
+        public MixedCollection<string, ConfigNode> Nodes { get; private set; } = new MixedCollection<string, ConfigNode>();
 
         public int Depth => Parent?.Depth + 1 ?? 0;
 
@@ -26,14 +26,16 @@ public ConfigNode(string contents)
                 {
                     if (line.Contains(CfgNodeConstants.ValueSeparator))
                     {
-                        currentNode.CreateValue(line.Substring(0, line.IndexOf(CfgNodeConstants.ValueSeparator, StringComparison.Ordinal)).Trim(),
-                            line.Substring(line.LastIndexOf(CfgNodeConstants.ValueSeparator, StringComparison.Ordinal) + CfgNodeConstants.ValueSeparator.Length).Trim());
+                        currentNode.CreateValue(new CfgNodeValue<string, string>(line.Substring(0, line.IndexOf(CfgNodeConstants.ValueSeparator, StringComparison.Ordinal)).Trim(),
+                            line.Substring(line.LastIndexOf(CfgNodeConstants.ValueSeparator, StringComparison.Ordinal) + CfgNodeConstants.ValueSeparator.Length).Trim()));
 
                         continue;
                     }
                     if (line.TrimEnd().Equals(CfgNodeConstants.OpenNodeSymbol))
                     {
-                        currentNode = currentNode.CreateNode(previousLine);
+                        var newNode = new ConfigNode(previousLine, this);
+                        currentNode.AddNode(newNode);
+                        currentNode = newNode;
                         continue;
                     }
                     if (line.TrimEnd().Equals(CfgNodeConstants.CloseNodeSymbol))
@@ -58,9 +60,9 @@ public bool IsEmpty()
         {
             return Values.IsEmpty() && Nodes.IsEmpty();
         }
-        
-        #region Base overrides
 
+        #region Base overrides
+        
         public override string ToString()
         {
             return CfgNodeWriter.WriteConfigNode(this);

LunaConfigNode/CfgNode/ConfigNodeAdd.cs

@@ -2,14 +2,6 @@
 {
     public partial class ConfigNode
     {
-        /// <summary>
-        /// Create the specified name and value
-        /// </summary>
-        public void CreateValue(string name, string value)
-        {
-            Values.Create(name, value);
-        }
-
         /// <summary>
         /// Adds the specified name-value
         /// </summary>
@@ -18,55 +10,13 @@ public void CreateValue(CfgNodeValue<string,string> value)
             Values.Add(value);
         }
 
-        /// <summary>
-        /// Create or updates the given value
-        /// </summary>
-        public void CreateOrUpdateValue(string name, string value)
-        {
-            if (Values.Exists(name))
-            {
-                Values.Update(name, value);
-            }
-            else
-            {
-                Values.Create(name, value);
-            }
-        }
-
-        /// <summary>
-        /// Creates a new empty config node with the given name
-        /// </summary>
-        public ConfigNode CreateNode(string name)
-        {
-            var newConfigNode = new ConfigNode(name, this);
-
-            Nodes.Create(name, newConfigNode);
-
-            return newConfigNode;
-        }
-
         /// <summary>
         /// Adds the given node as a child
         /// </summary>
         public void AddNode(ConfigNode value)
         {
             value.Parent = this;
-            Nodes.Create(value.Name, value);
-        }
-
-        /// <summary>
-        /// Adds or updates the matching node names
-        /// </summary>
-        public void CreateOrReplaceNode(ConfigNode value)
-        {
-            if (Nodes.Exists(value.Name))
-            {
-                Nodes.Update(value.Name, value);
-            }
-            else
-            {
-                Nodes.Create(value.Name, value);
-            }
+            Nodes.Add(new CfgNodeValue<string, ConfigNode>(value.Name, value));
         }
     }
 }

LunaConfigNode/CfgNode/ConfigNodeRemove.cs

@@ -19,7 +19,7 @@ public void RemoveNode(ConfigNode configNode)
         }
 
         /// <summary>
-        /// Removes the nodes that have the given name
+        /// Removes ALL the nodes that have the given name
         /// </summary>
         public void RemoveNode(string name)
         {

LunaConfigNode/CfgNode/ConfigNodeUpdater.cs

@@ -10,19 +10,12 @@ public void UpdateValue(string name, string value)
             Values.Update(name, value);
         }
 
-        /// <summary>
-        /// Replaces ALL the nodes with the matching node name if they exist for the one given as parameter
-        /// </summary>
-        public void ReplaceNode(string name, ConfigNode updatedNode)
-        {
-            Nodes.Update(name, updatedNode);
-        }
-
         /// <summary>
         /// Replaces the nodes with the matching node name and configNode if it exists for the one given as parameter
         /// </summary>
         public void ReplaceNode(ConfigNode oldNode, ConfigNode updatedNode)
         {
+            updatedNode.Parent = this;
             Nodes.Replace(new CfgNodeValue<string, ConfigNode>(oldNode.Name, oldNode), new CfgNodeValue<string, ConfigNode>(updatedNode.Name, updatedNode));
         }
     }