Merge branch 'use_playwright_for_acceptance_tests' into develop

Author: jzohrab

.github/workflows/ci.yml

@@ -68,9 +68,17 @@ jobs:
         export MECAB_PATH=/lib/x86_64-linux-gnu/libmecab.so.2
         pytest
 
-    # Skipping acceptance tests for 3.8, just to save some time.
+    - name: Playwright install
+      run: playwright install
+
+    - name: Playwright smoke test
+      run: |
+        set -x
+        set -e
+        inv playwright
+
     - name: Acceptance testing
-      if: matrix.python_version != '3.8'
+      if: matrix.python_version == '3.11' || matrix.python_version == '3.12' || matrix.python_version == '3.13'
       uses: nick-fields/retry@v3
       with:
         max_attempts: 3
@@ -88,7 +96,7 @@ jobs:
 
     # Skipping acceptance tests for 3.8, just to save some time.
     - name: Mobile acceptance testing
-      if: matrix.python_version != '3.8'
+      if: matrix.python_version == '3.11' || matrix.python_version == '3.12' || matrix.python_version == '3.13'
       uses: nick-fields/retry@v3
       with:
         max_attempts: 3
@@ -104,15 +112,6 @@ jobs:
           fi
           exit $exit_code
 
-    - name: Playwright install
-      run: playwright install
-
-    - name: Playwright smoke test
-      run: |
-        set -x
-        set -e
-        inv playwright
-
     - name: Check flit package
       run: |
         mkdir ${{ github.workspace }}/../lute_flit
@@ -166,6 +165,9 @@ jobs:
         ls ${{ github.workspace }}
         cat ${{ github.workspace }}/lute/config/config.yml
 
+    - name: Playwright install
+      run: playwright install
+
     # Run one particular sanity check.
     #
     # Note this isn't _completely_ valid because the test loads

plugins/lute-mandarin/requirements.txt

@@ -60,7 +60,6 @@ pytest==7.4.2
 pytest-base-url==2.0.0
 pytest-bdd==7.0.0
 pytest-playwright==0.4.3
-pytest-splinter==3.3.2
 python-slugify==8.0.1
 PyYAML==6.0.1
 requests==2.31.0
@@ -69,7 +68,6 @@ six==1.16.0
 sniffio==1.3.0
 sortedcontainers==2.4.0
 soupsieve==2.5
-splinter==0.19.0
 SQLAlchemy==2.0.21
 subtitle-parser==1.3.0
 text-unidecode==1.3

pyproject.toml

@@ -52,7 +52,6 @@ dev = [
   "pipdeptree>=2.13.0,<3",
   "pylint>=2.17.5,<4",
   "pytest-bdd>=7.0.0,<8",
-  "pytest-splinter>=3.3.2,<4",
   "playwright>=1.39.0,<2",
   "pre-commit>=3.5.0,<4",
   "black>=23.10.1,<24",

tasks.py

@@ -185,8 +185,6 @@ def _run_acceptance(  # pylint: disable=too-many-arguments,too-many-positional-a
     run_test = [
         "pytest",
         "tests/acceptance",
-        "--splinter-screenshot-dir=tests/acceptance/failure_screenshots",
-        "--splinter-webdriver=chrome",
         f"--port={port}",
     ]
 

tests/acceptance/README.md

@@ -1,6 +1,6 @@
-# Web tests with pytest-splinter
+# Web tests with playwright
 
-Ref https://pytest-splinter.readthedocs.io/en/3.3.2/#example
+Ref https://playwright.dev/python/docs/intro
 
 ## How to run the tests