test: cover missing lines

Author: avik-pal

.buildkite/testing.yml

@@ -7,9 +7,6 @@ steps:
               version: "1"
           - JuliaCI/julia-coverage#v1:
               codecov: true
-              dirs:
-                - src
-                - ext
         command: julia --code-coverage=user --color=yes --project .buildkite/scripts/downstream.jl "{{matrix.repo}}" "CUDA"
         agents:
           queue: "juliagpu"

src/LuxCore.jl

@@ -71,7 +71,6 @@ for op in (:initialparameters, :initialstates)
 end
 
 _fmap_leaf(::AbstractExplicitLayer) = true
-_fmap_leaf(::Nothing) = true
 _fmap_leaf(x) = Functors.isleaf(x)
 
 _getemptystate(::AbstractExplicitLayer) = NamedTuple()
@@ -311,7 +310,7 @@ end
 A Boolean Value
 """
 check_fmap_condition(cond::C, ::Nothing, x) where {C} = any(cond, fleaves(x))
-check_fmap_condition(cond::C, ::Nothing, ::NamedTuple{}) where {C} = any(cond, ())
+check_fmap_condition(cond::C, ::Nothing, ::NamedTuple{()}) where {C} = any(cond, ())
 function check_fmap_condition(cond::C, ::Type{T}, x) where {C, T}
     x isa T && return true
     return check_fmap_condition(cond, nothing, x)

test/runtests.jl

@@ -71,10 +71,14 @@ end
             @test LuxCore.initialparameters(rng, NamedTuple()) == NamedTuple()
             @test_throws MethodError LuxCore.initialparameters(rng, ())
             @test LuxCore.initialparameters(rng, nothing) == NamedTuple()
+            @test LuxCore.initialparameters(rng, (nothing, layer)) ==
+                  (NamedTuple(), NamedTuple())
 
             @test LuxCore.initialstates(rng, NamedTuple()) == NamedTuple()
             @test_throws MethodError LuxCore.initialstates(rng, ())
             @test LuxCore.initialstates(rng, nothing) == NamedTuple()
+            @test LuxCore.initialparameters(rng, (nothing, layer)) ==
+                  (NamedTuple(), NamedTuple())
         end
     end
 
@@ -173,6 +177,7 @@ end
             @test new_model.layers.layer_2.out == 10
 
             @test LuxCore.outputsize(model, rand(5), rng) == (5,)
+            @test LuxCore.outputsize(model, rand(5, 2), rng) == (5,)
         end
 
         @testset "Method Ambiguity" begin
@@ -269,4 +274,9 @@ end
         @test LuxCore.replicate(rng) !== rng
         @test LuxCore.replicate(rng) == rng
     end
+
+    @testset "empty fleaves" begin
+        @test_broken length(fleaves(NamedTuple())) == 0  # upstream issue
+        @test !LuxCore.check_fmap_condition(isodd, nothing, NamedTuple())
+    end
 end