Skip to content

Commit 57c1996

Browse files
committed
reduceLoggingForBigFiles. Reduce logging if max cells coordinated are too big
1 parent 996dca3 commit 57c1996

File tree

3 files changed

+24
-22
lines changed

3 files changed

+24
-22
lines changed

src/main/java/com/google/hashcode/entity/Pizza.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public boolean containsCells(Slice slice) {
6363
}
6464

6565
private String outputCellsArray() {
66-
if (!cells.isEmpty()) {
66+
if (!cells.isEmpty() && cells.size() < 100) {
6767
StringBuilder stringBuilder = new StringBuilder();
6868
int columnsCount = cells.stream().max(Comparator.comparingInt(Cell::getX)).get().getX();
6969
int rowsCount = cells.stream().max(Comparator.comparingInt(Cell::getY)).get().getY();
@@ -87,8 +87,9 @@ private String outputCellsArray() {
8787
}
8888
return stringBuilder.toString();
8989
} else {
90-
return "";
90+
return "pizza size is:" + cells.size();
9191
}
92+
9293
}
9394

9495

src/main/java/com/google/hashcode/entity/Slice.java

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,27 +72,28 @@ public Optional<Cell> getCell(int y, int x) {
7272
public String toString() {
7373
StringBuilder stringBuilder = new StringBuilder();
7474
stringBuilder.append("slice : \n");
75-
//output coordinates
76-
int columnsCount = cells.stream().max(Comparator.comparingInt(Cell::getX)).get().getX();
77-
int rowsCount = cells.stream().max(Comparator.comparingInt(Cell::getY)).get().getY();
78-
//output columns coordinates
79-
stringBuilder.append(" ");
80-
for (int column = 0; column < columnsCount + 1; column++) {
81-
stringBuilder.append(" ").append(column);
82-
}
83-
stringBuilder.append("\n");
84-
for (int row = 0; row < rowsCount + 1; row++) {
85-
//output rows coordinates
86-
stringBuilder.append(row).append(" ");
75+
if (maxX()+maxY() < 20) { //output coordinates
76+
int columnsCount = cells.stream().max(Comparator.comparingInt(Cell::getX)).get().getX();
77+
int rowsCount = cells.stream().max(Comparator.comparingInt(Cell::getY)).get().getY();
78+
//output columns coordinates
79+
stringBuilder.append(" ");
8780
for (int column = 0; column < columnsCount + 1; column++) {
88-
if (this.getCell(row, column).isPresent()) {
89-
stringBuilder.append(this.getCell(row, column).get().toString()).append(" ");
90-
} else {
91-
stringBuilder.append(" ").append(" ");
92-
}
81+
stringBuilder.append(" ").append(column);
9382
}
9483
stringBuilder.append("\n");
95-
}
84+
for (int row = 0; row < rowsCount + 1; row++) {
85+
//output rows coordinates
86+
stringBuilder.append(row).append(" ");
87+
for (int column = 0; column < columnsCount + 1; column++) {
88+
if (this.getCell(row, column).isPresent()) {
89+
stringBuilder.append(this.getCell(row, column).get().toString()).append(" ");
90+
} else {
91+
stringBuilder.append(" ").append(" ");
92+
}
93+
}
94+
stringBuilder.append("\n");
95+
}
96+
} else stringBuilder.append("\nsize: ").append(cells.size());
9697
return stringBuilder.toString().trim();
9798
}
9899

src/main/java/com/google/hashcode/entity/Step.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public int size() {
3232
@Override
3333
public String toString() {
3434
return "\nStep{" +
35-
"\nstartPosition=" + startPosition +
36-
"\ndelta=" + delta +
35+
"\nstartPosition=" + startPosition.toString() +
36+
"\ndelta=" + delta.toString() +
3737
"\n}";
3838
}
3939

0 commit comments

Comments
 (0)