Less noise

Author: ildyria

app/Actions/Diagnostics/Pipes/Checks/BasicPermissionCheck.php

@@ -38,6 +38,7 @@ class BasicPermissionCheck implements DiagnosticPipe
 {
 	public const MAX_ISSUE_REPORTS_PER_TYPE = 5;
 	public const READ_WRITE_ALL = 07777;
+	public const WITHOUT_STICKY_BIT = 0777;
 
 	/**
 	 * @var int[] IDs of all (POSIX) groups to which the process belongs
@@ -219,7 +220,9 @@ private function checkDirectoryPermissionsRecursively(string $path, array &$data
 			// `fileperms` also returns the higher bits of the inode mode.
 			// Hence, we must AND it with 07777 to only get what we are
 			// interested in
-			$actual_perm &= self::READ_WRITE_ALL;
+
+			// Edit 2026-01-23: Ignore sticky bit in permission checks
+			$actual_perm &= self::WITHOUT_STICKY_BIT;
 			$owning_group_id_or_false = filegroup($path);
 			if ($owning_group_id_or_false !== false) {
 				try {
@@ -236,7 +239,7 @@ private function checkDirectoryPermissionsRecursively(string $path, array &$data
 			}
 			/** @var string $owning_group_name */
 			$owning_group_name = $owning_group_name_or_false === false ? '<unknown>' : $owning_group_name_or_false['name'];
-			$expected_perm = self::getConfiguredDirectoryPerm();
+			$expected_perm = self::WITHOUT_STICKY_BIT & self::getConfiguredDirectoryPerm();
 
 			if (!in_array($owning_group_id_or_false, $this->groupIDs, true)) {
 				// @codeCoverageIgnoreStart

app/Actions/Diagnostics/Pipes/Checks/DBSupportCheck.php

@@ -31,6 +31,7 @@ public function handle(array &$data, \Closure $next): array
 		if (!array_key_exists(config('database.default', 'sqlite'), $db_possibilities)) {
 			// @codeCoverageIgnoreStart
 			$data[] = DiagnosticData::error('database type ' . config('database.default', 'sqlite') . ' is not supported by Lychee', self::class);
+
 			return $next($data);
 		}
 		// @codeCoverageIgnoreEnd
@@ -41,7 +42,7 @@ public function handle(array &$data, \Closure $next): array
 		}
 		if (!$found) {
 			// @codeCoverageIgnoreStart
-			$data[] = DiagnosticData::error(config('database.default', 'sqlite') . ' db driver selected and PHP ' . join(" or ",$db_possibility[config('database.default', 'sqlite')]) . ' extensions not activated', self::class);
+			$data[] = DiagnosticData::error(config('database.default', 'sqlite') . ' db driver selected and PHP ' . implode(' or ', $db_possibility[config('database.default', 'sqlite')]) . ' extensions not activated', self::class);
 			// @codeCoverageIgnoreEnd
 		}