Node must exists error adding a sub-album

[tdp4]

Lychee version

v5.5.1

Which PHP version are you using?

PHP 8.2

Detailed description of the problem

I have an album with multiple sub-albums that I have used php artisan lychee:sync to add image to the sub-albums. I attempted to create a new sub-album, entered the name (ex: 00000-00002), clicked 'Create Album'and the screen briefly flashed white (looked like a 500 error). I was returned to the same album and no new album was created.

Inspecting the error log I found:

App\Models\Album::assertNodeExists:1198 Node must exists.
App\Actions\Album\Create::set_parent:58 Node must exists.; caused by

AlbumID: dTKUnS5s4oYoBTyrWOPybQdG

base_albums entry looks ok

albums entry looks ok

access_permissions doesn't have an entry for the albumID

Steps to reproduce the issue

1. go to an album (in this case, my specific album with the issue)
2. click on (+) and select "New Album"
3. Enter the album name.
4. click on "Create Album"

Diagnostics [REQUIRED]

    Diagnostics
    -----------
        Warning: /home/liferge***************************************a.com/storage/image-jobs/ has permissions 0755, but should have 2775
        Warning: /home/liferge***************************************a.com/storage/livewire-tmp/ has permissions 0755, but should have 2775
        Warning: Dropbox import not working. dropbox_key is empty.
        Info: Latest version of PHP is 8.3
        Warning: Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone
        Error: Photo without Original found -- miryoku2023_20230930-154045_625 in 09009-91864
        Error: Photo without Original found -- miryoku2023_20230930-154339_641 in 09009-91864
        Error: Photo without Original found -- miryoku2023_20230930-131733_501 in 09009-90991
        Error: Photo without Original found -- miryoku2023_20230930-131804_508 in 09009-90991
        Info: Found 7 small that could be generated.
              You can use `php artisan lychee:generate_thumbs small 7` to generate them.
        Info: Found 7 small2x that could be generated.
              You can use `php artisan lychee:generate_thumbs small2x 7` to generate them.
        Info: Found 8 medium that could be generated.
              You can use `php artisan lychee:generate_thumbs medium 8` to generate them.
        Info: Found 6 medium2x that could be generated.
              You can use `php artisan lychee:generate_thumbs medium2x 6` to generate them.
    
    System Information
    ------------------
        Lychee Version (release):                5.5.1
        DB Version:                              5.5.1
        
        composer install:                        --no-dev
        APP_ENV:                                 production
        APP_DEBUG:                               false
        APP_URL:                                 set
        APP_DIR:                                 set
        LOG_VIEWER_ENABLED:                      true
        LIVEWIRE_ENABLED:                        true
        
        System:                                  Linux
        PHP Version:                             8.2.22
        PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
        Timezone:                                UTC
        Max uploaded file size:                  500M
        Max post size:                           500M
        Livewire chunk size:                     12.00 MB
        Max execution time:                      200
        MySQL Version:                           10.6.19-MariaDB
        
        exec() Available:                        yes
        Imagick Available:                       1
        Imagick Enabled:                         1
        Imagick Version:                         1809
        GD Version:                              2.3.3
        Number of foreign key:                   12 found.
    
    Config Information
    ------------------
        version:                                 050501
        check_for_updates:                       0
        sorting_photos_col:                      taken_at
        sorting_photos_order:                    ASC
        sorting_albums_col:                      title
        sorting_albums_order:                    ASC
        imagick:                                 1
        skip_duplicates:                         0
        small_max_width:                         0
        small_max_height:                        360
        medium_max_width:                        1920
        medium_max_height:                       1080
        lang:                                    en
        image_overlay_type:                      exif
        default_license:                         reserved
        compression_quality:                     90
        grants_full_photo_access:                1
        delete_imported:                         0
        mod_frame_enabled:                       1
        mod_frame_refresh:                       30
        thumb_2x:                                1
        small_2x:                                1
        medium_2x:                               1
        landing_page_enable:                     1
        force_migration_in_production:           0
        search_public:                           1
        hide_version_number:                     0
        SL_enable:                               0
        SL_for_admin:                            0
        recent_age:                              1
        grants_download:                         1
        photos_wraparound:                       1
        map_display:                             0
        zip64:                                   1
        map_display_public:                      0
        map_provider:                            Wikimedia
        force_32bit_ids:                         1
        map_include_subalbums:                   0
        update_check_every_days:                 3
        has_exiftool:                            0
        share_button_visible:                    1
        import_via_symlink:                      0
        has_ffmpeg:                              0
        location_decoding:                       0
        location_decoding_timeout:               30
        location_show:                           1
        location_show_public:                    0
        rss_enable:                              0
        rss_recent_days:                         7
        rss_max_items:                           100
        prefer_available_xmp_metadata:           0
        editor_enabled:                          1
        lossless_optimization:                   0
        swipe_tolerance_x:                       150
        swipe_tolerance_y:                       250
        local_takestamp_video_formats:           .avi|.mov
        log_max_num_line:                        1000
        unlock_password_photos_with_url_param:   0
        nsfw_visible:                            0
        nsfw_blur:                               1
        nsfw_warning:                            1
        nsfw_warning_admin:                      0
        nsfw_banner_override:                    
        map_display_direction:                   1
        album_subtitle_type:                     oldstyle
        upload_processing_limit:                 4
        new_photos_notification:                 0
        legacy_id_redirection:                   1
        zip_deflate_level:                       6
        default_album_protection:                2
        album_decoration:                        photo
        album_decoration_orientation:            row
        allow_username_change:                   1
        auto_fix_orientation:                    1
        use_job_queues:                          1
        random_album_id:                         starred
        use_last_modified_date_when_no_exif_date: 0
        layout:                                  justified
        date_format_photo_thumb:                 M j, Y, g:i:s A e
        date_format_photo_overlay:               M j, Y, g:i:s A e
        date_format_sidebar_uploaded:            M j, Y, g:i:s A e
        date_format_sidebar_taken_at:            M j, Y, g:i:s A e
        date_format_hero_min_max:                F Y
        date_format_hero_created_at:             M j, Y, g:i:s A T
        date_format_album_thumb:                 M Y
        upload_chunk_size:                       0
        nsfw_banner_blur_backdrop:               0
        search_pagination_limit:                 1000
        search_minimum_length_required:          4
        photo_layout_justified_row_height:       320
        photo_layout_masonry_column_width:       300
        photo_layout_grid_column_width:          250
        photo_layout_square_column_width:        200
        photo_layout_gap:                        12
        display_thumb_album_overlay:             always
        display_thumb_photo_overlay:             hover
        default_album_thumb_aspect_ratio:        5/4
        use_album_compact_header:                0
        login_button_position:                   left
        back_button_enabled:                     0
        back_button_text:                        Return to Home
        current_job_processing_visible:          1
        SA_random_thumbs:                        0
        job_processing_queue_visible:            1
        login_required:                          0
        enable_unsorted:                         0
        enable_starred:                          1
        enable_recent:                           0
        enable_on_this_day:                      1
        login_required_root_only:                0

Browser & System [REQUIRED]

Chrome Version 127.0.6533.99 (Official Build) (64-bit)
Microsoft Windows 11 Enterprise
Version 10.0.22631 Build 22631

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

That is a weird one.

[ildyria]

	protected function assertNodeExists(Node $node)
	{
		if (!$node->getLft() || !$node->getRgt()) {
			throw new \LogicException('Node must exists.');
		}

		return $this;
	}

Can you check the values of _lft and _rgt in your database for that specific album ?

[tdp4]

The Album hash is dTKUnS5s4oYoBTyrWOPybQdG, and the record in the DB is:

+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| id                       | parent_id | license  | album_thumb_aspect_ratio | album_sorting_col | album_sorting_order | cover_id | header_id | track_short_path | _lft | _rgt |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| dTKUnS5s4oYoBTyrWOPybQdG | NULL      | reserved | 1/1                      | title             | ASC                 | NULL     | NULL      | NULL             |    0 |    1 |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
1 row in set (0.094 sec)

Additionally:

> select * from albums WHERE _lft = 0;
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| id                       | parent_id | license  | album_thumb_aspect_ratio | album_sorting_col | album_sorting_order | cover_id | header_id | track_short_path | _lft | _rgt |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| dTKUnS5s4oYoBTyrWOPybQdG | NULL      | reserved | 1/1                      | title             | ASC                 | NULL     | NULL      | NULL             |    0 |    1 |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
1 row in set (0.070 sec)

> select * from albums WHERE _lft = 1;
Empty set (0.003 sec)

> select * from albums WHERE _rgt = 0;
Empty set (0.000 sec)

> select * from albums WHERE _rgt = 1;
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| id                       | parent_id | license  | album_thumb_aspect_ratio | album_sorting_col | album_sorting_order | cover_id | header_id | track_short_path | _lft | _rgt |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
| dTKUnS5s4oYoBTyrWOPybQdG | NULL      | reserved | 1/1                      | title             | ASC                 | NULL     | NULL      | NULL             |    0 |    1 |
+--------------------------+-----------+----------+--------------------------+-------------------+---------------------+----------+-----------+------------------+------+------+
1 row in set (0.000 sec)

[ildyria]

Yeah that's the problem.
the value of _lft should be 1 instead of 0 and the one of _rgt should be 2.

[ildyria]

However this may have an impact on your full tree.
If you update, the values, make sure that all the values in _lft and in _rgt are incremented by 1.

If you want a bit of reading of how the tree structure of Lychee works:
https://blog.uniauth.com/nested-set-model