Skip to content

Commit 7b95a07

Browse files
ildyriad7415
andauthored
Apply suggestions from code review
Co-authored-by: Martin Stone <[email protected]>
1 parent dd6ed78 commit 7b95a07

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

docs/releases.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@ Duplicates would be displayed successively in such page and it would be impossib
4545
While doing this change, it also became clear that legacy ids for albums could no longer be preserved.
4646
As a result, we dropped the legacy ids for albums and photos. This means that the remnants of API v1 are now completely gone.
4747

48-
This release also brings the support of two new languages: Arabic and Dutch. The later is still in early steps as we are still using the Left-to-Right (LTR) layout,
48+
This release also brings the support of two new languages: Arabic and Dutch. The former is still in early steps as we are still using the Left-to-Right (LTR) layout,
4949
but we are planning to also add Persian (fa) and with it a full Right-to-Left (RTL) display.
5050

51-
We also added a registration page, which you can enabled/disable in your settings.
51+
We also added a registration page, which you can enable/disable in your settings.
5252

53-
Finally for the great supporters of Lychee we added two new feature:
53+
Finally for the great supporters of Lychee we added two new features:
5454

5555
- The ability to create user-groups. This functionality is currently hidden behind a feature flag, but we are planning to make it available soon.
5656
This will allow you to create groups of users and share albums with those groups, simplifying the sharing process.
@@ -66,20 +66,20 @@ Finally for the great supporters of Lychee we added two new feature:
6666
* `new` #3388 : Support space in search terms by @ildyria.
6767
> You can now search for terms with spaces, to do so, you will need to use quotes around the search term.
6868
* `new` #3383 : Add option to disable slideshow by @ildyria.
69-
> One of our user requested the ability to disable the slideshow mode in the photo view.
69+
> One of our users requested the ability to disable the slideshow mode in the photo view.
7070
> Well here it is! Available as an option in the settings page.
7171
* `new` #3384 : Add registration page by @ildyria.
7272
> Registration is disabled by default, but you can enable it in the User Management section of the settings page.
7373
* `new` #3379 : Add option to override the album visibility for smart and tag albums by @ildyria.
7474
> By default, smart albums and tag albums are respecting the access rights of the user to select the pictures.
75-
> One of our user requested the ability to override this visibility constraint. This option is now available in the settings page.
75+
> One of our users requested the ability to override this visibility constraint. This option is now available in the settings page.
7676
* `SE` #3406 : Add User-groups by @ildyria.
77-
> User Groups are coming, as they do not provide value for the moment, they are hidden behind a feature flag.
77+
> User Groups are coming. As they do not provide value for the moment, they are hidden behind a feature flag.
7878
* `SE` #3409 : Add color extraction from pictures. by @ildyria.
7979
> This option is available in the image processing section of the settings page.
8080
> It allows you to extract the 5 dominant colours from photos. We provide two different engines for this:
8181
>
82-
> - Slower: `league` does a full sampling and use ciede2000DeltaE for colour distance calculation.
82+
> - Slower: `league` does a full sampling and uses ciede2000DeltaE for colour distance calculation.
8383
> - Faster: `farzai` uses spot sampling and k-mean distance.
8484
* `new` #3359 : Refactoring photo-album relation by @ildyria.
8585
> As explained in the introduction, this is a big change which allows a photo to be in multiple albums at the same time instead of being duplicated.

src/content/post/2025-06-11-version-6-6-6.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Now having worked on creating a timeline view, I can see how useful it is to hav
2525

2626
While invisible to the user, this architecture change has a big impact. By having the relation a photo has a unique album,
2727
it makes it possible to do a file mapping between the photos/albums in Lychee and the files/folders on the backend.
28-
While this is not implemented, it could be seen in the future to be made possible as this has been a long-standing complaint from some of our users.
28+
While this is not currently implemented, it could be in the future as this has been a long-standing complaint from some of our users.
2929
By moving to a many-to-many relation between photos and albums, this mapping is no longer an "easy" task, but we believe the benefits outweigh the drawbacks.
3030

3131
#### Improved way of working with stacked pull requests
@@ -40,10 +40,10 @@ The first drawback of this approach is that if you use the strategy squash-and-m
4040
It quickly goes sideway as conflicts between commits are bound to happen and need to be resolved.
4141
The easy way to avoid this is to collapse the stack into a single commit once all the PR are approved before merging into main.
4242
- The second issue is that because of squash-and-merge, you will need to rebase to ensure a nice linear stack and propagate changes up.
43-
A review on the bottom with change requests will impact the PR above it. There are no easy solution to this but some git wizardy.
44-
I will admit that `git reset --soft xxx` has become one of my best friend.
43+
A review on the bottom with change requests will impact the PR above it. There are no easy solution to this but some git wizardry.
44+
I will admit that `git reset --soft xxx` has become one of my best friends.
4545

46-
And finally, the last drawback of this approach is the growing number of PR waiting to be merged. In itself it is not to annoying but GitHub
46+
And finally, the last drawback of this approach is the growing number of PRs waiting to be merged. In itself it is not too annoying but GitHub
4747
does not provide a good visual overview of the state of the stack. For this reason, to increase the visibility of the changes, we have created
4848
a new [new page](https://pr.lycheeorg.dev/) to list all the open pull requests in a stack and their status.
4949
Of course as per open-source tradition, the source code is available on [GitHub](https://github.com/LycheeOrg/Lychee-Pull-Requests).

0 commit comments

Comments
 (0)