Merge pull request LykosAI#1150 from ionite34/backport/main/pr-1149

[dev to main] backport: Fix uv python list output special characters causing install errors… (1149)

Author: mohnjiles

CHANGELOG.md

@@ -12,8 +12,10 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
 - Updated SageAttention installer to install v2.2.0-windows.post3
 - Updated Nunchaku installer to install v1.0.1
 ### Fixed
-- Fixed [#1372](https://github.com/LykosAI/StabilityMatrix/issues/1372) - LiteAsyncException upon starting Stability Matrix v2.15.0
+- Fixed [#1372](https://github.com/LykosAI/StabilityMatrix/issues/1372), [#1399](https://github.com/LykosAI/StabilityMatrix/issues/1399) - LiteAsyncException upon starting Stability Matrix v2.15.0
 - Fixed [#1391](https://github.com/LykosAI/StabilityMatrix/issues/1391) - "Failed to parse" error when upgrading pip packages with extra index url
+- Fixed [#1401](https://github.com/LykosAI/StabilityMatrix/issues/1401) - "Python <version> was not found and/or failed to install" errors when path contains special characters
+- Fixed [#1403](https://github.com/LykosAI/StabilityMatrix/issues/1403) - Checkpoint Manager filters not being saved correctly
 - Fixed "cannot access local variable 'job' where it is not associated with a value" error when running jobs in AI Toolkit
 - Fixed Civitai browser not always returning at least 30 results when possible on initial search
 

StabilityMatrix.Avalonia/ViewModels/CheckpointsPageViewModel.cs

@@ -160,16 +160,14 @@ protected override async Task OnInitialLoadedAsync()
 
         await base.OnInitialLoadedAsync();
 
-        var settingsSelectedBaseModels = settingsManager.Settings.SelectedBaseModels;
-
         AddDisposable(
             BaseModelCache
                 .Connect()
                 .DeferUntilLoaded()
                 .Transform(baseModel => new BaseModelOptionViewModel
                 {
                     ModelType = baseModel,
-                    IsSelected = settingsSelectedBaseModels.Contains(baseModel),
+                    IsSelected = settingsManager.Settings.SelectedBaseModels.Contains(baseModel),
                 })
                 .SortAndBind(
                     BaseModelOptions,
@@ -179,10 +177,15 @@ protected override async Task OnInitialLoadedAsync()
                 .ObserveOn(SynchronizationContext.Current)
                 .Subscribe(next =>
                 {
-                    if (next.Sender.IsSelected)
-                        SelectedBaseModels.Add(next.Sender.ModelType);
-                    else
-                        SelectedBaseModels.Remove(next.Sender.ModelType);
+                    switch (next.Sender.IsSelected)
+                    {
+                        case true when !SelectedBaseModels.Contains(next.Sender.ModelType):
+                            SelectedBaseModels.Add(next.Sender.ModelType);
+                            break;
+                        case false when SelectedBaseModels.Contains(next.Sender.ModelType):
+                            SelectedBaseModels.Remove(next.Sender.ModelType);
+                            break;
+                    }
 
                     OnPropertyChanged(nameof(ClearButtonText));
                     OnPropertyChanged(nameof(SelectedBaseModels));
@@ -191,6 +194,7 @@ protected override async Task OnInitialLoadedAsync()
 
         var settingsTransactionObservable = this.WhenPropertyChanged(x => x.SelectedBaseModels)
             .Throttle(TimeSpan.FromMilliseconds(50))
+            .Skip(1)
             .ObserveOn(SynchronizationContext.Current)
             .Subscribe(_ =>
             {

StabilityMatrix.Core/Processes/ProcessRunner.cs

@@ -166,7 +166,7 @@ public static async Task<string> GetProcessOutputAsync(
             Arguments = arguments,
             UseShellExecute = false,
             RedirectStandardOutput = true,
-            CreateNoWindow = true
+            CreateNoWindow = true,
         };
 
         if (environmentVariables != null)
@@ -196,7 +196,8 @@ public static async Task<ProcessResult> GetProcessResultAsync(
         string fileName,
         ProcessArgs arguments,
         string? workingDirectory = null,
-        IReadOnlyDictionary<string, string>? environmentVariables = null
+        IReadOnlyDictionary<string, string>? environmentVariables = null,
+        bool useUtf8Encoding = false
     )
     {
         Logger.Debug($"Starting process '{fileName}' with arguments '{arguments}'");
@@ -208,9 +209,15 @@ public static async Task<ProcessResult> GetProcessResultAsync(
             UseShellExecute = false,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
-            CreateNoWindow = true
+            CreateNoWindow = true,
         };
 
+        if (useUtf8Encoding)
+        {
+            info.StandardOutputEncoding = Encoding.UTF8;
+            info.StandardErrorEncoding = Encoding.UTF8;
+        }
+
         if (environmentVariables != null)
         {
             foreach (var (key, value) in environmentVariables)
@@ -255,7 +262,7 @@ public static async Task<ProcessResult> GetProcessResultAsync(
             StandardOutput = stdout,
             StandardError = stderr,
             ProcessName = processName,
-            Elapsed = elapsed
+            Elapsed = elapsed,
         };
     }
 
@@ -410,7 +417,7 @@ public static Process StartProcess(
             UseShellExecute = false,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
-            CreateNoWindow = true
+            CreateNoWindow = true,
         };
 
         if (environmentVariables != null)
@@ -458,7 +465,7 @@ public static AnsiProcess StartAnsiProcess(
             UseShellExecute = false,
             RedirectStandardOutput = true,
             RedirectStandardError = true,
-            CreateNoWindow = true
+            CreateNoWindow = true,
         };
 
         if (environmentVariables != null)
@@ -544,7 +551,7 @@ public static async Task<ProcessResult> RunBashCommand(
         {
             ExitCode = process.ExitCode,
             StandardOutput = stdout.ToString(),
-            StandardError = stderr.ToString()
+            StandardError = stderr.ToString(),
         };
     }
 

StabilityMatrix.Core/Python/UvManager.cs

@@ -1,6 +1,8 @@
+using System.Text.Encodings.Web;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using System.Text.RegularExpressions;
+using System.Text.Unicode;
 using Injectio.Attributes;
 using NLog;
 using StabilityMatrix.Core.Helper;
@@ -20,6 +22,7 @@ public partial class UvManager : IUvManager
     {
         Converters = { new JsonStringEnumConverter() },
         PropertyNamingPolicy = JsonNamingPolicy.CamelCase,
+        Encoder = JavaScriptEncoder.Create(UnicodeRanges.All),
     };
     private string? uvExecutablePath;
     private DirectoryPath? uvPythonInstallPath;
@@ -120,7 +123,7 @@ public async Task<IReadOnlyList<UvPythonInfo>> ListAvailablePythonsAsync(
         var uvDirectory = Path.GetDirectoryName(uvExecutablePath);
 
         var result = await ProcessRunner
-            .GetProcessResultAsync(uvExecutablePath, args, uvDirectory, envVars)
+            .GetProcessResultAsync(uvExecutablePath, args, uvDirectory, envVars, useUtf8Encoding: true)
             .ConfigureAwait(false);
 
         if (!result.IsSuccessExitCode)