Skip to content

Commit 6a9e402

Browse files
committed
Merge pull request LykosAI#1105 from ionite34/catch-symlink-removal-errors
Catch symlink removal errors during update so it doesn't completely fail the update (cherry picked from commit 0dea261) # Conflicts: # CHANGELOG.md
1 parent dae982d commit 6a9e402

File tree

2 files changed

+69
-8
lines changed

2 files changed

+69
-8
lines changed

CHANGELOG.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,45 @@ All notable changes to Stability Matrix will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2.0.0.html).
77

8+
<<<<<<< HEAD
9+
=======
10+
## v2.15.0-dev.2
11+
### Added
12+
- Added new package - [FramePack](https://github.com/lllyasviel/FramePack)
13+
- Added new package - [FramePack Studio](https://github.com/colinurbs/FramePack-Studio)
14+
- Added support for authenticated model downloads in the HuggingFace model browser. Visit Settings → Accounts to add your HuggingFace token.
15+
- Added support for dragging-and-dropping Civitai-generated images into Inference to load metadata
16+
- Added the ability to search by pasting an entire Civitai model URL into the search bar in the Civitai model browser (when the Civitai API gets fixed)
17+
- Added "Clear Pip Cache" and "Clear uv Cache" commands to the Settings -> Embedded Python section
18+
### Changed
19+
- Civitai model browser image loading now uses dynamic resizing for better performance and a smoother scrolling experience
20+
- Detailed notifications for Civitai model browser api errors
21+
- The main sidebar now remembers whether it was collapsed or expanded between restarts
22+
- Updated pre-selected download locations for certain model types in the Civitai model browser
23+
- Updated uv to 0.7.19
24+
- Changed InvokeAI update process to no longer clone the repo
25+
### Fixed
26+
- Fixed missing .NET 8 dependency for SwarmUI installs in certain cases
27+
- Fixed [#1291](https://github.com/LykosAI/StabilityMatrix/issues/1291) - Certain GPUs not being detected on Linux
28+
- Fixed [#1284](https://github.com/LykosAI/StabilityMatrix/issues/1284) - Output browser not ignoring InvokeAI thumbnails folders
29+
- Fixed [#1305](https://github.com/LykosAI/StabilityMatrix/issues/1305) - FluxGym installing incorrect packages for Blackwell GPUs
30+
- Fixed [#1316](https://github.com/LykosAI/StabilityMatrix/issues/1316) - Errors when installing Triton & SageAttention
31+
- Fixed "directory is not empty" error when updating packages with symlinks
32+
33+
## v2.15.0-dev.1
34+
### Added
35+
- Added Python Version selector for all new package installs
36+
- Added the ability to rename packages
37+
### Changed
38+
- Updated all Python version management, virtual environment creation, and pip installs to use `uv` for improved reliability, compatibility, and speed
39+
- The Civitai model browser Download Location selector will now remember the last location used based on the model type
40+
- New installs of ComfyUI, SD.Next, and InvokeAI will now use Python 3.12.10, unless otherwise specified in the Advanced Options during installation
41+
- New installs of all other packages will now use Python 3.10.17, unless otherwise specified in the Advanced Options during installation
42+
### Supporters
43+
#### 🌟 Visionaries
44+
A massive thank you to our esteemed Visionary-tier Patrons: **Waterclouds**, **bluepopsicle**, **Bob S**, **Ibixat**, and **Corey T**! Your exceptional commitment propels Stability Matrix to new heights and allows us to push the boundaries of innovation. We're incredibly grateful for your foundational support! 🚀
45+
46+
>>>>>>> 0dea2612 (Merge pull request #1105 from ionite34/catch-symlink-removal-errors)
847
## v2.14.3
948
### Added
1049
- Added the ability to search by pasting an entire Civitai model URL into the search bar in the Civitai model browser (when the Civitai API gets fixed)

StabilityMatrix.Core/Models/Packages/BaseGitPackage.cs

Lines changed: 30 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -446,18 +446,40 @@ await PrerequisiteHelper
446446
{
447447
if (SharedFolders is not null)
448448
{
449-
Helper.SharedFolders.RemoveLinksForPackage(
450-
SharedFolders,
451-
new DirectoryPath(installedPackage.FullPath!)
452-
);
449+
try
450+
{
451+
Helper.SharedFolders.RemoveLinksForPackage(
452+
SharedFolders,
453+
new DirectoryPath(installedPackage.FullPath!)
454+
);
455+
}
456+
catch (Exception e)
457+
{
458+
Logger.Warn(
459+
e,
460+
"Failed to remove symlinks for package {Package}",
461+
installedPackage.PackageName
462+
);
463+
}
453464
}
454465

455466
if (SharedOutputFolders is not null && installedPackage.UseSharedOutputFolder)
456467
{
457-
Helper.SharedFolders.RemoveLinksForPackage(
458-
SharedOutputFolders,
459-
new DirectoryPath(installedPackage.FullPath!)
460-
);
468+
try
469+
{
470+
Helper.SharedFolders.RemoveLinksForPackage(
471+
SharedOutputFolders,
472+
new DirectoryPath(installedPackage.FullPath!)
473+
);
474+
}
475+
catch (Exception e)
476+
{
477+
Logger.Warn(
478+
e,
479+
"Failed to remove output symlinks for package {Package}",
480+
installedPackage.PackageName
481+
);
482+
}
461483
}
462484
}
463485

0 commit comments

Comments
 (0)