Merge pull request #1151 from ionite34/fix-format-crashes

Fix model browser file name format causing crashes when data is missing

(cherry picked from commit e81c237b228ca539acdadfa1e6753e0aeef3690b)

Author: mohnjiles

CHANGELOG.md

@@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
 - Fixed [#1403](https://github.com/LykosAI/StabilityMatrix/issues/1403) - Checkpoint Manager filters not being saved correctly
 - Fixed "cannot access local variable 'job' where it is not associated with a value" error when running jobs in AI Toolkit
 - Fixed Civitai browser not always returning at least 30 results when possible on initial search
+- Fixed model browser crashing when downloading a file with invalid characters in the name
+- Fixed model browser crashing when no author exists for a model
 
 ## v2.15.0
 ### Added

StabilityMatrix.Avalonia/Models/Inference/FileNameFormat.cs

@@ -37,7 +37,20 @@ public string GetFileName()
         return Prefix
             + string.Join(
                 "",
-                Parts.Select(part => part.Match(constant => constant, substitution => substitution.Invoke()))
+                Parts.Select(part =>
+                    part.Match(
+                        constant => constant,
+                        substitution =>
+                        {
+                            // Filter invalid path chars
+                            var result = substitution.Invoke();
+                            return result is null
+                                ? null
+                                : Path.GetInvalidFileNameChars()
+                                    .Aggregate(result, (current, c) => current.Replace(c, '_'));
+                        }
+                    )
+                )
             )
             + Postfix;
     }

StabilityMatrix.Avalonia/Models/Inference/FileNameFormatProvider.cs

@@ -47,7 +47,7 @@ public partial class FileNameFormatProvider
             { "project_name", () => ProjectName },
             { "date", () => DateTime.Now.ToString("yyyy-MM-dd") },
             { "time", () => DateTime.Now.ToString("HH-mm-ss") },
-            { "author", () => CivitModel?.Creator.Username },
+            { "author", () => CivitModel?.Creator?.Username },
             { "base_model", () => CivitModelVersion?.BaseModel },
             { "file_name", () => Path.GetFileNameWithoutExtension(CivitFile?.Name) },
             { "file_id", () => CivitFile?.Id.ToString() },

StabilityMatrix.Avalonia/ViewModels/CheckpointBrowser/CheckpointBrowserCardViewModel.cs

@@ -212,7 +212,7 @@ private void ToggleFavorite()
     [RelayCommand]
     public void SearchAuthor()
     {
-        EventManager.Instance.OnNavigateAndFindCivitAuthorRequested(CivitModel.Creator.Username);
+        EventManager.Instance.OnNavigateAndFindCivitAuthorRequested(CivitModel.Creator?.Username);
     }
 
     private async Task DoImport(

StabilityMatrix.Avalonia/ViewModels/CheckpointBrowser/CivitAiBrowserViewModel.cs

@@ -553,7 +553,7 @@ private async Task CivitModelQuery(CivitModelsRequest request, bool isInfiniteSc
                 var doesBaseModelTypeMatch =
                     SelectedBaseModels.Count == 0
                         ? request.BaseModels == null || request.BaseModels.Length == 0
-                        : SelectedBaseModels.SequenceEqual(request.BaseModels);
+                        : SelectedBaseModels.SequenceEqual(request.BaseModels ?? []);
                 var doesModelTypeMatch =
                     SelectedModelType == CivitModelType.All
                         ? request.Types == null || request.Types.Length == 0

StabilityMatrix.Avalonia/ViewModels/CheckpointBrowser/CivitDetailsPageViewModel.cs

@@ -651,7 +651,7 @@ private async Task ShowImageDialog(ImageSource? image)
     private void SearchByAuthor()
     {
         navigationService.GoBack();
-        EventManager.Instance.OnNavigateAndFindCivitAuthorRequested(CivitModel.Creator.Username);
+        EventManager.Instance.OnNavigateAndFindCivitAuthorRequested(CivitModel.Creator?.Username);
     }
 
     [RelayCommand]

StabilityMatrix.Core/Models/Api/CivitModel.cs

@@ -27,7 +27,7 @@ public class CivitModel
     public CivitMode? Mode { get; set; }
 
     [JsonPropertyName("creator")]
-    public CivitCreator Creator { get; set; }
+    public CivitCreator? Creator { get; set; }
 
     [JsonPropertyName("stats")]
     public CivitModelStats Stats { get; set; }