-
-
Notifications
You must be signed in to change notification settings - Fork 492
v2.15.5 #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.15.5 #1504
Conversation
Add Wan2GP and misc fixes (cherry picked from commit 1a844fe894b17e3d8a042f01a97f9f725de2ac4d) # Conflicts: # CHANGELOG.md
Removed development version details and merged changelog entries.
[dev to main] backport: Add Wan2GP and misc fixes (1180)
Downmerg from public
Fixes from dev
Updated torch index for Forge-based UIs based on GPU type.
Summary of ChangesHello @mohnjiles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, labeled as v2.15.5, significantly expands the application's capabilities by integrating new AI video generation packages like Wan2GP and an updated Stable Diffusion WebUI Forge - Neo. It also brings crucial improvements to GPU compatibility and performance, particularly for AMD and Nvidia users, through refined architecture detection and updated PyTorch indices. Furthermore, the PR addresses several user experience issues, including a fix for SD.Next launch options and duplicate custom node installations, ensuring a more robust and versatile platform. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces version 2.15.5, bringing a host of new features, updates, and bug fixes. Key additions include the Wan2GP and Stable Diffusion WebUI Forge - Neo packages. The AMD GPU architecture detection has been consolidated and refactored, improving maintainability. Dependencies like Torch and SageAttention have been updated to their latest versions. A notable bug fix makes the --uv argument for SD.Next optional, resolving launch issues for older versions. The codebase is cleaner with the removal of duplicated logic. My review includes a couple of suggestions for improving consistency in the changelog and dependency management for one of the new packages. Overall, this is a solid release with valuable improvements.
|
|
||
| // Install additional packages | ||
| await venvRunner | ||
| .PipInstall("hf-xet setuptools numpy==1.26.4", onConsoleOutput) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The InstallNvidiaAsync method pins setuptools<70.0.0 to avoid distutils compatibility issues with Python 3.10. However, InstallAmdRocmAsync, which uses Python 3.11, installs setuptools without a version pin. Since distutils is also deprecated in Python 3.11, this could lead to similar installation issues. For consistency and to prevent potential build failures, consider pinning setuptools here as well.
.PipInstall("hf-xet \"setuptools<70.0.0\" numpy==1.26.4", onConsoleOutput)| #### 🌟 Visionaries | ||
| To our incredible Visionaries: **Waterclouds**, **JungleDragon**, **bluepopsicle**, **Bob S**, and **whudunit**! Your generosity drives this project forward and helps us turn ideas into reality. Thank you for being such a vital part of Stability Matrix! | ||
| #### 🚀 Pioneers | ||
| A massive thank you to our Pioneer crew! Your support keeps the lights on and the updates flowing. Shoutout to: **Szir777**, **Noah M**, **[USA]TechDude**, **Thom**, **SeraphOfSalem**, **Desert Viber**, **Adam**, **Droolguy**, **ACTUALLY_the_Real_Willem_Dafoe**, **takyamtom**, **robek**, **Phil R**, **Tundra Everquill**, **TheTekknician**, and a warm welcome to our new Pioneers, **Benjamin M** and **Ghislain G**! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading levels for "Visionaries" and "Pioneers" are ####, which is inconsistent with the ### level used for "Added", "Changed", and "Fixed". For better document structure and visual consistency, consider using ### for these sections as well. This would also align with the formatting in the pull request description.
| #### 🌟 Visionaries | |
| To our incredible Visionaries: **Waterclouds**, **JungleDragon**, **bluepopsicle**, **Bob S**, and **whudunit**! Your generosity drives this project forward and helps us turn ideas into reality. Thank you for being such a vital part of Stability Matrix! | |
| #### 🚀 Pioneers | |
| A massive thank you to our Pioneer crew! Your support keeps the lights on and the updates flowing. Shoutout to: **Szir777**, **Noah M**, **[USA]TechDude**, **Thom**, **SeraphOfSalem**, **Desert Viber**, **Adam**, **Droolguy**, **ACTUALLY_the_Real_Willem_Dafoe**, **takyamtom**, **robek**, **Phil R**, **Tundra Everquill**, **TheTekknician**, and a warm welcome to our new Pioneers, **Benjamin M** and **Ghislain G**! | |
| ### 🌟 Visionaries | |
| To our incredible Visionaries: **Waterclouds**, **JungleDragon**, **bluepopsicle**, **Bob S**, and **whudunit**! Your generosity drives this project forward and helps us turn ideas into reality. Thank you for being such a vital part of Stability Matrix! | |
| ### 🚀 Pioneers | |
| A massive thank you to our Pioneer crew! Your support keeps the lights on and the updates flowing. Shoutout to: **Szir777**, **Noah M**, **[USA]TechDude**, **Thom**, **SeraphOfSalem**, **Desert Viber**, **Adam**, **Droolguy**, **ACTUALLY_the_Real_Willem_Dafoe**, **takyamtom**, **robek**, **Phil R**, **Tundra Everquill**, **TheTekknician**, and a warm welcome to our new Pioneers, **Benjamin M** and **Ghislain G**! |
Added
--uvargument to the SD.Next launch optionsChanged
Fixed
--uvargument🌟 Visionaries
To our incredible Visionaries: Waterclouds, JungleDragon, bluepopsicle, Bob S, and whudunit! Your generosity drives this project forward and helps us turn ideas into reality. Thank you for being such a vital part of Stability Matrix!
🚀 Pioneers
A massive thank you to our Pioneer crew! Your support keeps the lights on and the updates flowing. Shoutout to: Szir777, Noah M, [USA]TechDude, Thom, SeraphOfSalem, Desert Viber, Adam, Droolguy, ACTUALLY_the_Real_Willem_Dafoe, takyamtom, robek, Phil R, Tundra Everquill, TheTekknician, and a warm welcome to our new Pioneers, Benjamin M and Ghislain G!