Skip to content

Commit 572283b

Browse files
M2ABRAMSTANKclaude
andcommitted
Sync devcontainer template updates from upstream
Synced devcontainer-related changes from upstream commit abbe60c: - Updated GitHub Actions workflows to use devcontainer CI - Removed deprecated test files and VS Code configuration - Added new patterns to .gitignore for local-only files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 330f800 commit 572283b

File tree

8 files changed

+45
-224
lines changed

8 files changed

+45
-224
lines changed

.claude/settings.local.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/workflows/presubmits.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,14 @@ jobs:
1313
validate-signals:
1414
runs-on: ubuntu-latest
1515
steps:
16-
# Step 1: Check out the current repository
1716
- uses: actions/checkout@v4
1817

19-
# Step 2: Check out the central schema repository
2018
- name: Checkout schemas repo
2119
uses: actions/checkout@v4
2220
with:
2321
repository: OBDb/.schemas
2422
path: .schemas
2523

26-
# Step 3: Validate with schema from the central repository
2724
- name: Validate signalsets
2825
id: json-yaml-validate-v3
2926
uses: GrantBirki/json-yaml-validate@v2.7.1

.github/workflows/response_tests.yml

Lines changed: 42 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,39 +8,58 @@ on:
88

99
permissions:
1010
contents: read
11+
pull-requests: write
1112

1213
jobs:
1314
test:
1415
runs-on: ubuntu-latest
1516
steps:
16-
- name: Checkout main repository
17+
- name: Checkout repository
1718
uses: actions/checkout@v4
1819

19-
- name: Checkout schemas repo
20-
uses: actions/checkout@v4
20+
- name: Run tests in devcontainer
21+
id: test
22+
uses: devcontainers/ci@v0.3
2123
with:
22-
repository: OBDb/.schemas
23-
path: tests/schemas
24+
imageName: ghcr.io/obdb/devcontainer
25+
push: never
26+
env: |
27+
GITHUB_SERVER_URL=${{ github.server_url }}
28+
GITHUB_REPOSITORY=${{ github.repository }}
29+
GITHUB_SHA=${{ github.sha }}
30+
GITHUB_RUN_ID=${{ github.run_id }}
31+
runCmd: |
32+
pytest tests/ --ignore=tests/schemas -xvs -n auto > ./test-output.txt 2>&1
33+
TEST_EXIT=$?
34+
cat ./test-output.txt
2435
25-
- name: Set up Python
26-
uses: actions/setup-python@v4
27-
with:
28-
python-version: '3.13'
29-
cache: 'pip'
36+
# Format results for PR comment with all required arguments
37+
/usr/local/bin/format-test-results.sh \
38+
test-output.txt \
39+
$TEST_EXIT \
40+
"$GITHUB_SERVER_URL" \
41+
"$GITHUB_REPOSITORY" \
42+
"$GITHUB_SHA" \
43+
"$GITHUB_RUN_ID" \
44+
> ./test-results.md || true
3045
31-
- name: Install dependencies
32-
run: |
33-
python -m pip install --upgrade pip
34-
pip install -r tests/schemas/requirements.txt
46+
# Exit with the actual test result
47+
exit $TEST_EXIT
3548
36-
- name: Run tests
37-
id: run_tests
49+
- name: Set test results output
50+
if: always() && github.event_name == 'pull_request'
3851
run: |
39-
pytest tests/ --ignore=tests/schemas -xvs -n auto
40-
continue-on-error: true
52+
if [ -f test-results.md ]; then
53+
{
54+
echo 'TEST_RESULTS<<EOFMARKER'
55+
cat test-results.md
56+
echo 'EOFMARKER'
57+
} >> $GITHUB_ENV
58+
fi
4159
42-
- name: Print fix instructions
43-
if: steps.run_tests.outcome == 'failure'
44-
run: |
45-
echo "::notice title=How to fix failed tests::To fix the failed tests, run: python3 tests/update_yaml_tests.py --verbose"
46-
exit 1
60+
- name: Comment test results on PR
61+
if: always() && github.event_name == 'pull_request'
62+
uses: thollander/actions-comment-pull-request@v2
63+
with:
64+
message: ${{ env.TEST_RESULTS }}
65+
comment_tag: response-tests

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
tests/schemas/
22
__pycache__
33
.claude/skills
4+
.claude/settings.local.json
5+
tests/*.py
6+
.vscode/*.json

.vscode/settings.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

.vscode/tasks.json

Lines changed: 0 additions & 39 deletions
This file was deleted.

tests/test_responses.py

Lines changed: 0 additions & 41 deletions
This file was deleted.

tests/update_yaml_tests.py

Lines changed: 0 additions & 93 deletions
This file was deleted.

0 commit comments

Comments
 (0)