feat: /post open <player> [target] first implementation

Author: Technofied

build.gradle.kts

@@ -1,7 +1,7 @@
 plugins {
     java
     id("xyz.jpenilla.run-paper") version "2.3.0"
-    id("io.github.goooler.shadow") version "8.1.8"
+    id("com.gradleup.shadow") version "9.3.1"
 }
 
 group = "io.github.md5sha256"

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.0-bin.zip
 networkTimeout=10000
 validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME

src/main/java/io/github/md5sha256/democracypost/DemocracyPost.java

@@ -56,6 +56,11 @@ public void onEnable() {
         if (!isEnabled()) {
             return;
         }
+        if (this.databaseAdapter == null) {
+            getLogger().severe("Database was not initialized (onLoad failed). Plugin will not enable.");
+            getServer().getPluginManager().disablePlugin(this);
+            return;
+        }
         if (getServer().getPluginManager().getPlugin("Vault") == null) {
             getLogger().severe("Missing Vault!");
             getServer().getPluginManager().disablePlugin(this);
@@ -89,6 +94,9 @@ public void onEnable() {
         getServer().getScheduler().runTaskTimerAsynchronously(
                 this,
                 () -> {
+                    if (this.databaseAdapter == null) {
+                        return;
+                    }
                     getLogger().fine("Transferring expired packages...");
                     try {
                         this.databaseAdapter.transferExpiredPackages(returnPackageExpiryDuration);

src/main/java/io/github/md5sha256/democracypost/command/PostCommand.java

@@ -9,7 +9,6 @@
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
 import org.bukkit.plugin.Plugin;
-import org.checkerframework.checker.units.qual.A;
 import org.incendo.cloud.SenderMapper;
 import org.incendo.cloud.annotations.AnnotationParser;
 import org.incendo.cloud.annotations.Argument;
@@ -54,6 +53,19 @@ public void commandOpen(
                 });
     }
 
+    @Command("post open <player> <target>")
+    @Permission("democracypost.open")
+    public void commandOpenWithTarget(
+            @Nonnull @Argument(value = "player") Player player,
+            @Nonnull @Argument(value = "target") OfflinePlayer target
+    ) {
+        if (!target.hasPlayedBefore()) {
+            player.sendMessage(Component.text("Unknown or invalid target player.", NamedTextColor.RED));
+            return;
+        }
+        this.postOfficeMenu.createParcelPostUi(target).show(player);
+    }
+
     @Command("post view <player>")
     @Permission("democracypost.view")
     public void commandView(

src/main/java/io/github/md5sha256/democracypost/ui/PostOfficeMenu.java

@@ -143,6 +143,10 @@ public InventoryGui createPostUi(String playerName, List<PostalPackage> packages
     }
 
     public InventoryGui createParcelPostUi() {
+        return createParcelPostUi(null);
+    }
+
+    public InventoryGui createParcelPostUi(@javax.annotation.Nullable OfflinePlayer recipient) {
         String[] rows = new String[]{
                 "         ",
                 " ddddddd ",
@@ -154,13 +158,14 @@ public InventoryGui createParcelPostUi() {
         // blank space = panes
         // b = back, p = post parcel, e = exit
         Inventory storageInv = this.plugin.getServer().createInventory(null, 9 * 3);
+        UUID recipientUuid = recipient != null && recipient.hasPlayedBefore() ? recipient.getUniqueId() : null;
         InventoryGui gui = createGui(
                 this.messageContainer.messageFor("menu.parcel.drop"),
                 rows,
                 elementPanes(' '),
                 elementDrop('d', storageInv),
                 elementBack('b', player -> returnAndClearItems(player, storageInv)),
-                elementPost('p', storageInv)
+                elementPost('p', storageInv, recipientUuid)
         );
         gui.setCloseAction(close -> handleInventoryClose(close, storageInv));
         return gui;
@@ -413,7 +418,7 @@ private GuiElement elementPrevious(char c) {
                 LegacyComponentSerializer.legacySection().serialize(displayName));
     }
 
-    private GuiElement elementPost(char c, Inventory storageInv) {
+    private GuiElement elementPost(char c, Inventory storageInv, @javax.annotation.Nullable UUID recipientUuid) {
         ItemStack itemStack = this.itemFactory.createSendPackageButton();
         ItemMeta meta = itemStack.getItemMeta();
         Component displayName = this.messageContainer.messageFor("menu.main.post-parcel")
@@ -422,7 +427,7 @@ private GuiElement elementPost(char c, Inventory storageInv) {
         itemStack.setItemMeta(meta);
         StaticGuiElement element = new StaticGuiElement(c, itemStack);
         element.setAction(action -> {
-            processPost(action, element, itemStack, storageInv);
+            processPost(action, element, itemStack, storageInv, recipientUuid);
             return true;
         });
         return element;
@@ -432,9 +437,9 @@ private void processPost(
             GuiElement.Click action,
             StaticGuiElement element,
             ItemStack display,
-            Inventory storageInv) {
-        // Don't clear the storage inv, items will be added back
-        if (!(action.getWhoClicked() instanceof Conversable conversable)) {
+            Inventory storageInv,
+            @javax.annotation.Nullable UUID recipientUuid) {
+        if (!(action.getWhoClicked() instanceof Player player)) {
             return;
         }
         List<ItemStack> items = new ArrayList<>();
@@ -455,6 +460,36 @@ private void processPost(
         }
         // Clear the storage inv here
         storageInv.clear();
+
+        if (recipientUuid != null) {
+            // Send directly to pre-specified recipient (no prompt)
+            OfflinePlayer recipient = this.plugin.getServer().getOfflinePlayer(recipientUuid);
+            if (!recipient.hasPlayedBefore()) {
+                String name = recipient.getName() != null ? recipient.getName() : recipientUuid.toString();
+                player.sendMessage(this.messageContainer.messageFor("prompt.post-parcel.unknown-player")
+                        .replaceText(builder -> builder.matchLiteral("%player%").replacement(name)));
+                InventoryUtil.addItems(player, items);
+                return;
+            }
+            if (player.getUniqueId().equals(recipientUuid)) {
+                player.sendMessage(this.messageContainer.messageFor("prompt.post-parcel.send-parcel-self"));
+                InventoryUtil.addItems(player, items);
+                return;
+            }
+            var response = this.economy.withdrawPlayer(player, this.postSettings.postPrice());
+            if (!response.transactionSuccess()) {
+                player.sendMessage(this.messageContainer.messageFor("prompt.post-parcel.insufficient-balance"));
+                InventoryUtil.addItems(player, items);
+                return;
+            }
+            this.postalPackageFactory.createAndPostPackage(player.getUniqueId(), recipientUuid, items, false);
+            player.sendMessage(this.messageContainer.messageFor("prompt.post-parcel.send-parcel-success"));
+            action.getGui().close(player, true);
+            return;
+        }
+
+        // No recipient: start conversation to ask for username
+        Conversable conversable = (Conversable) player;
         // Copy the current history
         Deque<InventoryGui> history = new ArrayDeque<>(InventoryGui.getHistory(action.getWhoClicked()));
         // Remove the current UI so it isn't added back
@@ -477,7 +512,6 @@ private void processPost(
                 .buildConversation(conversable);
         conversation.addConversationAbandonedListener(event -> {
             if (!event.gracefulExit()) {
-                // If the conversation is abandoned, give the items back to the player
                 InventoryUtil.addItems(action.getWhoClicked(), items);
             }
             Conversable who = event.getContext().getForWhom();
@@ -488,7 +522,6 @@ private void processPost(
                 }
             }
         });
-        // Start conversation to send
         conversation.begin();
     }