Refresh conditional setting visibility for module and HUD settings

This makes conditional setting visibility updates systemic instead of value-only.

Backend setting-change broadcasts now include a full visibility map for the affected module/HUD element.

Frontend stores apply that visibility map on each setting update, so dependent controls refresh immediately when parent modes/options change.

This fixes stale UI for mode-dependent settings (NoFall was just one visible symptom) across Meteor and addon modules.

Author: GhostTypes

src/main/java/com/cope/meteorwebgui/mapping/HudMapper.java

@@ -132,6 +132,17 @@ public static JsonObject createHudSettingChangeMessage(HudElement element, Setti
         data.addProperty("elementName", getElementIdentifier(element));
         data.addProperty("settingName", setting.name);
         data.add("value", SettingsReflector.getSettingValue(setting, SettingsReflector.detectSettingType(setting)));
+        data.add("visibility", createSettingVisibilityMap(element));
         return data;
     }
+
+    private static JsonObject createSettingVisibilityMap(HudElement element) {
+        JsonObject visibility = new JsonObject();
+        for (SettingGroup group : element.settings) {
+            for (Setting<?> setting : group) {
+                visibility.addProperty(setting.name, setting.isVisible());
+            }
+        }
+        return visibility;
+    }
 }

src/main/java/com/cope/meteorwebgui/mapping/ModuleMapper.java

@@ -139,9 +139,20 @@ public static JsonObject createSettingChangeMessage(Module module, Setting<?> se
         data.addProperty("moduleName", module.name);
         data.addProperty("settingName", setting.name);
         data.add("value", SettingsReflector.getSettingValue(setting, SettingsReflector.detectSettingType(setting)));
+        data.add("visibility", createSettingVisibilityMap(module));
         return data;
     }
 
+    private static JsonObject createSettingVisibilityMap(Module module) {
+        JsonObject visibility = new JsonObject();
+        for (SettingGroup group : module.settings) {
+            for (Setting<?> setting : group) {
+                visibility.addProperty(setting.name, setting.isVisible());
+            }
+        }
+        return visibility;
+    }
+
     /**
      * Get list of all favorite module names
      */

webui/package-lock.json

@@ -99,14 +99,22 @@ export const useHudStore = defineStore('hud', () => {
     if (typeof payload.height === 'number') element.height = payload.height
   }
 
-  function updateSettingValue(elementName: string, settingName: string, value: any) {
+  function updateSettingValue(
+    elementName: string,
+    settingName: string,
+    value: any,
+    visibility?: Record<string, boolean>
+  ) {
     const element = elements.value[elementName]
     if (!element?.settingGroups) return
     for (const group of element.settingGroups) {
-      const setting = group.settings.find(s => s.name === settingName)
-      if (setting) {
-        setting.value = value
-        return
+      for (const setting of group.settings) {
+        if (setting.name === settingName) {
+          setting.value = value
+        }
+        if (visibility && Object.prototype.hasOwnProperty.call(visibility, setting.name)) {
+          setting.visible = Boolean(visibility[setting.name])
+        }
       }
     }
   }

webui/src/stores/hud.ts

@@ -76,18 +76,27 @@ export const useModulesStore = defineStore('modules', () => {
     }
   }
 
-  function updateSettingValue(moduleName: string, settingName: string, value: any) {
+  function updateSettingValue(
+    moduleName: string,
+    settingName: string,
+    value: any,
+    visibility?: Record<string, boolean>
+  ) {
     // Find the module and update the setting
     for (const category in byCategory.value) {
       const module = byCategory.value[category].find(m => m.name === moduleName)
       if (module && module.settingGroups) {
         for (const group of module.settingGroups) {
-          const setting = group.settings.find(s => s.name === settingName)
-          if (setting) {
-            setting.value = value
-            return
+          for (const setting of group.settings) {
+            if (setting.name === settingName) {
+              setting.value = value
+            }
+            if (visibility && Object.prototype.hasOwnProperty.call(visibility, setting.name)) {
+              setting.visible = Boolean(visibility[setting.name])
+            }
           }
         }
+        return
       }
     }
   }

webui/src/stores/modules.ts

@@ -128,7 +128,8 @@ export const useWebSocketStore = defineStore('websocket', () => {
         modulesStore.updateSettingValue(
           message.data.moduleName,
           message.data.settingName,
-          message.data.value
+          message.data.value,
+          message.data.visibility
         )
         break
 
@@ -169,7 +170,12 @@ export const useWebSocketStore = defineStore('websocket', () => {
         break
 
       case 'hud.setting.value.changed':
-        hudStore.updateSettingValue(message.data.elementName, message.data.settingName, message.data.value)
+        hudStore.updateSettingValue(
+          message.data.elementName,
+          message.data.settingName,
+          message.data.value,
+          message.data.visibility
+        )
         break
 
       case 'error':