disassembly performance improvements

Author: 1fbff5f83b23d39d38b1dfcb4cac8d9b

byond-extools/src/core/various_testing.cpp

@@ -64,7 +64,7 @@ void init_testing()
 {
 	Core::enable_profiling();
 	debugger_initialize();
-	bool find_unknowns = false;
+	bool find_unknowns = true;
 	if (find_unknowns)
 	{
 		std::ofstream log("unknown_opcodes.txt");

byond-extools/src/dmdism/callbacks.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <map>
+#include <typeindex>
 
 #include "opcodes.h"
 
@@ -16,6 +17,10 @@
 
 #define ADD_CALLBACK(op) { op, []() -> Instruction* { return new Instr_##op(op); } },
 
+const std::map<Bytecode, std::type_index> type_callbacks = {
+
+};
+
 const std::map<Bytecode, std::function<Instruction*()>> callbacks = {
 	ADD_CALLBACK(END)
 	ADD_CALLBACK(NEW)

byond-extools/src/dmdism/disassembler.cpp

@@ -24,11 +24,12 @@ Disassembler::Disassembler(std::uint32_t* bc, unsigned int bc_len, std::vector<C
 Disassembly Disassembler::disassemble()
 {
 	std::vector<Instruction> instrs;
+	instrs.reserve(512);
 	while (context_->more()) {
 		instrs.push_back(disassemble_next());
 	}
 
-	return Disassembly(instrs);
+	return Disassembly(std::move(instrs));
 }
 
 Instruction Disassembler::disassemble_next()
@@ -37,9 +38,10 @@ Instruction Disassembler::disassemble_next()
 
 	auto root = context_->eat();
 
-	if (callbacks.find(static_cast<Bytecode>(root)) != callbacks.end())
+	auto cb = callbacks.find(static_cast<Bytecode>(root));
+	if (cb != callbacks.end())
 	{
-		instr = callbacks.at(static_cast<Bytecode>(root))();
+		instr = cb->second();
 	}
 	else
 	{

byond-extools/src/dmdism/disassembly.h

@@ -7,7 +7,7 @@
 class Disassembly
 {
 public:
-	Disassembly(std::vector<Instruction> i) : instructions(i) {}
+	Disassembly(std::vector<Instruction>&& i) : instructions(std::move(i)) {}
 	//~Disassembly() { for (auto i : instructions) delete& i; } //heap corruption woo
 	std::vector<Instruction> instructions;
 	Core::Proc proc;

byond-extools/src/dmdism/instruction.h

@@ -33,7 +33,7 @@ class Instruction
 
 	Opcode& opcode() { return opcode_; }
 
-	std::string comment() const { return comment_; }
+	std::string comment() { return comment_; }
 	void set_comment(std::string comment) { comment_ = comment; }
 	void add_comment(std::string comment) { comment_ += comment; }