Skip to content

Commit 1c54a29

Browse files
committed
core: pre-commit
1 parent a12c41d commit 1c54a29

File tree

4 files changed

+23
-11
lines changed

4 files changed

+23
-11
lines changed

tests/conftest.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
import contextlib
12
import sys
23
import types
3-
import contextlib
4-
from typing import Iterable
4+
from collections.abc import Iterable
55

66
import pytest
77

@@ -11,6 +11,7 @@
1111
def _make_fn(name: str):
1212
def _fn(*args, **kwargs):
1313
return {"__tool_name__": name}
14+
1415
_fn.__name__ = name
1516
return _fn
1617

@@ -53,4 +54,4 @@ def install_fake_jupyter_server(tool_names: Iterable[str]):
5354

5455
@pytest.fixture(scope="session")
5556
def known_tools():
56-
return load_known_tools()["known_tools"]
57+
return load_known_tools()["known_tools"]

tests/test_config_loader.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
from mcpstack_jupyter.tools.jupyter.utils.config_loader import (
2-
load_known_tools,
3-
load_env_defaults,
42
load_cli_defaults,
3+
load_env_defaults,
4+
load_known_tools,
55
)
66

7+
78
def test_known_tools_and_read_only_lists():
89
data = load_known_tools()
910
known = data["known_tools"]
@@ -13,9 +14,10 @@ def test_known_tools_and_read_only_lists():
1314
assert "read_all_cells" in known
1415
assert set(ro).issubset(set(known))
1516

17+
1618
def test_env_and_cli_defaults_present():
1719
env = load_env_defaults()
1820
cli = load_cli_defaults()
1921
assert "provider" in env
2022
assert "document_url" in env
21-
assert "output_filename" in cli
23+
assert "output_filename" in cli

tests/test_jupyter_bindings.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,23 @@ def test_missing_upstream_tool_raises_attribute_error(known_tools):
4141
def test_env_mapping_defaults_and_overrides(monkeypatch, known_tools):
4242
defaults = load_env_defaults()
4343
with install_fake_jupyter_server(known_tools) as server:
44-
for k in ["PROVIDER","DOCUMENT_URL","DOCUMENT_ID","DOCUMENT_TOKEN",
45-
"RUNTIME_URL","RUNTIME_ID","RUNTIME_TOKEN"]:
44+
for k in [
45+
"PROVIDER",
46+
"DOCUMENT_URL",
47+
"DOCUMENT_ID",
48+
"DOCUMENT_TOKEN",
49+
"RUNTIME_URL",
50+
"RUNTIME_ID",
51+
"RUNTIME_TOKEN",
52+
]:
4653
monkeypatch.delenv(k, raising=False)
4754
tool = Jupyter()
4855
tool.initialize()
4956

5057
assert server.PROVIDER == defaults.get("provider", "jupyter")
51-
assert server.DOCUMENT_URL == defaults.get("document_url", "http://127.0.0.1:8888")
58+
assert server.DOCUMENT_URL == defaults.get(
59+
"document_url", "http://127.0.0.1:8888"
60+
)
5261
assert server.DOCUMENT_ID == defaults.get("document_id", "notebook.ipynb")
5362
assert server.RUNTIME_URL == defaults.get("runtime_url") or server.DOCUMENT_URL
5463

@@ -76,4 +85,4 @@ def test_env_mapping_defaults_and_overrides(monkeypatch, known_tools):
7685
def test_to_from_dict_roundtrip():
7786
src = {"include": ["read_all_cells", "get_notebook_info"]}
7887
tool = Jupyter.from_dict(src)
79-
assert tool.to_dict() == src
88+
assert tool.to_dict() == src

tests/test_status_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ def test_status_verbose_lists_availability(known_tools, capsys):
1919
JupyterCLI.status(verbose=True)
2020
out = capsys.readouterr().out
2121
assert "Upstream Tool Availability" in out
22-
assert re.search(r"\byes\b", out, re.IGNORECASE)
22+
assert re.search(r"\byes\b", out, re.IGNORECASE)

0 commit comments

Comments
 (0)