Skip to content

Commit 5cb3900

Browse files
Simplify evals dash cont.
1 parent 6d25d6f commit 5cb3900

File tree

10 files changed

+1079
-968
lines changed

10 files changed

+1079
-968
lines changed

mcpjam-inspector/client/src/components/evals/ci-suite-detail.tsx

Lines changed: 36 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { useEffect, useMemo, useState } from "react";
22
import { SuiteHeader } from "./suite-header";
3-
import { RunOverview } from "./run-overview";
3+
import { SuiteHeroStats } from "./suite-hero-stats";
4+
import { RunAccordionView } from "./run-accordion-view";
45
import { RunDetailView } from "./run-detail-view";
5-
import { TestCasesOverview } from "./test-cases-overview";
66
import { TestCaseDetailView } from "./test-case-detail-view";
77
import { useSuiteData, useRunDetailData } from "./use-suite-data";
88
import type {
@@ -66,15 +66,10 @@ export function CiSuiteDetail({
6666
: route.type === "test-detail"
6767
? "test-detail"
6868
: "overview";
69-
const runsViewMode =
70-
route.type === "suite-overview" && route.view === "test-cases"
71-
? "test-cases"
72-
: "runs";
73-
7469
const [showRunSummarySidebar, setShowRunSummarySidebar] = useState(false);
7570
const [runDetailSortBy, setRunDetailSortBy] = useState<
7671
"model" | "test" | "result"
77-
>("test");
72+
>("result");
7873

7974
const { runTrendData, modelStats } = useSuiteData(
8075
suite,
@@ -158,7 +153,7 @@ export function CiSuiteDetail({
158153
navigateToCiEvalsRoute({
159154
type: "suite-overview",
160155
suiteId: suite._id,
161-
view: runsViewMode,
156+
view: "test-cases",
162157
});
163158
};
164159

@@ -186,7 +181,7 @@ export function CiSuiteDetail({
186181
deletingRunId={deletingRunId}
187182
showRunSummarySidebar={showRunSummarySidebar}
188183
setShowRunSummarySidebar={setShowRunSummarySidebar}
189-
runsViewMode={runsViewMode}
184+
runsViewMode={"test-cases"}
190185
runs={runs}
191186
allIterations={allIterations}
192187
aggregate={aggregate}
@@ -214,6 +209,13 @@ export function CiSuiteDetail({
214209
iterations={caseIterations}
215210
runs={runs}
216211
serverNames={connectedSuiteServers}
212+
suiteName={suite.name}
213+
onNavigateToSuite={() => {
214+
navigateToCiEvalsRoute({
215+
type: "suite-overview",
216+
suiteId: suite._id,
217+
});
218+
}}
217219
onBack={() => {
218220
navigateToCiEvalsRoute({
219221
type: "suite-overview",
@@ -232,54 +234,30 @@ export function CiSuiteDetail({
232234
);
233235
})()
234236
) : viewMode === "overview" ? (
235-
<div key={runsViewMode} className="space-y-4">
236-
{runsViewMode === "runs" ? (
237-
<RunOverview
238-
suite={suite}
239-
runs={runs}
240-
runsLoading={runsLoading}
241-
allIterations={allIterations}
242-
runTrendData={runTrendData}
243-
modelStats={modelStats}
244-
onRunClick={handleRunClick}
245-
onDirectDeleteRun={onDirectDeleteRun}
246-
runsViewMode={runsViewMode}
247-
onViewModeChange={(value) => {
248-
navigateToCiEvalsRoute({
249-
type: "suite-overview",
250-
suiteId: suite._id,
251-
view: value,
252-
});
253-
}}
254-
userMap={userMap}
255-
/>
256-
) : (
257-
<TestCasesOverview
258-
suite={suite}
259-
cases={cases}
260-
allIterations={allIterations}
261-
runs={runs}
262-
runsViewMode={runsViewMode}
263-
onViewModeChange={(value) => {
264-
navigateToCiEvalsRoute({
265-
type: "suite-overview",
266-
suiteId: suite._id,
267-
view: value,
268-
});
269-
}}
270-
onTestCaseClick={(testCaseId) => {
271-
navigateToCiEvalsRoute({
272-
type: "test-detail",
273-
suiteId: suite._id,
274-
testId: testCaseId,
275-
});
276-
}}
277-
runTrendData={runTrendData}
278-
modelStats={modelStats}
279-
runsLoading={runsLoading}
280-
onRunClick={handleRunClick}
281-
/>
282-
)}
237+
<div className="space-y-4 overflow-y-auto h-full p-0.5">
238+
<SuiteHeroStats
239+
runs={runs}
240+
allIterations={allIterations}
241+
runTrendData={runTrendData}
242+
modelStats={modelStats}
243+
testCaseCount={cases.length}
244+
isSDK={suite.source === "sdk"}
245+
onRunClick={handleRunClick}
246+
/>
247+
<RunAccordionView
248+
suite={suite}
249+
runs={runs}
250+
allIterations={allIterations}
251+
onRunClick={handleRunClick}
252+
onTestCaseClick={(testCaseId) => {
253+
navigateToCiEvalsRoute({
254+
type: "test-detail",
255+
suiteId: suite._id,
256+
testId: testCaseId,
257+
});
258+
}}
259+
userMap={userMap}
260+
/>
283261
</div>
284262
) : viewMode === "run-detail" && selectedRunDetails ? (
285263
<RunDetailView

0 commit comments

Comments
 (0)