Skip to content

skill modal included in hosted#1694

Merged
ignaciojimenezr merged 1 commit intoMCPJam:mainfrom
ignaciojimenezr:hosted-skills-learn-more
Mar 30, 2026
Merged

skill modal included in hosted#1694
ignaciojimenezr merged 1 commit intoMCPJam:mainfrom
ignaciojimenezr:hosted-skills-learn-more

Conversation

@ignaciojimenezr
Copy link
Copy Markdown
Collaborator

@ignaciojimenezr ignaciojimenezr commented Mar 30, 2026

Learn more hover modal for skills wasn't working in hosted. now it does mentioning that skills are only for npx/electron

Before:
image
After:
image

@chelojimenez
Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ignaciojimenezr ignaciojimenezr marked this pull request as ready for review March 30, 2026 06:26
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 30, 2026
@dosubot dosubot bot added the bug Something isn't working label Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9dcc726a-341f-479e-8ad0-ed3c11c15296

📥 Commits

Reviewing files that changed from the base of the PR and between 5bf5d6f and 5e09e64.

📒 Files selected for processing (3)
  • mcpjam-inspector/client/src/components/learn-more/LearnMoreHoverCard.tsx
  • mcpjam-inspector/client/src/components/sidebar/__tests__/nav-main.test.tsx
  • mcpjam-inspector/client/src/components/sidebar/nav-main.tsx

Walkthrough

This change extends the hover card system to surface disabled item tooltips through the LearnMoreHoverCard component. An optional disabledMessage prop was added to LearnMoreHoverCard and rendered conditionally as italic, muted text. The nav-main component now passes disabled tooltips to this new prop when displaying hover cards for disabled navigation items, and removes redundant title attributes to prevent duplicate tooltip presentation. Test coverage was expanded to verify hover card rendering for disabled items with and without learn-more content.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 30, 2026
@ignaciojimenezr ignaciojimenezr merged commit 5e4d05a into MCPJam:main Mar 30, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants