Skip to content

Commit 7c0daab

Browse files
authored
Merge pull request #109 from MDAnalysis/update_ci
Update ci
2 parents 8cc5610 + ca5e0de commit 7c0daab

File tree

7 files changed

+28
-24
lines changed

7 files changed

+28
-24
lines changed

.github/workflows/CI.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ on:
1010
pull_request:
1111
branches:
1212
- "main"
13+
workflow_dispatch:
1314
schedule:
1415
# Midnight Tuesdays and Fridays
1516
- cron: "0 0 * * 2,5"
@@ -29,7 +30,7 @@ jobs:
2930

3031
- uses: actions/setup-python@v5
3132
with:
32-
python-version: "3.9"
33+
python-version: "3.11"
3334
cache: pip
3435
cache-dependency-path: pyproject.toml
3536

@@ -43,8 +44,8 @@ jobs:
4344
strategy:
4445
fail-fast: false
4546
matrix:
46-
os: [macOS-latest, ubuntu-latest, windows-latest]
47-
python-version: [3.9, "3.10", 3.11, 3.12]
47+
os: [macOS-latest, ubuntu-latest]
48+
python-version: [3.11, 3.12, 3.13]
4849

4950
steps:
5051
- uses: actions/checkout@v3

.github/workflows/draft-pdf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
# This should be the path to the paper within your repo.
1515
paper-path: joss_paper/paper.md
1616
- name: Upload
17-
uses: actions/upload-artifact@v1
17+
uses: actions/upload-artifact@v4
1818
with:
1919
name: paper
2020
# This is the output path where Pandoc will write the compiled

docs/requirements.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,18 @@ channels:
44
- defaults
55
dependencies:
66
# Base depends
7-
- python
7+
- python=3.12
88
- pip
9-
- numpy
9+
- numpy>=2.2
1010
- pytest
11-
- mdanalysis
11+
- mdanalysis>=2.8
12+
- pandas>=2.2
1213
- nglview
1314
- nbsphinx
1415
- ipython
1516
- plotly
1617
- sphinx_rtd_theme
17-
- scipy==1.12.0
18+
- scipy
1819

1920

2021
# Pip-only installs

pyproject.toml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ maintainers = [
1919
{name = 'Hugo MacDermott-Opeskin', email = '[email protected]'}
2020

2121
]
22-
requires-python = ">=3.8"
22+
requires-python = ">=3.11"
2323

2424
keywords = [
2525
"python", "science", "chemistry", "biophysics", "molecular-dynamics",
@@ -28,9 +28,9 @@ keywords = [
2828
]
2929

3030
dependencies = [
31-
'numpy>=1.20.0',
31+
'numpy>=2.2',
3232
'pandas>=2.2',
33-
'mdanalysis>=2.0.0',
33+
'mdanalysis>=2.8',
3434
'pytest',
3535
'matplotlib',
3636
'setuptools',
@@ -49,10 +49,9 @@ classifiers = [
4949
'Operating System :: MacOS :: MacOS X',
5050
'Operating System :: Microsoft :: Windows',
5151
'Programming Language :: Python',
52-
'Programming Language :: Python :: 3.8',
53-
'Programming Language :: Python :: 3.9',
54-
'Programming Language :: Python :: 3.10',
5552
'Programming Language :: Python :: 3.11',
53+
'Programming Language :: Python :: 3.12',
54+
'Programming Language :: Python :: 3.13',
5655
'Topic :: Scientific/Engineering',
5756
'Topic :: Scientific/Engineering :: Bio-Informatics',
5857
'Topic :: Scientific/Engineering :: Chemistry',

readthedocs.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@ build:
99

1010
conda:
1111
environment: docs/requirements.yaml
12+
13+
sphinx:
14+
configuration: docs/conf.py

solvation_analysis/rdf_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -375,10 +375,10 @@ def identify_cutoff_poly(
375375
cr_pts, cr_vals = identify_minima(f)
376376
if not good_cutoff(cutoff_region, cr_pts, cr_vals):
377377
if failure_behavior == "silent":
378-
return np.NaN
378+
return np.nan
379379
if failure_behavior == "warn":
380380
warnings.warn("No solvation shell detected.")
381-
return np.NaN
381+
return np.nan
382382
if failure_behavior == "exception":
383383
raise RuntimeError(
384384
"Solute could not identify a solvation radius for at least one solvent. "

solvation_analysis/tests/test_rdf_parser.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def test_good_cutoff(cutoff_region, cr_pts, cr_vals, expected):
8585
@pytest.mark.parametrize(
8686
"rdf_tag, cutoff",
8787
[
88-
("fec_F", np.NaN),
88+
("fec_F", np.nan),
8989
("fec_O", 3.30),
9090
("fec_all", 2.74),
9191
("bn_all", 2.64),
@@ -108,7 +108,7 @@ def test_identify_cutoff_poly_easy(
108108
@pytest.mark.parametrize(
109109
"rdf_tag, cutoff",
110110
[
111-
("fec_F", np.NaN),
111+
("fec_F", np.nan),
112112
("fec_O", 3.30),
113113
("fec_all", 2.74),
114114
("bn_all", 2.64),
@@ -122,7 +122,7 @@ def test_identify_cutoff_scipy_easy(
122122
):
123123
bins, rdf = rdf_bins_and_data_easy[rdf_tag]
124124
np.testing.assert_allclose(
125-
identify_cutoff_scipy(bins, rdf, failure_behavior="warn", default=np.NaN),
125+
identify_cutoff_scipy(bins, rdf, failure_behavior="warn", default=np.nan),
126126
cutoff,
127127
atol=0.2,
128128
equal_nan=True,
@@ -148,8 +148,8 @@ def test_identify_scipy_hard(
148148
bins_ez, rdf_ez = rdf_bins_and_data_easy[rdf_tag]
149149
bins_hd, rdf_hd = rdf_bins_and_data_hard[rdf_tag]
150150
np.testing.assert_allclose(
151-
identify_cutoff_scipy(bins_hd, rdf_hd, failure_behavior="warn", default=np.NaN),
152-
identify_cutoff_scipy(bins_ez, rdf_ez, failure_behavior="warn", default=np.NaN),
151+
identify_cutoff_scipy(bins_hd, rdf_hd, failure_behavior="warn", default=np.nan),
152+
identify_cutoff_scipy(bins_ez, rdf_ez, failure_behavior="warn", default=np.nan),
153153
atol=0.2,
154154
equal_nan=True,
155155
)
@@ -201,11 +201,11 @@ def test_identify_cutoff_non_solv(rdf_tag, rdf_bins_and_data_non_solv):
201201
bins, rdf = rdf_bins_and_data_non_solv[rdf_tag]
202202
np.testing.assert_allclose(
203203
identify_cutoff_poly(bins, rdf, failure_behavior="warn"),
204-
np.NaN,
204+
np.nan,
205205
equal_nan=True,
206206
)
207207
np.testing.assert_allclose(
208-
identify_cutoff_scipy(bins, rdf, failure_behavior="warn", default=np.NaN),
209-
np.NaN,
208+
identify_cutoff_scipy(bins, rdf, failure_behavior="warn", default=np.nan),
209+
np.nan,
210210
equal_nan=True,
211211
)

0 commit comments

Comments
 (0)