Merge pull request #76 from MDverse/add-tests-in-ci

test: Mark network as 'network', hence slow

Author: pierrepo

.github/workflows/ci.yml

@@ -21,9 +21,30 @@ jobs:
 
     - name: Install Python
       run: uv python install
-    
+
     - name: Install python dependencies
       run: uv sync --locked --dev
 
     - name: Run pre-commit hooks
       run: uv run prek
+
+  tests:
+    runs-on: ubuntu-24.04
+    timeout-minutes: 15
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v6
+
+    - name: Install uv
+      uses: astral-sh/setup-uv@v7
+      with:
+        enable-cache: true
+
+    - name: Install Python
+      run: uv python install
+
+    - name: Install python dependencies
+      run: uv sync --locked --dev
+
+    - name: Run tests
+      run: uv run pytest -m "not network"

CONTRIBUTING.md

@@ -24,7 +24,7 @@
     uv sync --dev
     ```
 
-6. Install pre-commit hook:
+6. Install pre-commit hooks:
 
     ```sh
     uv run prek install

pytest.toml

@@ -0,0 +1,5 @@
+[pytest]
+addopts = ["--strict-markers"]
+markers = [
+    "network: network tests that require internet access and could be slow",
+]

tests/core/test_network.py

@@ -2,11 +2,14 @@
 
 import json
 
+import pytest
+
 import mdverse_scrapers.core.network as network
 import mdverse_scrapers.core.toolbox as toolbox
 from mdverse_scrapers.core.logger import create_logger
 
 
+@pytest.mark.network
 def test_make_http_get_request_with_retries_200():
     """Test the make_http_get_request_with_retries function."""
     url = "https://httpbin.org/get"
@@ -20,6 +23,7 @@ def test_make_http_get_request_with_retries_200():
     assert response.status_code == 200
 
 
+@pytest.mark.network
 def test_make_http_get_request_with_retries_202():
     """Test the make_http_get_request_with_retries function."""
     url = "https://httpbin.org/status/202"
@@ -32,6 +36,7 @@ def test_make_http_get_request_with_retries_202():
     assert response is None
 
 
+@pytest.mark.network
 def test_make_http_get_request_with_retries_404():
     """Test the make_http_get_request_with_retries function."""
     url = "https://httpbin.org/status/404"
@@ -44,8 +49,9 @@ def test_make_http_get_request_with_retries_404():
     assert response is None
 
 
+@pytest.mark.network
 def test_get_html_page_with_selenium_good_url():
-    """Test the get_html_page_with_selenium function with a bad URL."""
+    """Test the get_html_page_with_selenium function with a good URL."""
     url = "https://figshare.com/ndownloader/files/21988230/preview/21988230/structure.json"
     expected_json = {
         "files": [],
@@ -67,6 +73,7 @@ def test_get_html_page_with_selenium_good_url():
     assert json.loads(content) == expected_json
 
 
+@pytest.mark.network
 def test_get_html_page_with_selenium_bad_url(capsys) -> None:
     """Test the get_html_page_with_selenium function with a bad URL."""
     url = "https://figshare.com/ndownloader/files/28089615/preview/28089615/structure.json"