Skip to content

Commit 27bc1ec

Browse files
authored
Merge pull request #22 from MEOM/tweak/sub-nav
Note about CSS needed for the SVG icons.
2 parents 587aac8 + dd54049 commit 27bc1ec

File tree

5 files changed

+22
-3
lines changed

5 files changed

+22
-3
lines changed

changelog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
# Changelog
2+
## Version 1.0.3 released November 3, 2021
3+
### Added
4+
- Note about `pointer-events: none;` CSS needed for the SVG icons.
25
## Version 1.0.2 released November 2, 2021
36
### Added
47
- Demo for language dropdown.

dist/index.esm.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@meom/navigation",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"description": "MEOM navigation",
55
"homepage": "https://github.com/MEOM/navigation",
66
"repository": {

readme.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,22 @@ if (!navElement || !navToggle) {
114114
new Navigation(navElement, navToggle);
115115
```
116116

117+
## Issues opening and closing the sub menus?
118+
First try adding `pointer-events: none;` CSS to SVG icon inside the sub menu toggles.
119+
120+
For example:
121+
122+
```css
123+
.site-nav__sub-toggle svg,
124+
.site-nav__sub-sub-toggle svg {
125+
pointer-events: none;
126+
}
127+
```
128+
129+
This prevents SVG icon being the clicked target element. In other words it should always the `<button>` itself.
130+
131+
Hopefully this will be fixed in the JS at some point.
132+
117133
## Options
118134

119135
There are several settings (object) which you can pass in as third argument:

0 commit comments

Comments
 (0)