Skip to content

Commit 17f5778

Browse files
rjfarmerrjfarmer
authored
Cleanup ccsn_IIp (#509)
Cleanup ccsn_IIp and test that RTI works Alot of the code in the run_star_extras isn't even used as it was part of inlist_shock_part6 (which did post-shock breakout evolution) which hasn't existed for 2 years. So lets remove it. Also, lets give the many extra controls useful names (which also revealed several controls that overlapped in index). Photo handling has been updated to the newer testhub way of reading and writing photos. Closes #503
1 parent 6a8caae commit 17f5778

13 files changed

+408
-669
lines changed

‎docs/source/known_bugs.rst‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,17 @@ Both issues will effect previous versions of MESA as well.
2626

2727
Both issues have been fixed in the git main branch.
2828

29+
See `gh-491 <https://github.com/MESAHub/mesa/issues/491>`_ and `gh-497 <https://github.com/MESAHub/mesa/issues/497>`_
30+
31+
RTI
32+
===
33+
34+
A bug has existed since shortly after r15140 where RTI mixing will be effectively zero in a model even with the RTI_flag=.true.
35+
36+
This has now been fixed in the git main.
37+
38+
See `gh-503 <https://github.com/MESAHub/mesa/issues/503>`_
39+
2940

3041

3142
r22.05.1

‎star/test_suite/ccsn_IIp/.gitignore‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
mesa.abn
2+
mesa.hyd
3+
done_with_edep.mod
4+
finished_infall.mod
5+
ready_for_edep.mod
6+
shock_part1.mod
7+
shock_part2.mod
8+
shock_part3.mod
9+
shock_part4.mod
10+
shock_part5.mod

‎star/test_suite/ccsn_IIp/inlist_common‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ use_Skye = .false.
9898
x_ctrl(22) = 1.5 ! alpha_other
9999
x_ctrl(23) = 0.5 ! H_limit
100100
! use alpha_H if cell X >= H_limit; else use alpha_other
101-
x_ctrl(24) = 9d0 ! mass limit (Msun)
102-
! use other_alpfa_mlt only if star_mass >= this limit.
103101

104102
min_overshoot_q = 0d0
105103

‎star/test_suite/ccsn_IIp/inlist_edep‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
profile_interval = 50
118118
history_interval = 10
119119
terminal_interval = 10
120+
x_integer_ctrl(1) = -3 ! part number
120121

121122
/ ! end of controls namelist
122123

‎star/test_suite/ccsn_IIp/inlist_end_infall‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@
143143
write_header_frequency = 10
144144

145145
report_solver_progress = .false.
146+
x_integer_ctrl(1) = -2 ! part number
146147

147148
/ ! end of controls namelist
148149

‎star/test_suite/ccsn_IIp/inlist_infall‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@
118118
trace_history_value_name(2) = 'log_rel_run_E_err'
119119
trace_history_value_name(3) = 'r_center'
120120

121+
x_integer_ctrl(1) = -1 ! part number
122+
121123
/ ! end of controls namelist
122124

123125
&pgstar

‎star/test_suite/ccsn_IIp/inlist_shock_part2‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@
2626

2727
x_integer_ctrl(1) = 2 ! part number
2828
x_ctrl(7) = 0.5 ! setting stop_m in part2, fraction of He layer
29-
30-
!x_ctrl(11) = 0 ! mass Co56
31-
!x_ctrl(12) = 0.05d0 ! mass Ni56 - exact amount set later. this just traces mixing.
32-
!x_ctrl(35) = 0 ! relative to M_center
33-
!x_ctrl(36) = -1.5 ! relative to He_core_mass
34-
! set uniform Ni abundance between these mass bounds
35-
29+
3630
! RTI
3731

3832
! equation controls

‎star/test_suite/ccsn_IIp/inlist_shock_part4‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
&pgstar
118118

119119
!pause = .true.
120+
Grid2_win_flag = .true.
120121

121122
Profile_Panels1_xmin = -101 ! 1.9
122123
Profile_Panels2_xmin = -101 ! 1.9

‎star/test_suite/ccsn_IIp/inlist_shock_part5‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@
5151
delta_lgL_limit = 0.01
5252

5353
x_ctrl(16) = 0.05 ! stop when shock reaches this mass below surface
54-
x_ctrl(45) = 0
55-
x_ctrl(46) = 90
56-
x_ctrl(47) = 0.8
57-
x_ctrl(12) = 1d-15
58-
x_ctrl(35) = -1d+99
59-
x_ctrl(36) = -1d+99
60-
x_integer_ctrl(1) = 5
61-
x_integer_ctrl(3) = 3
54+
x_ctrl(45) = 0 ! boxcar start smooth at this + m_center
55+
x_ctrl(46) = 90 ! boxcar smooth this + he_core_mass
56+
x_ctrl(47) = 0.8 ! width of boxcar smooth
57+
x_ctrl(12) = 1d-15 ! amount of ni56 to add
58+
x_ctrl(35) = -1d+99 ! put ni56 this + m_center
59+
x_ctrl(36) = -1d+99 ! end ni56 at this + he_core_mass
60+
x_integer_ctrl(1) = 5 ! inlist part number
61+
x_integer_ctrl(3) = 3 ! first pass of boxcar smooth num iters
6262

6363
photo_interval = 25
6464

‎star/test_suite/ccsn_IIp/rn‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,4 @@ do_one inlist_shock_part5_header shock_part5.mod LOGS_part5
3232

3333
date "+DATE: %Y-%m-%d%nTIME: %H:%M:%S"
3434

35-
if [ -r LOGS_for_ccsn_run ]
36-
then
37-
rm -rf LOGS_for_ccsn_run_old
38-
mv LOGS_for_ccsn_run LOGS_for_ccsn_run_old
39-
fi
40-
mkdir LOGS_for_ccsn_run
41-
mv LOGS_part* LOGS_for_ccsn_run
42-
rm -rf inlists
43-
mkdir inlists
44-
cp inlist_* inlists
45-
mv inlists LOGS_for_ccsn_run
46-
cp shock_part*.mod LOGS_for_ccsn_run
47-
echo 'created LOGS_for_ccsn_run'
48-
echo
4935

0 commit comments

Comments
 (0)