Skip to content

Commit 80d1e85

Browse files
rjfarmerrjfarmer
committed
Switch all write(*,*) to write(*,'(A)')
Unformatted writes can cause issues with ifort Adds new linter check_empty_writes.py to check and change all occurances
1 parent 2658457 commit 80d1e85

File tree

154 files changed

+1147
-1091
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

154 files changed

+1147
-1091
lines changed

‎astero/private/adipls_support.f90‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ subroutine setup_adipls
449449
call mesa_error(__FILE__,__LINE__,'run_adipls')
450450
end if
451451

452-
write(*,*)
452+
write(*,'(A)')
453453
write(*,'(a)') 'call adipls to read ' // trim(filename)
454454
call setups_adi
455455
nn_arg_0 = 0
@@ -467,7 +467,7 @@ subroutine setup_adipls
467467
end if
468468

469469
write(*,*) 'back from 1st call on adipls'
470-
write(*,*)
470+
write(*,'(A)')
471471

472472
end subroutine setup_adipls
473473

@@ -513,7 +513,7 @@ subroutine setup_redist
513513

514514
rewind(iounit)
515515

516-
write(*,*)
516+
write(*,'(A)')
517517
write(*,'(a)') 'call srdist to read ' // trim(filename)
518518

519519
istdin = iounit
@@ -537,7 +537,7 @@ subroutine setup_redist
537537
end if
538538

539539
write(*,*) 'back from 1st call on srdist'
540-
write(*,*)
540+
write(*,'(A)')
541541

542542
end subroutine setup_redist
543543

@@ -1078,7 +1078,7 @@ subroutine show_adipls_results
10781078
do k = 1, num_results
10791079
write(*,4) 'ADIPLS', k, el(k), order(k), cyclic_freq(k), inertia(k)
10801080
end do
1081-
write(*,*)
1081+
write(*,'(A)')
10821082
end subroutine show_adipls_results
10831083

10841084

‎astero/private/astero_run_support.f90‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ subroutine do_get_parameters_from_file(s, ierr)
417417
next_my_param3_to_try = filedata(file_column_for_my_param3)
418418
write(*,1) 'next_my_param3_to_try', next_my_param3_to_try
419419
end if
420-
write(*,*)
420+
write(*,'(A)')
421421

422422
call do1_grid(ierr)
423423
if (ierr /= 0) then
@@ -501,7 +501,7 @@ subroutine do_scan_grid(s, ierr)
501501
write(*,2) 'num_my_param1', num_my_param1
502502
write(*,2) 'num_my_param2', num_my_param2
503503
write(*,2) 'num_my_param3', num_my_param3
504-
write(*,*)
504+
write(*,'(A)')
505505

506506
sample_number = 0
507507
just_counting = .false.
@@ -737,7 +737,7 @@ subroutine bobyqa_fun(n,x,f)
737737

738738
call bobyqa_or_newuoa_fun(n,x,f)
739739

740-
write(*,*)
740+
write(*,'(A)')
741741
ierr = 0
742742
call save_sample_results_to_file(-1,bobyqa_output_filename,ierr)
743743
if (ierr /= 0) then
@@ -757,7 +757,7 @@ subroutine newuoa_fun(n,x,f)
757757

758758
call bobyqa_or_newuoa_fun(n,x,f)
759759

760-
write(*,*)
760+
write(*,'(A)')
761761
ierr = 0
762762
call save_sample_results_to_file(-1,newuoa_output_filename,ierr)
763763
if (ierr /= 0) then
@@ -842,7 +842,7 @@ subroutine bobyqa_or_newuoa_fun(n,x,f)
842842

843843
call save_best_for_sample(sample_number, 0)
844844

845-
write(*,*)
845+
write(*,'(A)')
846846
write(*,*) 'current set of sample results'
847847
call show_all_sample_results(6,-1,ierr)
848848
if (ierr /= 0) then
@@ -876,8 +876,8 @@ subroutine do_bobyqa_or_newuoa(newuoa_flag, ierr)
876876
include 'formats'
877877
ierr = 0
878878

879-
write(*,*)
880-
write(*,*)
879+
write(*,'(A)')
880+
write(*,'(A)')
881881

882882
if (vary_Y) then
883883
nvar = nvar+1; i_Y = nvar
@@ -1035,8 +1035,8 @@ real(dp) function simplex_f( &
10351035

10361036
ierr = 0
10371037

1038-
write(*,*)
1039-
write(*,*)
1038+
write(*,'(A)')
1039+
write(*,'(A)')
10401040

10411041
if (vary_Y) then
10421042
next_Y_to_try = simplex_param( &
@@ -1487,7 +1487,7 @@ subroutine setup_simplex_and_f(ierr)
14871487
simplex_inverse(sample_my_param3(i), first_my_param3, min_my_param3, max_my_param3)
14881488
write(*,3) 'my_param3', j, i, sample_my_param3(i)
14891489
end if
1490-
write(*,*)
1490+
write(*,'(A)')
14911491
end do
14921492

14931493
deallocate(index)
@@ -1514,8 +1514,8 @@ subroutine setup_simplex_and_f(ierr)
15141514
write(*,'(i6)') i
15151515
end if
15161516
end do
1517-
write(*,*)
1518-
write(*,*)
1517+
write(*,'(A)')
1518+
write(*,'(A)')
15191519
num_samples = max_i
15201520

15211521
end subroutine setup_simplex_and_f
@@ -1651,7 +1651,7 @@ subroutine set_sample_averages
16511651
avg_model_number_top_samples*avg_model_number_top_samples/n)/(n-1)))
16521652
avg_model_number_top_samples = avg_model_number_top_samples/n
16531653

1654-
write(*,*)
1654+
write(*,'(A)')
16551655
write(*,2) 'n for averages', n
16561656
write(*,1) 'avg_age_top_samples', avg_age_top_samples
16571657
write(*,1) 'avg_age_sigma', avg_age_sigma
@@ -1661,7 +1661,7 @@ subroutine set_sample_averages
16611661
write(*,1) 'model number limit', &
16621662
avg_model_number_top_samples + &
16631663
avg_model_number_sigma_limit*avg_model_number_sigma
1664-
write(*,*)
1664+
write(*,'(A)')
16651665
!call mesa_error(__FILE__,__LINE__,'set_sample_averages')
16661666

16671667
end subroutine set_sample_averages

‎astero/private/astero_support.f90‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,10 @@ subroutine get_one_el_info( &
8484

8585
if (.not. gyre_is_enabled) then
8686
ierr = -1
87-
write(*,*)
87+
write(*,'(A)')
8888
write(*,'(a)') 'gyre is not currently enabled in your configuration of mesa.'
8989
write(*,'(a)') 'check that your utils/makefile_header has USE_GYRE = YES'
90-
write(*,*)
90+
write(*,'(A)')
9191
return
9292
end if
9393

@@ -672,7 +672,7 @@ subroutine init_obs_data(ierr)
672672
write(*,1) 'nmax', nmax
673673
write(*,2) '(norders+1)/2', (norders+1)/2
674674
write(*,2) 'l0_n_obs(1)', l0_n_obs(1)
675-
write(*,*)
675+
write(*,'(A)')
676676
!stop
677677
end if
678678
end if
@@ -696,7 +696,7 @@ subroutine init_obs_data(ierr)
696696
write(*,2) 'cnt', cnt
697697
write(*,1) 'sum_1', sum_1
698698
write(*,1) 'sum_2', sum_2
699-
write(*,*)
699+
write(*,'(A)')
700700
call mesa_error(__FILE__,__LINE__,'init_obs_data')
701701
end if
702702

‎astero/private/extras_support.f90‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ integer function do_astero_extras_check_model(s, id)
353353
i = i+1
354354
write(*,2) 'freq', i, cyclic_freq(j)
355355
end do
356-
write(*,*)
356+
write(*,'(A)')
357357
end if
358358
call check_too_many_bad
359359
return
@@ -381,7 +381,7 @@ integer function do_astero_extras_check_model(s, id)
381381
i = i+1
382382
write(*,2) 'freq', i, cyclic_freq(j)
383383
end do
384-
write(*,*)
384+
write(*,'(A)')
385385
end if
386386
call check_too_many_bad
387387
return
@@ -630,7 +630,7 @@ subroutine check_limits
630630
write(*,*) 'have reached Teff limit'
631631
write(*,1) 'Teff', s% Teff
632632
write(*,1) 'Teff_limit', Teff_limit
633-
write(*,*)
633+
write(*,'(A)')
634634
do_astero_extras_check_model = terminate
635635
return
636636
end if
@@ -647,7 +647,7 @@ subroutine check_limits
647647
write(*,*) 'have reached logg limit'
648648
write(*,1) 'logg', logg
649649
write(*,1) 'logg_limit', logg_limit
650-
write(*,*)
650+
write(*,'(A)')
651651
do_astero_extras_check_model = terminate
652652
return
653653
end if
@@ -664,7 +664,7 @@ subroutine check_limits
664664
write(*,*) 'have reached logL limit'
665665
write(*,1) 'logL', s% log_surface_luminosity
666666
write(*,1) 'logL_limit', logL_limit
667-
write(*,*)
667+
write(*,'(A)')
668668
do_astero_extras_check_model = terminate
669669
return
670670
end if
@@ -682,7 +682,7 @@ subroutine check_limits
682682
write(*,*) 'have reached delta_nu limit'
683683
write(*,1) 'delta_nu_model', delta_nu_model
684684
write(*,1) 'delta_nu_limit', delta_nu_limit
685-
write(*,*)
685+
write(*,'(A)')
686686
do_astero_extras_check_model = terminate
687687
return
688688
end if
@@ -699,7 +699,7 @@ subroutine check_limits
699699
write(*,*) 'have reached logR limit'
700700
write(*,1) 'logR', logR
701701
write(*,1) 'logR_limit', logR_limit
702-
write(*,*)
702+
write(*,'(A)')
703703
do_astero_extras_check_model = terminate
704704
return
705705
end if
@@ -719,7 +719,7 @@ subroutine check_limits
719719
write(*,*) 'have reached surface_Z_div_X limit'
720720
write(*,1) 'surface_Z_div_X', surface_Z_div_X
721721
write(*,1) 'surface_Z_div_X_limit', surface_Z_div_X_limit
722-
write(*,*)
722+
write(*,'(A)')
723723
do_astero_extras_check_model = terminate
724724
return
725725
end if
@@ -739,7 +739,7 @@ subroutine check_limits
739739
write(*,*) 'have reached surface_He limit'
740740
write(*,1) 'surface_He', surface_He
741741
write(*,1) 'surface_He_limit', surface_He_limit
742-
write(*,*)
742+
write(*,'(A)')
743743
do_astero_extras_check_model = terminate
744744
return
745745
end if
@@ -756,7 +756,7 @@ subroutine check_limits
756756
write(*,*) 'have reached Rcz limit'
757757
write(*,1) 'Rcz', Rcz
758758
write(*,1) 'Rcz_limit', Rcz_limit
759-
write(*,*)
759+
write(*,'(A)')
760760
do_astero_extras_check_model = terminate
761761
return
762762
end if
@@ -776,7 +776,7 @@ subroutine check_limits
776776
write(*,*) 'have reached my_var1 limit'
777777
write(*,1) 'my_var1', my_var1
778778
write(*,1) 'my_var1_limit', my_var1_limit
779-
write(*,*)
779+
write(*,'(A)')
780780
do_astero_extras_check_model = terminate
781781
return
782782
end if
@@ -796,7 +796,7 @@ subroutine check_limits
796796
write(*,*) 'have reached my_var2 limit'
797797
write(*,1) 'my_var2', my_var2
798798
write(*,1) 'my_var2_limit', my_var2_limit
799-
write(*,*)
799+
write(*,'(A)')
800800
do_astero_extras_check_model = terminate
801801
return
802802
end if
@@ -816,7 +816,7 @@ subroutine check_limits
816816
write(*,*) 'have reached my_var3 limit'
817817
write(*,1) 'my_var3', my_var3
818818
write(*,1) 'my_var3_limit', my_var3_limit
819-
write(*,*)
819+
write(*,'(A)')
820820
do_astero_extras_check_model = terminate
821821
return
822822
end if

0 commit comments

Comments
 (0)