Remove all occurnaces of stop 1 or stop 'string'

There is now a new linter/check_stop.f90 that will
replace those stop's with a call to mesa_error()

Author: rjfarmer

astero/private/adipls_support.f90

@@ -377,15 +377,15 @@ subroutine run_adipls( &
             iounit_dev_null = alloc_iounit(ierr)
             if (ierr /= 0) then
                write(*,*) 'adipls failed in alloc_iounit for iounit_dev_null'
-               stop 'run_adipls'
+               call mesa_error(__FILE__,__LINE__,'run_adipls')
             end if
          end if
 
          filename = 'adipls.stdout'
          open(unit=iounit_dev_null, file=trim(filename), iostat=ierr)
          if (ierr /= 0) then
             write(*,*) 'adipls failed to open ' // trim(filename)
-            stop 'run_adipls'
+            call mesa_error(__FILE__,__LINE__,'run_adipls')
          end if            
          istdou = iounit_dev_null
          istdpr = iounit_dev_null
@@ -418,7 +418,7 @@ subroutine run_adipls( &
          if (ierr_param < 0) then
             ierr = ierr_param
             write(*,*) 'call to adipls failed'
-            stop 'run_adipls'
+            call mesa_error(__FILE__,__LINE__,'run_adipls')
          end if
 
 
@@ -429,7 +429,7 @@ subroutine setup_adipls
             iounit = alloc_iounit(ierr)
             if (ierr /= 0) then
                write(*,*) 'setup_adipls failed in alloc_iounit'
-               stop 'run_adipls'
+               call mesa_error(__FILE__,__LINE__,'run_adipls')
             end if
             filename = 'adipls.c.pruned.in'
             open(unit=iounit, file=trim(filename), action='read', status='old', iostat=ierr)
@@ -446,7 +446,7 @@ subroutine setup_adipls
                write(*,*) 
                write(*,*) 
                write(*,*) 
-               stop 'run_adipls'
+               call mesa_error(__FILE__,__LINE__,'run_adipls')
             end if            
 
             write(*,*)
@@ -463,7 +463,7 @@ subroutine setup_adipls
             if (ierr_param < 0) then
                ierr = ierr_param
                write(*,*) '1st call to adipls failed in setup_adipls'
-               stop 'run_adipls'
+               call mesa_error(__FILE__,__LINE__,'run_adipls')
             end if
 
             write(*,*) 'back from 1st call on adipls'
@@ -482,7 +482,7 @@ subroutine setup_redist
             iounit = alloc_iounit(ierr)
             if (ierr /= 0) then
                write(*,*) 'setup_redist failed in alloc_iounit'
-               stop 'run_rdist'
+               call mesa_error(__FILE__,__LINE__,'run_rdist')
             end if
             filename = 'redistrb.c.pruned.in'
             open(unit=iounit, file=trim(filename), action='read', status='old', iostat=ierr)
@@ -500,14 +500,14 @@ subroutine setup_redist
                write(*,*) 
                write(*,*) 
                write(*,*) 
-               stop 'run_adipls'
-               stop 'run_rdist'
+               call mesa_error(__FILE__,__LINE__,'run_adipls')
+               call mesa_error(__FILE__,__LINE__,'run_rdist')
             end if 
 
             read(iounit,*,iostat=ierr) nn_redist
             if (ierr /= 0) then
                write(*,*) 'setup_redist failed to read nn_redist from ' // trim(filename)
-               stop 'run_rdist'
+               call mesa_error(__FILE__,__LINE__,'run_rdist')
             end if 
             write(*,*) 'nn_redist', nn_redist
 
@@ -533,7 +533,7 @@ subroutine setup_redist
             if (ierr_param < 0) then
                ierr = ierr_param
                write(*,*) '1st call to srdist failed'
-               stop 'run_rdist'
+               call mesa_error(__FILE__,__LINE__,'run_rdist')
             end if
 
             write(*,*) 'back from 1st call on srdist'
@@ -645,7 +645,7 @@ subroutine check_arg_data(nn, data, ldaa, aa, x, ierr)
             end do
          end do
 
-         if (ierr /= 0) stop 'check_arg_data'
+         if (ierr /= 0) call mesa_error(__FILE__,__LINE__,'check_arg_data')
 
 
          contains

astero/private/astero_run_support.f90

@@ -60,7 +60,7 @@ end subroutine extras_controls
          ierr = 0
          call do_read_star_job('inlist', ierr) ! this does alloc_star
          ! and saves the id in id_from_read_star_job
-         if (ierr /= 0) stop 1
+         if (ierr /= 0) call mesa_error(__FILE__,__LINE__)
 
          id = id_from_read_star_job
          id_from_read_star_job = 0
@@ -69,7 +69,7 @@ end subroutine extras_controls
          call star_setup(id, 'inlist', ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in star_setup'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
 
          okay_to_restart = .true.
@@ -85,7 +85,7 @@ end subroutine extras_controls
          call read_astero_search_controls(inlist_astero_fname, ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in read_astero_search_controls'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
 
          if (Y_depends_on_Z .and. vary_Y) then
@@ -132,22 +132,22 @@ end subroutine extras_controls
             call write_astero_search_controls(save_controls_filename, ierr)
             if (ierr /= 0) then
                write(*,*) 'failed in write_astero_search_controls'
-               stop 1
+               call mesa_error(__FILE__,__LINE__)
             end if
          end if
 
          call check_search_controls(ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in check_search_controls'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
 
          nu_max_sun = s% nu_max_sun
          delta_nu_sun = s% delta_nu_sun
          call init_obs_data(ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in init_obs_data'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
 
          next_Y_to_try = -1
@@ -742,7 +742,7 @@ subroutine bobyqa_fun(n,x,f)
          call save_sample_results_to_file(-1,bobyqa_output_filename,ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in save_sample_results_to_file'
-            stop 'bobyqa_fun'
+            call mesa_error(__FILE__,__LINE__,'bobyqa_fun')
          end if
 
       end subroutine bobyqa_fun
@@ -762,7 +762,7 @@ subroutine newuoa_fun(n,x,f)
          call save_sample_results_to_file(-1,newuoa_output_filename,ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in save_sample_results_to_file'
-            stop 'newuoa_fun'
+            call mesa_error(__FILE__,__LINE__,'newuoa_fun')
          end if
 
       end subroutine newuoa_fun
@@ -829,7 +829,7 @@ subroutine bobyqa_or_newuoa_fun(n,x,f)
          f = eval1(star_id, ierr)
          if (ierr /= 0) then
             write(*,*) 'got ierr from eval1'
-            stop 'bobyqa_fun'
+            call mesa_error(__FILE__,__LINE__,'bobyqa_fun')
          end if
          if (sample_number == prev_sample_number) then
             if (sample_number <= 0) then ! failed on 1st try
@@ -847,7 +847,7 @@ subroutine bobyqa_or_newuoa_fun(n,x,f)
          call show_all_sample_results(6,-1,ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in show_all_sample_results'
-            stop 'bobyqa_fun'
+            call mesa_error(__FILE__,__LINE__,'bobyqa_fun')
          end if
 
          min_sample_chi2_so_far = minval(sample_chi2(1:sample_number))
@@ -1437,7 +1437,7 @@ subroutine setup_simplex_and_f(ierr)
             ierr = 0
             allocate(index(num_samples), stat=ierr)
             if (ierr /= 0) then
-               stop 'failed in allocate before calling qsort from show_all_sample_results'
+               call mesa_error(__FILE__,__LINE__,'failed in allocate before calling qsort from show_all_sample_results')
             end if
             call qsort(index, num_samples, sample_chi2)
             max_i = 0
@@ -1533,7 +1533,7 @@ subroutine save_best_for_sample(i, op_code)
             call alloc_sample_ptrs(ierr)
             if (ierr /= 0) then
                write(*,*) 'ERROR -- failed to allocate for samples'
-               stop 'save_best_for_sample'
+               call mesa_error(__FILE__,__LINE__,'save_best_for_sample')
                return
             end if
          end if
@@ -1662,7 +1662,7 @@ subroutine set_sample_averages
             avg_model_number_top_samples + &
                avg_model_number_sigma_limit*avg_model_number_sigma
          write(*,*)
-         !stop 'set_sample_averages'
+         !call mesa_error(__FILE__,__LINE__,'set_sample_averages')
 
       end subroutine set_sample_averages
 

astero/private/astero_support.f90

@@ -97,7 +97,7 @@ subroutine get_one_el_info( &
             call do_gyre_get_modes(s, l, store_model, ierr)
             if (ierr /= 0) then
                write(*,*) 'failed in do_gyre_get_modes'
-               stop 'get_one_el_info'
+               call mesa_error(__FILE__,__LINE__,'get_one_el_info')
             end if
 
          else if (code == 'adipls') then 
@@ -130,7 +130,7 @@ subroutine get_one_el_info( &
                  do_redistribute_mesh, ierr)
             if (ierr /= 0) then
                write(*,*) 'failed in run_adipls'
-               stop 'get_one_el_info'
+               call mesa_error(__FILE__,__LINE__,'get_one_el_info')
             end if
 
          else
@@ -144,7 +144,7 @@ subroutine get_one_el_info( &
          ! sort results by increasing frequency
          allocate(index(num_results), stat=ierr)
          if (ierr /= 0) then
-            stop 'failed in allocate before calling qsort'
+            call mesa_error(__FILE__,__LINE__,'failed in allocate before calling qsort')
          end if
          call qsort(index, num_results, cyclic_freq)
 
@@ -177,7 +177,7 @@ subroutine get_one_el_info( &
                model_inertia(3,:), model_inertia_alt_up(3,:), model_inertia_alt_down(3,:), &
                model_order(3,:), model_order_alt_up(3,:), model_order_alt_down(3,:), ierr)
          else
-            stop 'bad value for l in get_one_el_info'
+            call mesa_error(__FILE__,__LINE__,'bad value for l in get_one_el_info')
          end if
          if (ierr /= 0) then
             !write(*,2) 'failed to find frequency for matching for l =', l
@@ -697,7 +697,7 @@ subroutine init_obs_data(ierr)
             write(*,1) 'sum_1', sum_1
             write(*,1) 'sum_2', sum_2
             write(*,*)
-            stop 'init_obs_data'
+            call mesa_error(__FILE__,__LINE__,'init_obs_data')
          end if
 
       end subroutine init_obs_data
@@ -782,12 +782,12 @@ end subroutine get_kjeldsen_nonradial_freq_corr
 
 
       subroutine get_kjeldsen_nonradial_freq_corr_alt_up
-         !stop 'get_kjeldsen_nonradial_freq_corr_alt_up'
+         !call mesa_error(__FILE__,__LINE__,'get_kjeldsen_nonradial_freq_corr_alt_up')
       end subroutine get_kjeldsen_nonradial_freq_corr_alt_up
 
 
       subroutine get_kjeldsen_nonradial_freq_corr_alt_down 
-         !stop 'get_kjeldsen_nonradial_freq_corr_alt_down'
+         !call mesa_error(__FILE__,__LINE__,'get_kjeldsen_nonradial_freq_corr_alt_down')
       end subroutine get_kjeldsen_nonradial_freq_corr_alt_down
 
 
@@ -1644,7 +1644,7 @@ real(dp) function get_chi2(s, max_el, trace_okay, ierr)
             stop
          end if
 
-         !if (is_bad(chi2)) stop 'get_chi2'
+         !if (is_bad(chi2)) call mesa_error(__FILE__,__LINE__,'get_chi2')
 
       end function get_chi2
 

astero/private/extras_support.f90

@@ -146,7 +146,7 @@ integer function do_astero_extras_check_model(s, id)
                      dt_for_smaller_steps_before_age_target
                   write(*,1) 'max_years_for_timestep', &
                      s% max_years_for_timestep
-                  stop 'bad max_years_for_timestep'
+                  call mesa_error(__FILE__,__LINE__,'bad max_years_for_timestep')
                end if
             end if
          else
@@ -1376,7 +1376,7 @@ subroutine astero_data_for_extra_history_columns(id, n, astero_names, vals, ierr
          if (i /= (num_extra_history_columns + num_extra)) then
             write(*,2) 'i', i
             write(*,2) 'num_extra_history_columns', num_extra_history_columns
-            stop 'bad num_extra_history_columns'
+            call mesa_error(__FILE__,__LINE__,'bad num_extra_history_columns')
          end if
 
          i = num_extra+1

astero/public/astero_def.f90

@@ -1325,7 +1325,7 @@ subroutine save_sample_results_to_file(i_total, results_fname, ierr)
          integer :: iounit
          write(*,*) 'save_sample_results_to_file ' // trim(results_fname)
          iounit = alloc_iounit(ierr)
-         if (ierr /= 0) stop 'alloc_iounit failed'
+         if (ierr /= 0) call mesa_error(__FILE__,__LINE__,'alloc_iounit failed')
          open(unit=iounit, file=trim(results_fname), action='write', iostat=ierr)
          if (ierr /= 0) return
          call show_all_sample_results(iounit, i_total, ierr)
@@ -1916,7 +1916,7 @@ subroutine read_samples_from_file(results_fname, ierr)
          write(*,*) 'read samples from file ' // trim(results_fname)
 
          iounit = alloc_iounit(ierr)
-         if (ierr /= 0) stop 'alloc_iounit failed'
+         if (ierr /= 0) call mesa_error(__FILE__,__LINE__,'alloc_iounit failed')
          open(unit=iounit, file=trim(results_fname), action='read', status='old', iostat=ierr)
          if (ierr /= 0) then
             write(*,*) 'failed to open ' // trim(results_fname)

astero/test_suite/astero_adipls/src/run_star_extras.f90

@@ -149,7 +149,7 @@ subroutine extras_after_evolve(id, ierr)
             call get_adipls_frequency_info( &
                s, store_for_adipls, l_to_match, order_to_match, expected_freq, &
                save_mode_info, order_to_save, save_mode_filename, freq, okay, ierr)
-            if (ierr /= 0) stop 1
+            if (ierr /= 0) call mesa_error(__FILE__,__LINE__)
             if (okay) then
                write(*,'(a,2f20.2)') 'got ok match for expected frequency', freq, expected_freq
             else
@@ -270,7 +270,7 @@ subroutine get_adipls_frequency_info( &
          !write(*,*) 'done adipls_get_one_el_info'
          if (ierr /= 0) then
             write(*,*) 'failed in adipls_get_one_el_info'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
          write(*,*)
          write(*,'(2a8,99a20)') 'el', 'order', 'freq (microHz)', 'inertia'

astero/test_suite/astero_gyre/src/run_star_extras.f90

@@ -131,7 +131,7 @@ subroutine extras_after_evolve(id, ierr)
             if (astero_gyre_is_enabled) then
                call get_gyre_frequency_info(s, .true., okay, ierr)
 
-               if (ierr /= 0) stop 1
+               if (ierr /= 0) call mesa_error(__FILE__,__LINE__)
                if (okay) then
                   write(*,'(a,2f20.2)') 'got ok match for expected frequency', actual_freq, expected_freq
                else
@@ -214,7 +214,7 @@ subroutine get_gyre_frequency_info(s, check_match, okay, ierr)
             s% id, l_to_match, store_model, ierr)
          if (ierr /= 0) then
             write(*,*) 'failed in do_gyre_get_modes'
-            stop 1
+            call mesa_error(__FILE__,__LINE__)
          end if
 
          write(*,*)

atm/private/atm_t_tau_uniform.f90

@@ -664,7 +664,7 @@ subroutine eval_data( &
        write(*,1) 'P0', P0
        write(*,1) 'Pextra', Pextra
        write(*,1) 'P', P
-       !stop 'atm_t_tau_uniform'
+       !call mesa_error(__FILE__,__LINE__,'atm_t_tau_uniform')
        return
     end if
 

atm/private/atm_t_tau_varying.f90

@@ -503,7 +503,7 @@ end function interp_y
 
       ! Dummy routine that's never called
 
-      stop 'Bogus call to eval_solout'
+      call mesa_error(__FILE__,__LINE__,'Bogus call to eval_solout')
 
     end subroutine eval_solout
 

atm/private/atm_table.f90

@@ -201,7 +201,7 @@ subroutine eval_table( &
        write(*,*)
        ierr = -1
        return
-       !if (is_bad(lnP) .or. is_bad(lnT)) stop 'eval_table'
+       !if (is_bad(lnP) .or. is_bad(lnT)) call mesa_error(__FILE__,__LINE__,'eval_table')
     end if
 
     ! Finish