You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed remaining issues identified by Copilot:
1. **Directory check issue** (Critical)
- mfc.sh expects to be run from MFC's root (checks toolchain/util.sh)
- Updated wrapper to 'cd' to installation prefix before exec
- Added comment explaining why directory change is needed
- This ensures mfc.sh finds toolchain/util.sh at runtime
2. **Hardcoded version in documentation** (Documentation)
- Removed hardcoded '5.1.0' references from HOMEBREW.md
- Changed to generic language: 'When a new MFC version is released'
- Updated technical details to show example pattern: vVERSION
- Prevents documentation from becoming outdated with each release
Issues 1 & 2 (duplicate code and path reference) were already fixed
in previous commits (now using libexec.install without duplication).
The wrapper now works correctly:
cd #{prefix} && exec #{libexec}/mfc.sh
This allows mfc.sh to find its expected directory structure.
0 commit comments