Need to generate new golden files for the locations of the airfoil arrays to pass test. I also found a major bug that may invalidate the previous method of computing airfoils that were rotated. We should consider regenerating golden files for this.

Author: danieljvickers

examples/2D_ibm_airfoil/case.py

@@ -94,12 +94,12 @@
             "patch_ib(1)%t": 0.15,
             "patch_ib(1)%p": 0.4,
             "patch_ib(1)%m": 0.02,
-            "patch_ib(1)%theta": 30,
+            "patch_ib(1)%angles(3)": -0.5235987756, # 30 degrees clockwise rotation, in radians
             # Fluids Physical Parameters
             # Use the same stiffness as the air bubble
-            "fluid_pp(1)%gamma": 1.0e00 / (gam_a - 1.0e00),  # 2.50(Not 1.40)
+            "fluid_pp(1)%gamma": 1.0e00 / (gam_a - 1.0e00),  # 2.50 (Not 1.40)
             "fluid_pp(1)%pi_inf": 0,
-            "fluid_pp(2)%gamma": 1.0e00 / (gam_b - 1.0e00),  # 2.50(Not 1.40)
+            "fluid_pp(2)%gamma": 1.0e00 / (gam_b - 1.0e00),  # 2.50 (Not 1.40)
             "fluid_pp(2)%pi_inf": 0,
         }
     )

src/common/m_ib_patches.fpp

@@ -206,8 +206,11 @@ contains
 #endif
         Np = Np1 + Np2 + 1
 
-        allocate (airfoil_grid_u(1:Np)) 
-        allocate (airfoil_grid_l(1:Np))
+        if (.not. allocated(airfoil_grid_u)) then
+          allocate (airfoil_grid_u(1:Np)) 
+          allocate (airfoil_grid_l(1:Np))
+        end if
+        
 
         ! TODO :: The below instantiations are already handles by the loop below
         airfoil_grid_u(1)%x = 0._wp

src/pre_process/m_data_output.fpp

@@ -550,8 +550,6 @@ contains
                         write (2, FMT) airfoil_grid_l(j)%x, airfoil_grid_l(j)%y
                     end do
                     close (2)
-
-                    print *, "Np", Np
                 end if
             end do
         end if

src/simulation/m_ibm.fpp

@@ -396,7 +396,6 @@ contains
         integer :: index
 
         do q = 1, num_gps
-          print *, q, num_gps
             gp = ghost_points_in(q)
             i = gp%loc(1)
             j = gp%loc(2)