Skip to content

Commit 2959fcb

Browse files
authored
Merge branch 'MFlowCode:master' into refactoring
2 parents 4376ff7 + a39962c commit 2959fcb

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+450
-300
lines changed

.github/workflows/doc.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,18 @@ jobs:
3030
git ls-remote "${{ secrets.DOC_PUSH_URL }}" -q
3131
code=$?
3232
if [ "$code" -ne "0" ]; then exit 0; fi
33-
git config --global user.name "MFC Action"
34-
git config --global user.email "MFC Action"
33+
git config --global user.name 'MFC Action'
34+
git config --global user.email '<>'
3535
git clone "${{ secrets.DOC_PUSH_URL }}"
3636
cd "$(find . -name '*.github.io')"
3737
mv .github ..
3838
rm -rf $(pwd)/*
3939
mv ../.github .
4040
mv ../install/doc/mfc/* .
4141
git add -A
42-
git commit -m "${GITHUB_SHA::7}: $(date +%d/%m/%Y-%H:%M:%S)" || true
42+
git commit -m "Docs @ ${GITHUB_SHA::7}" || true
4343
git push
4444
4545
# DOC_PUSH_URL should be of the format:
46-
# - "https://${{ github.repository_owner }}:${{ TOKEN }}@github.com/${{ github.repository_owner }}/${{ github.repository_owner }}.github.io"
46+
# --> https://<username>:<token>@github.com/<username>/<repository>
47+

CMakeLists.txt

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,13 @@ if (MFC_BUILD_SIMULATION)
216216

217217

218218
if (MFC_WITH_OPEN_ACC)
219-
find_package(OpenACC REQUIRED)
219+
find_package(OpenACC)
220+
221+
# This should be equivalent to if (NOT OpenACC_FC_FOUND)
222+
if (NOT TARGET OpenACC::OpenACC_Fortran)
223+
message(FATAL_ERROR "OpenACC + Fortran is unsupported.")
224+
endif()
225+
220226
target_link_libraries(simulation PRIVATE OpenACC::OpenACC_Fortran)
221227

222228

@@ -315,26 +321,23 @@ macro(GEN_DOCS target name)
315321
set(DOXYGEN_PROJECT_NAME "${name}")
316322
set(DOXYGEN_INPUT "${CMAKE_CURRENT_SOURCE_DIR}/src/${target}/ ${CMAKE_CURRENT_BINARY_DIR}/doxygen/${target}/")
317323

318-
file(
319-
COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/${target}"
320-
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen"
321-
)
324+
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/${target}"
325+
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen")
326+
327+
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/doxygen"
328+
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen/${target}")
322329

323330
configure_file(
324331
"${CMAKE_CURRENT_SOURCE_DIR}/doc/Doxyfile.in"
325332
"${CMAKE_CURRENT_BINARY_DIR}/doxygen/${target}/Doxyfile"
326333
@ONLY
327334
)
328335

329-
file(
330-
COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/res"
331-
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen"
332-
)
336+
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/res"
337+
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen")
333338

334-
file(
335-
COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/config.js"
336-
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen"
337-
)
339+
file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/doc/config.js"
340+
DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/doxygen")
338341

339342
add_custom_command(
340343
OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/doxygen/${target}/html/index.html"
@@ -382,7 +385,7 @@ if (MFC_BUILD_DOC)
382385
ExternalProject_Add(doxygen-awesome-css
383386
PREFIX doxygen-awesome-css
384387
GIT_REPOSITORY "https://github.com/jothepro/doxygen-awesome-css"
385-
GIT_TAG "a5efba07a3d4fd6317d95657b3095b97e134b791"
388+
GIT_TAG "8a34f701d3435309a21080f44fbd4a466979aa19"
386389
CONFIGURE_COMMAND ""
387390
BUILD_COMMAND ""
388391
INSTALL_COMMAND ""
@@ -398,6 +401,6 @@ if (MFC_BUILD_DOC)
398401
GEN_DOCS(post_process "MFC: Post-Process")
399402

400403
# === === Generate Landing Page
401-
GEN_DOCS(landing "MFC")
404+
GEN_DOCS(documentation "MFC")
402405

403406
endif()

README.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
![MFC Banner](doc/res/banner.png)
1+
<p align="center">
2+
<img src="doc/res/banner.png" alt="MFC Banner" width="500"/></center>
3+
</p>
24

35
<p align="center">
46
<a href="http://dx.doi.org/10.1016/j.cpc.2020.107396">
@@ -24,19 +26,25 @@
2426
</a>
2527
</p>
2628

27-
Welcome to MFC! The MFC is a fully-documented parallel simulation software for multi-component, multi-phase, and bubbly flows.
29+
Welcome to the home of MFC!
30+
MFC simulates compressible multi-component and multi-phase flows, amongst other things.
31+
It scales ideally to tens of thousands of GPUs.
32+
MFC is written in Fortran and makes use of metaprogramming to keep the codebase readable and compact.
33+
Please contact the developers, like [Spencer](mailto:[email protected]), if you have any questions.
34+
We have an active Slack channel to help ease in new MFC users and support development.
2835

29-
Documentation is available on [our website](https://mflowcode.github.io/) and in markdown format at [doc/landing/readme.md](doc/landing/readme.md).
36+
MFC has both API and high-level documentation.
37+
It is available on [the website](https://mflowcode.github.io/) and in markdown format at [doc/documentation/readme.md](doc/documentation/readme.md).
3038

31-
The paper that describes the MFC's capabilities:
39+
If you use MFC, consider citing it:
3240
* <a href="https://doi.org/10.1016/j.cpc.2020.107396">
3341
S. H. Bryngelson, K. Schmidmayer, V. Coralic, K. Maeda, J. Meng, T. Colonius (2021) Computer Physics Communications 4655, 107396
3442
</a>
3543

3644
```
3745
@article{Bryngelson_2021,
3846
title = {MFC: An open-source high-order multi-component, multi-phase, and multi-scale compressible flow solver},
39-
author = {Spencer H. Bryngelson and Kevin Schmidmayer and Vedran Coralic and Jomela C. Meng and Kazuki Maeda and Tim Colonius},
47+
author = {Spencer H. Bryngelson and Kevin Schmidmayer and Vedran Coralic and Jomela C. Meng and Kazuki Maeda and Tim Colonius},
4048
journal = {Computer Physics Communications},
4149
doi = {10.1016/j.cpc.2020.107396},
4250
year = 2021,
@@ -53,5 +61,5 @@ MFC is under the MIT license (see [LICENSE](LICENSE) file for full text).
5361

5462
<p align="justify">
5563
MFC development was supported by multiple current and past grants from the US Office of Naval Research (ONR), the US National Institute of Health (NIH), and the US National Science Foundation (NSF).
56-
MFC computations utilize the Extreme Science and Engineering Discovery Environment (XSEDE), under allocations TG-CTS120005 (PI Colonius) and TG-PHY210084 (PI Bryngelson) and OLCF Summit under allocation CFD154 (PI Bryngelson).
64+
MFC computations utilize the Extreme Science and Engineering Discovery Environment (XSEDE, now ACCESS), under allocations TG-CTS120005 (PI Colonius) and TG-PHY210084 (PI Bryngelson) and OLCF Summit under allocation CFD154 (PI Bryngelson).
5765
</p>

doc/Doxyfile.in

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ PROJECT_NAME = "@DOXYGEN_PROJECT_NAME@"
3838
# could be handy for archiving the generated documentation or if some version
3939
# control system is used.
4040

41-
PROJECT_NUMBER = 4.0.0
41+
PROJECT_NUMBER =
4242

4343
# Using the PROJECT_BRIEF tag one can provide an optional one line description
4444
# for a project that appears at the top of each page and should give viewer a
@@ -1166,7 +1166,7 @@ HTML_FILE_EXTENSION = .html
11661166
# of the possible markers and block names see the documentation.
11671167
# This tag requires that the tag GENERATE_HTML is set to YES.
11681168

1169-
HTML_HEADER =
1169+
HTML_HEADER = doxygen/header.html
11701170

11711171
# The HTML_FOOTER tag can be used to specify a user-defined HTML footer for each
11721172
# generated HTML page. If the tag is left blank doxygen will generate a standard
@@ -1176,7 +1176,7 @@ HTML_HEADER =
11761176
# that doxygen normally uses.
11771177
# This tag requires that the tag GENERATE_HTML is set to YES.
11781178

1179-
HTML_FOOTER =
1179+
HTML_FOOTER = doxygen/footer.html
11801180

11811181
# The HTML_STYLESHEET tag can be used to specify a user-defined cascading style
11821182
# sheet that is used by each HTML page. It can be used to fine-tune the look of
@@ -1211,7 +1211,7 @@ HTML_EXTRA_STYLESHEET = @DOXYGEN_HTML_EXTRA_STYLESHEET@
12111211
# files will be copied as-is; there are no commands or markers available.
12121212
# This tag requires that the tag GENERATE_HTML is set to YES.
12131213

1214-
HTML_EXTRA_FILES =
1214+
HTML_EXTRA_FILES =
12151215

12161216
# The HTML_COLORSTYLE_HUE tag controls the color of the HTML output. Doxygen
12171217
# will adjust the colors in the style sheet and background images according to
File renamed without changes.
File renamed without changes.
File renamed without changes.

doc/landing/readme.md renamed to doc/documentation/readme.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ Ph.D. Disserations:
8181
V. Coralic (2014) Ph.D. thesis, California Institute of Technology
8282
</a>
8383

84-
### User Configuration (`defaults.yaml`)
84+
### User Configuration
8585

86-
The `mfc.sh` script used in the previous section is configured through the file named `defaults.yaml`.
86+
The [mfc.sh](https://github.com/MFlowCode/MFC/blob/master/mfc.sh) script used in the previous section is configured through the [defaults.yaml](https://github.com/MFlowCode/MFC/blob/master/defaults.yaml) file.
8787

8888
## Development
8989

@@ -112,7 +112,7 @@ You can append `-DMFC_MEMORY_DUMP` to `release-gpu`'s Fortran compiler options i
112112
## License
113113

114114
Copyright 2022.
115-
MFC is under the MIT license (see [LICENSE](LICENSE) file for full text).
115+
MFC is under the MIT license (see [LICENSE](https://github.com/MFlowCode/MFC/blob/master/LICENSE) file for full text).
116116

117117
## Acknowledgements
118118

File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)