final commit, remove last remaining warnings

Author: Archith Iyer

src/common/m_helper.fpp

@@ -230,7 +230,7 @@ contains
         real(wp), intent(out) :: Re_trans, Im_trans
 
         complex :: trans, c1, c2, c3
-        complex :: imag = (0., 1.)
+        complex :: imag = (0._wp, 1._wp)
         real(wp) :: f_transcoeff
 
         c1 = imag*omega*peclet

src/common/m_phase_change.fpp

@@ -38,7 +38,7 @@ module m_phase_change
     !> @{
     integer, parameter :: max_iter = 1e8_wp        !< max # of iterations
     real(wp), parameter :: pCr = 4.94e7_wp   !< Critical water pressure
-    real(wp), parameter :: TCr = 385.05 + 273.15  !< Critical water temperature
+    real(wp), parameter :: TCr = 385.05_wp + 273.15_wp  !< Critical water temperature
     real(wp), parameter :: mixM = 1.0e-8_wp !< threshold for 'mixture cell'. If Y < mixM, phase change does not happen
     integer, parameter :: lp = 1    !< index for the liquid phase of the reacting fluid
     integer, parameter :: vp = 2    !< index for the vapor phase of the reacting fluid

src/common/m_variables_conversion.fpp

@@ -760,7 +760,7 @@ contains
                     !$acc loop seq
                     do i = 1, nb
                         mu = qK_cons_vf(bubxb + 1 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc
-                        sig = (qK_cons_vf(bubxb + 3 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc - mu**2)**0.5
+                        sig = (qK_cons_vf(bubxb + 3 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc - mu**2)**0.5_wp
 
                         mv(j, k, l, 1, i) = (mass_v0(i))*(mu - sig)**(3._wp)/(R0(i)**(3._wp))
                         mv(j, k, l, 2, i) = (mass_v0(i))*(mu - sig)**(3._wp)/(R0(i)**(3._wp))
@@ -793,7 +793,7 @@ contains
                     !$acc loop seq
                     do i = 1, nb
                         mu = qK_cons_vf(bubxb + 1 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc
-                        sig = (qK_cons_vf(bubxb + 3 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc - mu**2)**0.5
+                        sig = (qK_cons_vf(bubxb + 3 + (i - 1)*nmom)%sf(j, k, l)/nbub_sc - mu**2)**0.5_wp
 
                         !PRESTON (ISOTHERMAL)
                         pb(j, k, l, 1, i) = (pb0(i))*(R0(i)**(3._wp))*(mass_n0(i) + mv(j, k, l, 1, i))/(mu - sig)**(3._wp)/(mass_n0(i) + mass_v0(i))
@@ -1137,7 +1137,7 @@ contains
                                                            (gamma*q_prim_vf(E_idx)%sf(j, k, l) + pi_inf)
                         else
                             !Tait EOS, no conserved energy variable
-                            q_cons_vf(E_idx)%sf(j, k, l) = 0.
+                            q_cons_vf(E_idx)%sf(j, k, l) = 0._wp
                         end if
                     end if
 

src/post_process/m_data_output.fpp

@@ -695,7 +695,7 @@ contains
             else
 
                 if (precision == 1) then
-                    write (dbfile) real(x_cb, kind(0.0))
+                    write (dbfile) real(x_cb, wp)
                 else
                     write (dbfile) x_cb
                 end if
@@ -708,7 +708,7 @@ contains
 
                 if (proc_rank == 0) then
                     if (precision == 1) then
-                        write (dbroot) real(x_root_cb, kind(0.0))
+                        write (dbroot) real(x_root_cb, wp)
                     else
                         write (dbroot) x_root_cb
                     end if
@@ -953,7 +953,7 @@ contains
             ! Writing the name of the flow variable and its data, associated
             ! with the local processor, to the formatted database slave file
             if (precision == 1) then
-                write (dbfile) varname, real(q_sf, kind(0.0))
+                write (dbfile) varname, real(q_sf, wp)
             else
                 write (dbfile) varname, q_sf
             end if
@@ -971,7 +971,7 @@ contains
 
                 if (proc_rank == 0) then
                     if (precision == 1) then
-                        write (dbroot) varname, real(q_root_sf, kind(0.0))
+                        write (dbroot) varname, real(q_root_sf, wp)
                     else
                         write (dbroot) varname, q_root_sf
                     end if

src/post_process/m_derived_variables.fpp

@@ -546,11 +546,11 @@ contains
                     end do
 
                     ! Compute Q
-                    Q = 0.5*((O2(1, 1) + O2(2, 2) + O2(3, 3)) - &
-                             (S2(1, 1) + S2(2, 2) + S2(3, 3)))
+                    Q = 0.5_wp*((O2(1, 1) + O2(2, 2) + O2(3, 3)) - &
+                                (S2(1, 1) + S2(2, 2) + S2(3, 3)))
                     trS = S(1, 1) + S(2, 2) + S(3, 3)
-                    IIS = 0.5*((S(1, 1) + S(2, 2) + S(3, 3))**2 - &
-                               (S2(1, 1) + S2(2, 2) + S2(3, 3)))
+                    IIS = 0.5_wp*((S(1, 1) + S(2, 2) + S(3, 3))**2 - &
+                                  (S2(1, 1) + S2(2, 2) + S2(3, 3)))
                     q_sf(j, k, l) = Q + IIS
 
                 end do

src/post_process/m_global_parameters.fpp

@@ -59,7 +59,7 @@ module m_global_parameters
     !> @name Cell-boundary locations in the x-, y- and z-coordinate directions
     !> @{
     real(wp), allocatable, dimension(:) :: x_cb, x_root_cb, y_cb, z_cb
-    real(kind(0.0)), allocatable, dimension(:) :: x_cb_s, y_cb_s, z_cb_s
+    real(wp), allocatable, dimension(:) :: x_cb_s, y_cb_s, z_cb_s
     !> @}
 
     !> @name Cell-center locations in the x-, y- and z-coordinate directions

src/pre_process/m_assign_variables.fpp

@@ -225,7 +225,7 @@ contains
         B_tait = B_tait*(n_tait - 1._wp)/n_tait
 
         if (j < 177) then
-            q_prim_vf(E_idx)%sf(j, k, l) = 0.5*q_prim_vf(E_idx)%sf(j, k, l)
+            q_prim_vf(E_idx)%sf(j, k, l) = 0.5_wp*q_prim_vf(E_idx)%sf(j, k, l)
         end if
 
         if (qbmm) then

src/pre_process/m_compute_levelset.fpp

@@ -528,18 +528,18 @@ contains
         length_z = patch_ib(ib_patch_id)%length_z
 
         if (length_x /= 0._wp) then
-            boundary%beg = x_centroid - 0.5*length_x
-            boundary%end = x_centroid + 0.5*length_x
+            boundary%beg = x_centroid - 0.5_wp*length_x
+            boundary%end = x_centroid + 0.5_wp*length_x
             dist_sides_vec = (/1, 0, 0/)
             dist_surface_vec = (/0, 1, 1/)
         else if (length_y /= 0._wp) then
-            boundary%beg = y_centroid - 0.5*length_y
-            boundary%end = y_centroid + 0.5*length_y
+            boundary%beg = y_centroid - 0.5_wp*length_y
+            boundary%end = y_centroid + 0.5_wp*length_y
             dist_sides_vec = (/0, 1, 0/)
             dist_surface_vec = (/1, 0, 1/)
         else if (length_z /= 0._wp) then
-            boundary%beg = z_centroid - 0.5*length_z
-            boundary%end = z_centroid + 0.5*length_z
+            boundary%beg = z_centroid - 0.5_wp*length_z
+            boundary%end = z_centroid + 0.5_wp*length_z
             dist_sides_vec = (/0, 0, 1/)
             dist_surface_vec = (/1, 1, 0/)
         end if

src/pre_process/m_model.fpp

@@ -501,10 +501,10 @@ contains
 
         do i = 1, spc
             call random_number(ray_origins(i, :))
-            ray_origins(i, :) = point + (ray_origins(i, :) - 0.5)*spacing(:)
+            ray_origins(i, :) = point + (ray_origins(i, :) - 0.5_wp)*spacing(:)
 
             call random_number(ray_dirs(i, :))
-            ray_dirs(i, :) = ray_dirs(i, :) - 0.5
+            ray_dirs(i, :) = ray_dirs(i, :) - 0.5_wp
             ray_dirs(i, :) = ray_dirs(i, :)/sqrt(sum(ray_dirs(i, :)*ray_dirs(i, :)))
         end do
 
@@ -549,7 +549,7 @@ contains
 
         NdotRayDirection = sum(N(:)*ray%d(:))
 
-        if (abs(NdotRayDirection) < 0.0000001) then
+        if (abs(NdotRayDirection) < 0.0000001_wp) then
             return
         end if
 

src/pre_process/m_patches.fpp

@@ -342,9 +342,9 @@ contains
                 dycdxc = (2*ma/(1 - pa)**2)*(pa - xa)
             end if
 
-            yt = (5._wp*ta)*(0.2969*xa**0.5_wp - 0.126*xa - 0.3516*xa**2._wp + 0.2843*xa**3 - 0.1015*xa**4)
-            sin_c = dycdxc/(1 + dycdxc**2)**0.5
-            cos_c = 1/(1 + dycdxc**2)**0.5
+            yt = (5._wp*ta)*(0.2969_wp*xa**0.5_wp - 0.126_wp*xa - 0.3516_wp*xa**2._wp + 0.2843_wp*xa**3 - 0.1015_wp*xa**4)
+            sin_c = dycdxc/(1 + dycdxc**2)**0.5_wp
+            cos_c = 1/(1 + dycdxc**2)**0.5_wp
 
             xu = xa - yt*sin_c
             yu = yc + yt*cos_c
@@ -509,9 +509,9 @@ contains
                 dycdxc = (2*ma/(1 - pa)**2)*(pa - xa)
             end if
 
-            yt = (5._wp*ta)*(0.2969*xa**0.5_wp - 0.126*xa - 0.3516*xa**2._wp + 0.2843*xa**3 - 0.1015*xa**4)
-            sin_c = dycdxc/(1 + dycdxc**2)**0.5
-            cos_c = 1/(1 + dycdxc**2)**0.5
+            yt = (5._wp*ta)*(0.2969_wp*xa**0.5_wp - 0.126_wp*xa - 0.3516_wp*xa**2._wp + 0.2843_wp*xa**3 - 0.1015_wp*xa**4)
+            sin_c = dycdxc/(1 + dycdxc**2)**0.5_wp
+            cos_c = 1/(1 + dycdxc**2)**0.5_wp
 
             xu = xa - yt*sin_c
             yu = yc + yt*cos_c
@@ -1288,7 +1288,7 @@ contains
         ! state in the cells that this patch covers.
         eta = 1._wp
         l = 1._wp
-        U0 = 0.1
+        U0 = 0.1_wp
         ! Checking whether the patch covers a particular cell in the
         ! domain and verifying whether the current patch has the
         ! permission to write to that cell. If both queries check out,