You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addressed two suggestions from qodo-merge-pro review:
1. **Add explicit error handling to wrapper** (Importance: 2)
- Changed: cd "#{prefix}" && exec
- To: cd "#{prefix}" || exit 1; exec
- Ensures script fails fast if directory change fails
- Prevents execution in wrong directory if prefix is missing
2. **Use lighter test command** (Importance: 7)
- Changed: mfc run (full simulation)
- To: mfc count (case file parsing only)
- Much faster test execution
- More reliable (doesn't depend on simulation completing)
- Still validates: wrapper, toolchain, case parsing, Python env
- Reduces test time from minutes to seconds
Both changes improve robustness and testing efficiency.
0 commit comments