More pure subroutines and removed some module variables

Author: prathi-wind

src/common/m_helper.fpp

@@ -248,7 +248,10 @@ contains
     end subroutine s_int_to_str
 
     !> Computes the Simpson weights for quadrature
-    subroutine s_simpson
+    subroutine s_simpson(weight, R0)
+
+        real(wp), dimension(:), intent(inout) :: weight
+        real(wp), dimension(:), intent(inout) :: R0
 
         integer :: ir
         real(wp) :: R0mn, R0mx, dphi, tmp, sd

src/post_process/m_start_up.f90

@@ -676,7 +676,7 @@ impure subroutine s_initialize_modules
         ! needed to properly setup the modules
         call s_initialize_global_parameters_module()
         if (bubbles_euler .and. nb > 1) then
-            call s_simpson
+            call s_simpson(weight, R0)
         end if
         if (bubbles_euler .and. .not. polytropic) then
             call s_initialize_nonpoly()

src/pre_process/m_start_up.fpp

@@ -767,7 +767,7 @@ contains
         call s_initialize_global_parameters_module()
         !Quadrature weights and nodes for polydisperse simulations
         if (bubbles_euler .and. nb > 1) then
-            call s_simpson
+            call s_simpson(weight, R0)
         end if
         !Initialize variables for non-polytropic (Preston) model
         if (bubbles_euler .and. .not. polytropic) then

src/simulation/m_ibm.fpp

@@ -89,7 +89,7 @@ contains
 
         !$acc update host(ib_markers%sf)
 
-        call s_find_num_ghost_points()
+        call s_find_num_ghost_points(num_gps, num_inner_gps)
 
         !$acc update device(num_gps, num_inner_gps)
         @:ALLOCATE(ghost_points(1:num_gps))
@@ -342,7 +342,7 @@ contains
         !!  @param ghost_points Ghost Points
         !!  @param levelset Closest distance from each grid cell to IB
         !!  @param levelset_norm Vector pointing in the direction of the closest distance
-    subroutine s_compute_image_points(ghost_points, levelset, levelset_norm)
+    impure subroutine s_compute_image_points(ghost_points, levelset, levelset_norm)
 
         type(ghost_point), dimension(num_gps), intent(INOUT) :: ghost_points
         type(levelset_field), intent(IN) :: levelset
@@ -426,13 +426,18 @@ contains
 
     !> Function that finds the number of ghost points, used for allocating
     !! memory.
-    subroutine s_find_num_ghost_points()
+    pure subroutine s_find_num_ghost_points(num_gps, num_inner_gps)
+
+        integer, intent(out) :: num_gps
+        integer, intent(out) :: num_inner_gps
+
         integer, dimension(2*gp_layers + 1, 2*gp_layers + 1) &
             :: subsection_2D
         integer, dimension(2*gp_layers + 1, 2*gp_layers + 1, 2*gp_layers + 1) &
             :: subsection_3D
         integer :: i, j, k, l, q !< Iterator variables
 
+
         num_gps = 0
         num_inner_gps = 0
 
@@ -470,7 +475,7 @@ contains
     end subroutine s_find_num_ghost_points
 
     !> Function that finds the ghost points
-    subroutine s_find_ghost_points(ghost_points, inner_points)
+    pure subroutine s_find_ghost_points(ghost_points, inner_points)
 
         type(ghost_point), dimension(num_gps), intent(INOUT) :: ghost_points
         type(ghost_point), dimension(num_inner_gps), intent(INOUT) :: inner_points
@@ -585,7 +590,7 @@ contains
     end subroutine s_find_ghost_points
 
     !>  Function that computes the interpolation coefficients of image points
-    subroutine s_compute_interpolation_coeffs(ghost_points)
+    pure subroutine s_compute_interpolation_coeffs(ghost_points)
 
         type(ghost_point), dimension(num_gps), intent(INOUT) :: ghost_points
 

src/simulation/m_start_up.fpp

@@ -1465,7 +1465,7 @@ contains
         call s_initialize_global_parameters_module()
         !Quadrature weights and nodes for polydisperse simulations
         if (bubbles_euler .and. nb > 1 .and. R0_type == 1) then
-            call s_simpson
+            call s_simpson(weight, R0)
         end if
         !Initialize variables for non-polytropic (Preston) model
         if (bubbles_euler .and. .not. polytropic) then

src/simulation/m_surface_tension.fpp

@@ -40,12 +40,13 @@ module m_surface_tension
     type(int_bounds_info) :: is1, is2, is3, iv
     !$acc declare create(is1, is2, is3, iv)
 
-    integer :: j, k, l, i
 
 contains
 
     impure subroutine s_initialize_surface_tension_module
 
+        integer :: j
+
         @:ALLOCATE(c_divs(1:num_dims + 1))
 
         do j = 1, num_dims + 1
@@ -65,7 +66,7 @@ contains
         end if
     end subroutine s_initialize_surface_tension_module
 
-    subroutine s_compute_capilary_source_flux(q_prim_vf, &
+    pure subroutine s_compute_capilary_source_flux(q_prim_vf, &
                                               vSrc_rsx_vf, vSrc_rsy_vf, vSrc_rsz_vf, &
                                               flux_src_vf, &
                                               id, isx, isy, isz)
@@ -83,6 +84,8 @@ contains
         real(wp), dimension(num_dims, num_dims) :: Omega
         real(wp) :: w1L, w1R, w2L, w2R, w3L, w3R, w1, w2, w3
         real(wp) :: normWL, normWR, normW
+        integer :: j, k, l, i
+
 
         if (id == 1) then
             !$acc parallel loop collapse(3) gang vector default(present) private(Omega, &
@@ -231,6 +234,8 @@ contains
         type(integer_field), dimension(1:num_dims, -1:1), intent(in) :: bc_type
 
         type(int_bounds_info) :: isx, isy, isz
+        integer :: j, k, l, i
+
 
         isx%beg = -1; isy%beg = 0; isz%beg = 0
 
@@ -377,6 +382,7 @@ contains
     end subroutine s_reconstruct_cell_boundary_values_capillary
 
     impure subroutine s_finalize_surface_tension_module
+        integer :: j
 
         do j = 1, num_dims
             @:DEALLOCATE(c_divs(j)%sf)