Skip to content

Commit 89bf301

Browse files
committed
Fix Fypp chemistry boolean interpretation
The issue was that CMake was passing -D chemistry=False (string) to Fypp, but Fypp interprets the string "False" as truthy (non-empty string). This caused Fypp to generate code that tried to use m_thermochem even when MFC_CHEMISTRY=OFF, leading to compilation errors. Solution: Pass 0/1 instead of False/True to Fypp, which correctly interprets as boolean false/true. Also explicitly import join_path in package.py for clarity.
1 parent 4363722 commit 89bf301

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

packaging/spack/package.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from spack_repo.builtin.build_systems.cmake import CMakePackage
77

88
from spack.package import *
9+
from spack.util.path import join_path
910

1011

1112
class Mfc(CMakePackage):

0 commit comments

Comments
 (0)