Skip to content

Commit 973b084

Browse files
Archith IyerArchith Iyer
authored andcommitted
Fix revert
1 parent 2b2702e commit 973b084

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

.github/workflows/bench.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ jobs:
2020

2121
self:
2222
name: Georgia Tech | Phoenix (NVHPC)
23-
if: github.repository == 'MFlowCode/MFC' && needs.file-changes.outputs.checkall == 'true'
24-
needs: file-changes
23+
if: github.repository == 'MFlowCode/MFC'
2524
strategy:
2625
matrix:
2726
device: ['cpu', 'gpu']
@@ -34,12 +33,12 @@ jobs:
3433
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
3534
steps:
3635
- name: Clone - PR
37-
uses: actions/checkout@v4
36+
uses: actions/checkout@v3
3837
with:
3938
path: pr
4039

4140
- name: Clone - Master
42-
uses: actions/checkout@v4
41+
uses: actions/checkout@v3
4342
with:
4443
repository: MFlowCode/MFC
4544
ref: master
@@ -57,7 +56,7 @@ jobs:
5756
(cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml)
5857
5958
- name: Archive Logs
60-
uses: actions/upload-artifact@v4
59+
uses: actions/upload-artifact@v3
6160
if: always()
6261
with:
6362
name: logs-${{ matrix.device }}

.github/workflows/phoenix/bench.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
n_ranks=12
3+
n_ranks=4
44

55
if [ "$job_device" == "gpu" ]; then
66
n_ranks=$(nvidia-smi -L | wc -l) # number of GPUs on node
@@ -9,7 +9,7 @@ if [ "$job_device" == "gpu" ]; then
99
fi
1010

1111
if ["$job_device" == "gpu"]; then
12-
./mfc.sh bench --mem 12 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
12+
./mfc.sh bench --mem 8 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
1313
else
1414
./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
1515
fi

.github/workflows/phoenix/submit.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ sbatch <<EOT
4141
#SBATCH --account=gts-sbryngelson3 # charge account
4242
#SBATCH -N1 # Number of nodes required
4343
$sbatch_device_opts
44-
#SBATCH -t 02:00:00 # Duration of the job (Ex: 15 mins)
44+
#SBATCH -t 04:00:00 # Duration of the job (Ex: 15 mins)
4545
#SBATCH -q embers # QOS Name
4646
#SBATCH -o$job_slug.out # Combined output and error messages file
4747
#SBATCH -W # Do not exit until the submitted job terminates.

toolchain/mfc/bench.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def bench(targets = None):
6161
["--targets"] + [t.name for t in targets] +
6262
["--output-summary", summary_filepath] +
6363
case.args +
64-
["--", "--gbpp", ARG('mem')],
64+
["--", ARG('mem')],
6565
stdout=log_file,
6666
stderr=subprocess.STDOUT)
6767

0 commit comments

Comments
 (0)