toml and lint in CI

Author: sbryngelson

.fortitude.toml

@@ -0,0 +1,5 @@
+[check]
+# Ignored Rules and justification:
+ignore = ["E001","S001","S101","M011","F001","S041","T001","S101","S102","T002","T011","T042","M001"]
+file-extensions = ["f90","fpp","fypp"]
+line-length = 5000

.github/workflows/lint-source.yml

@@ -25,11 +25,17 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
-    - name: Install Fortitude
-      run: pip install fortitude-lint ansi2txt
+    - name: Initialize MFC
+      run: ./mfc.sh init
 
-    - name: Lint the source code
-      run:  fortitude check --file-extensions=f90,fpp,fypp --ignore=E001,S001,S101,M011,F001,S041,T001,S101,S102,T002,T011 ./src/** || true
+    # - name: Lint the source code
+    #   run:  fortitude check --file-extensions=f90,fpp,fypp --ignore=E001,S001,S101,M011,F001,S041,T001,S101,S102,T002,T011 ./src/** || true
+
+    - name: Lint the full source
+      run: |
+        alias lintsource='find ./src -type f -not -name '*nvtx*' -exec command fortitude check {} \;' |
+        lintsource |
+        lintsource | wc -l | xargs -I{} sh -c '[ {} -gt 0 ] && exit 1 || exit 0'
 
     - name: Ensure kind is specified
       run:  fortitude check --file-extensions=f90,fpp,fypp --select=P001 ./src/**

src/post_process/m_data_output.fpp

@@ -50,6 +50,7 @@ module m_data_output
     real(wp), allocatable, dimension(:, :, :), public :: q_sf
     real(wp), allocatable, dimension(:, :, :) :: q_root_sf
     real(wp), allocatable, dimension(:, :, :) :: cyl_q_sf
+
     ! Single precision storage for flow variables
     real(sp), allocatable, dimension(:, :, :), public :: q_sf_s
     real(sp), allocatable, dimension(:, :, :) :: q_root_sf_s
@@ -219,10 +220,6 @@ contains
 
             file_loc = trim(proc_rank_dir)//'/.'
 
-            !INQUIRE( DIRECTORY = TRIM(file_loc), & ! Intel compiler
-            !EXIST     = dir_check       )
-            ! INQUIRE( FILE      = TRIM(file_loc), & ! NAG/PGI/GCC compiler
-            !           EXIST     = dir_check       )
             call my_inquire(file_loc, dir_check)
             if (dir_check .neqv. .true.) then
                 call s_create_directory(trim(proc_rank_dir))
@@ -235,10 +232,6 @@ contains
 
                 file_loc = trim(rootdir)//'/.'
 
-                !INQUIRE( DIRECTORY = TRIM(file_loc), & ! Intel compiler
-                !        EXIST     = dir_check       )
-                !  INQUIRE( FILE      = TRIM(file_loc), & ! NAG/PGI/GCC compiler
-                !           EXIST     = dir_check       )
                 call my_inquire(file_loc, dir_check)
                 if (dir_check .neqv. .true.) then
                     call s_create_directory(trim(rootdir))
@@ -259,10 +252,6 @@ contains
 
             file_loc = trim(proc_rank_dir)//'/.'
 
-            !INQUIRE( DIRECTORY = TRIM(file_loc), & ! Intel compiler
-            !       EXIST     = dir_check       )
-            !  INQUIRE( FILE      = TRIM(file_loc), & ! NAG/PGI/GCC compiler
-            !           EXIST     = dir_check       )
             call my_inquire(file_loc, dir_check)
 
             if (dir_check .neqv. .true.) then
@@ -276,10 +265,6 @@ contains
 
                 file_loc = trim(rootdir)//'/.'
 
-                !INQUIRE( DIRECTORY = TRIM(file_loc), & ! Intel compiler
-                !        EXIST     = dir_check       )
-                !  INQUIRE( FILE      = TRIM(file_loc), & ! NAG/PGI/GCC compiler
-                !        EXIST     = dir_check       )
                 call my_inquire(file_loc, dir_check)
 
                 if (dir_check .neqv. .true.) then

toolchain/pyproject.toml

@@ -26,6 +26,8 @@ dependencies = [
     "pylint",
     "fprettify",
     "black",
+    "fortitude-lint",
+    "ansi2txt",
 
     # Profiling
     "numpy",