Fix wrapper script creation and permissions

- Create wrapper script in buildpath first, then install
- Use install method instead of bin.install
- Fix indentation and formatting
- Still investigating executable permission issue with Homebrew

Author: sbryngelson

packaging/homebrew/mfc.rb

@@ -72,28 +72,31 @@ def install
     # 1. Works around read-only Cellar issue by copying venv to tmpdir
     # 2. Sets up toolchain symlink so mfc.sh can find toolchain/util.sh
     # 3. Ensures mfc.sh doesn't reinstall packages by copying pyproject.toml
-    (bin/"mfc").write <<~EOS
-                        #!/bin/bash
-                        set -e
 
-                        # Unset VIRTUAL_ENV to ensure mfc.sh uses the copied venv, not the Cellar one
-                        unset VIRTUAL_ENV
+    # Create wrapper script in buildpath first, then install it
+    wrapper_script = buildpath/"mfc_wrapper"
+    wrapper_script.write <<~EOS
+            #!/bin/bash
+            set -e
 
-                        # Create a temporary working directory (Cellar is read-only)
-                        TMPDIR=$(mktemp -d)
-                        trap "rm -rf $TMPDIR" EXIT
+            # Unset VIRTUAL_ENV to ensure mfc.sh uses the copied venv, not the Cellar one
+            unset VIRTUAL_ENV
 
-                        # Copy mfc.sh to temp dir (it may try to write build artifacts)
-                        cp "#{libexec}/mfc.sh" "$TMPDIR/"
-                        cd "$TMPDIR"
+            # Create a temporary working directory (Cellar is read-only)
+            TMPDIR=$(mktemp -d)
+            trap "rm -rf $TMPDIR" EXIT
 
-                        # Copy toolchain directory (not symlink) so Python paths resolve correctly
-                        # This prevents paths from resolving back to read-only Cellar
-                        cp -R "#{prefix}/toolchain" toolchain
+            # Copy mfc.sh to temp dir (it may try to write build artifacts)
+            cp "#{libexec}/mfc.sh" "$TMPDIR/"
+            cd "$TMPDIR"
 
-                  # Patch toolchain to use Homebrew-installed binaries
-                  # Replace get_install_binpath to return Homebrew bin directory
-                  cat >> toolchain/mfc/build.py << 'PATCH_EOF'
+            # Copy toolchain directory (not symlink) so Python paths resolve correctly
+            # This prevents paths from resolving back to read-only Cellar
+            cp -R "#{prefix}/toolchain" toolchain
+
+            # Patch toolchain to use Homebrew-installed binaries
+            # Replace get_install_binpath to return Homebrew bin directory
+            cat >> toolchain/mfc/build.py << 'PATCH_EOF'
 
       # Homebrew patch: Override get_install_binpath to use pre-installed binaries
       _original_get_install_binpath = MFCTarget.get_install_binpath
@@ -108,29 +111,30 @@ def _homebrew_is_buildable(self):
               return False  # Skip building - use pre-installed binaries
           return _original_is_buildable(self)
       MFCTarget.is_buildable = _homebrew_is_buildable
-            PATCH_EOF
+      PATCH_EOF
 
-                        # Copy examples directory (required by mfc.sh Python code)
-                        cp -R "#{prefix}/examples" examples
+            # Copy examples directory (required by mfc.sh Python code)
+            cp -R "#{prefix}/examples" examples
 
-                        # Create build directory and copy venv (not symlink - needs to be writable)
-                        # Use cp -R for a full recursive copy
-                        mkdir -p build
-                        cp -R "#{venv}" build/venv
+            # Create build directory and copy venv (not symlink - needs to be writable)
+            # Use cp -R for a full recursive copy
+            mkdir -p build
+            cp -R "#{venv}" build/venv
 
-                        # Copy pyproject.toml to build/ so mfc.sh thinks dependencies are already installed
-                        cp "#{prefix}/toolchain/pyproject.toml" build/pyproject.toml
+            # Copy pyproject.toml to build/ so mfc.sh thinks dependencies are already installed
+            cp "#{prefix}/toolchain/pyproject.toml" build/pyproject.toml
 
-                        # For 'mfc run', add --no-build flag to skip compilation
-                        if [ "$1" = "run" ]; then
-                          exec ./mfc.sh "$@" --no-build
-                        else
-                          exec ./mfc.sh "$@"
-                        fi
+            # For 'mfc run', add --no-build flag to skip compilation
+            if [ "$1" = "run" ]; then
+              exec ./mfc.sh "$@" --no-build
+            else
+              exec ./mfc.sh "$@"
+            fi
     EOS
 
-    # Make the wrapper script executable
-    (bin/"mfc").chmod 0755
+    # Make wrapper executable and install it
+    wrapper_script.chmod 0755
+    install wrapper_script, bin/"mfc"
   end
 
   def caveats