Skip to content

Commit 9fbc566

Browse files
authored
Some LAPACK fixups (#974)
1 parent 5ee319c commit 9fbc566

File tree

9 files changed

+187
-177
lines changed

9 files changed

+187
-177
lines changed

.github/workflows/cleanliness.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ jobs:
4141
- name: Setup Ubuntu
4242
run: |
4343
sudo apt update -y
44-
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev
45-
44+
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev libblas-dev liblapack-dev
45+
4646
- name: Build
4747
run: |
4848
(cd pr && /bin/bash mfc.sh build -j $(nproc) --debug 2> ../pr.txt)

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- name: Setup Ubuntu
3131
run: |
3232
sudo apt update -y
33-
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev
33+
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev libblas-dev liblapack-dev
3434
3535
- name: Build
3636
run: /bin/bash mfc.sh build -j $(nproc) --gcov

.github/workflows/test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
run: |
5454
brew update
5555
brew upgrade
56-
brew install coreutils python cmake fftw hdf5 gcc@15 boost open-mpi
56+
brew install coreutils python cmake fftw hdf5 gcc@15 boost open-mpi lapack
5757
echo "FC=gfortran-15" >> $GITHUB_ENV
5858
echo "BOOST_INCLUDE=/opt/homebrew/include/" >> $GITHUB_ENV
5959
@@ -62,7 +62,8 @@ jobs:
6262
run: |
6363
sudo apt update -y
6464
sudo apt install -y cmake gcc g++ python3 python3-dev hdf5-tools \
65-
libfftw3-dev libhdf5-dev openmpi-bin libopenmpi-dev
65+
libfftw3-dev libhdf5-dev openmpi-bin libopenmpi-dev \
66+
libblas-dev liblapack-dev
6667
6768
- name: Setup Ubuntu (Intel)
6869
if: matrix.os == 'ubuntu' && matrix.intel == true

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ It's rather straightforward.
9090
We'll give a brief intro. here for MacOS.
9191
Using [brew](https://brew.sh), install MFC's dependencies:
9292
```shell
93-
brew install coreutils python cmake fftw hdf5 gcc boost open-mpi
93+
brew install coreutils python cmake fftw hdf5 gcc boost open-mpi lapack
9494
```
9595
You're now ready to build and test MFC!
9696
Put it to a convenient directory via
@@ -199,7 +199,7 @@ They are organized below.
199199

200200
* [Fypp](https://fypp.readthedocs.io/en/stable/fypp.html) metaprogramming for code readability, performance, and portability
201201
* Continuous Integration (CI)
202-
* Approx. 500 Regression tests with each PR.
202+
* > 500 Regression tests with each PR.
203203
* Performed with GNU (GCC), Intel (oneAPI), Cray (CCE), and NVIDIA (NVHPC) compilers on NVIDIA and AMD GPUs.
204204
* Line-level test coverage reports via [Codecov](https://app.codecov.io/gh/MFlowCode/MFC) and `gcov`
205205
* Benchmarking to avoid performance regressions and identify speed-ups

docs/documentation/getting-started.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ cd MFC
1414
MFC can be built in multiple ways on various operating systems.
1515
Please select your desired configuration from the list bellow:
1616

17-
<details>
1817
<summary><h2>*nix</h2></summary>
1918

2019
- **On supported clusters:** Load environment modules
@@ -31,15 +30,14 @@ sudo apt upgrade
3130
sudo apt install tar wget make cmake gcc g++ \
3231
python3 python3-dev python3-venv \
3332
openmpi-bin libopenmpi-dev \
34-
libhdf5-dev libfftw3-dev
33+
libhdf5-dev libfftw3-dev \
34+
libblas-dev liblapack-dev
3535
```
3636

37-
If you wish to build MFC using [NVidia's NVHPC SDK](https://developer.nvidia.com/hpc-sdk),
37+
If you wish to build MFC using [NVIDIA's NVHPC SDK](https://developer.nvidia.com/hpc-sdk),
3838
first follow the instructions [here](https://developer.nvidia.com/nvidia-hpc-sdk-downloads).
3939

40-
</details>
4140

42-
<details>
4341
<summary><h2>Windows</h2></summary>
4442

4543
On Windows, you can either use Intel Compilers with the standard Microsoft toolchain,
@@ -96,16 +94,13 @@ You will also have access to the `.sln` Microsoft Visual Studio solution files f
9694

9795
</details>
9896

99-
</details>
100-
101-
<details>
10297
<summary><h3>MacOS</h3></summary>
10398

10499
Using [Homebrew](https://brew.sh/) you can install the necessary dependencies
105100
before configuring your environment:
106101

107102
```shell
108-
brew install coreutils python cmake fftw hdf5 gcc boost open-mpi
103+
brew install coreutils python cmake fftw hdf5 gcc boost open-mpi lapack
109104
echo -e "export BOOST_INCLUDE='$(brew --prefix --installed boost)/include'" | tee -a ~/.bash_profile ~/.zshrc
110105
. ~/.bash_profile 2>/dev/null || . ~/.zshrc 2>/dev/null
111106
! [ -z "${BOOST_INCLUDE+x}" ] && echo 'Environment is ready!' || echo 'Error: $BOOST_INCLUDE is unset. Please adjust the previous commands to fit with your environment.'

docs/documentation/gpuDebugging.md

Lines changed: 0 additions & 156 deletions
This file was deleted.

0 commit comments

Comments
 (0)