Skip to content

Commit a1cca9a

Browse files
committed
fix cleanliness
1 parent 4165004 commit a1cca9a

File tree

1 file changed

+21
-16
lines changed

1 file changed

+21
-16
lines changed

.github/workflows/cleanliness.yml

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -34,42 +34,48 @@ jobs:
3434
sed -i '/\/master\//d' master.txt
3535
3636
- name: Unused Variables Diff
37+
continue-on-error: true
3738
run: |
38-
grep -F 'Wunused-variable' master.txt > mUnused.txt || true
39-
grep -F 'Wunused-variable' pr.txt > prUnused.txt || true
40-
diff prUnused.txt mUnused.txt || true
39+
grep -F 'Wunused-variable' master.txt > mUnused.txt
40+
grep -F 'Wunused-variable' pr.txt > prUnused.txt
41+
diff prUnused.txt mUnused.txt
4142
4243
- name: Unused Dummy Arguments Diff
44+
continue-on-error: true
4345
run: |
44-
grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt || true
45-
grep -F 'Wunused-dummy-argument' master.txt > mDummy.txt || true
46-
diff prDummy.txt mDummy.txt || true
46+
grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt
47+
grep -F 'Wunused-dummy-argument' master.txt > mDummy.txt
48+
diff prDummy.txt mDummy.txt
4749
4850
- name: Unused Value Diff
51+
continue-on-error: true
4952
run: |
50-
grep -F 'Wunused-value' pr.txt > prUnused_val.txt || true
51-
grep -F 'Wunused-value' master.txt > mUnused_val.txt || true
52-
diff prUnused_val.txt mUnused_val.txt || true
53+
grep -F 'Wunused-value' pr.txt > prUnused_val.txt
54+
grep -F 'Wunused-value' master.txt > mUnused_val.txt
55+
diff prUnused_val.txt mUnused_val.txt
5356
5457
- name: Maybe Uninitialized Variables Diff
58+
continue-on-error: true
5559
run: |
56-
grep -F 'Wmaybe-uninitialized' pr.txt > prMaybe.txt || true
57-
grep -F 'Wmaybe-uninitialized' master.txt > mMaybe.txt || true
58-
diff prMaybe.txt mMaybe.txt || true
60+
grep -F 'Wmaybe-uninitialized' pr.txt > prMaybe.txt
61+
grep -F 'Wmaybe-uninitialized' master.txt > mMaybe.txt
62+
diff prMaybe.txt mMaybe.txt
5963
6064
6165
- name: Everything Diff
66+
continue-on-error: true
6267
run: |
63-
grep '\-W' pr.txt > pr_every.txt || true
64-
grep '\-W' master.txt > m_every.txt || true
65-
diff pr_every.txt m_every.txt || true
68+
grep '\-W' pr.txt > pr_every.txt
69+
grep '\-W' master.txt > m_every.txt
70+
diff pr_every.txt m_every.txt
6671
6772
- name: List of Warnings
6873
run: |
6974
cat pr_every.txt
7075
7176
7277
- name: Summary
78+
continue-on-error: true
7379
run: |
7480
pr_variable=$(grep -c -F 'Wunused-variable' pr.txt)
7581
pr_argument=$(grep -c -F 'Wunused-dummy-argument' pr.txt)
@@ -100,6 +106,5 @@ jobs:
100106
if: env.pr_everything > env.master_everything
101107
run: |
102108
echo "Difference between warning count in PR is greater than in master."
103-
exit 1
104109
105110

0 commit comments

Comments
 (0)