Skip to content

Commit ac6248f

Browse files
committed
Remove 'mfc run' test from CI and clarify Homebrew limitations
The Homebrew formula installs pre-built binaries only, not the full source tree. The 'mfc run' command requires CMakeLists.txt and source files to build cases. Changes: - Remove 'mfc run' test from CI (not applicable for binary-only install) - Update formula caveats to explain this limitation - Document that users should clone the repo for development workflows - CI now only tests binary installation and 'mfc --help' functionality
1 parent 9b8b345 commit ac6248f

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

.github/workflows/homebrew.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -144,16 +144,10 @@ jobs:
144144
145145
echo "=== All tests passed! ==="
146146
147-
- name: Run MFC test case
148-
run: |
149-
echo "Running a simple test case (1D Sod shock tube)..."
150-
TESTDIR=$(mktemp -d)
151-
cp $(brew --prefix mfc)/examples/1D_sodshocktube/case.py "$TESTDIR/"
152-
153-
echo "Running with $(sysctl -n hw.ncpu) processors..."
154-
mfc run "$TESTDIR/case.py" -j $(sysctl -n hw.ncpu)
155-
156-
echo "Test case completed successfully!"
147+
# Note: The 'mfc run' command requires the full MFC source tree to build/run cases.
148+
# The Homebrew formula only installs pre-built binaries, not the development source.
149+
# Users who need 'mfc run' should clone the MFC repository and use mfc.sh there.
150+
# The pre-built binaries (pre_process, simulation, post_process) can be used directly.
157151

158152
- name: Uninstall and cleanup
159153
if: always()

packaging/homebrew/mfc.rb

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,19 @@ def caveats
111111
<<~EOS
112112
MFC has been installed successfully!
113113
114-
To use MFC:
115-
mfc --help
114+
Pre-built binaries are available:
115+
pre_process, simulation, post_process
116116
117117
Examples are available in:
118118
#{prefix}/examples
119119
120-
Note: Cantera 3.1.0 is pre-installed in the MFC virtual environment.
120+
Note: The 'mfc run' command requires the full MFC source tree.
121+
For development workflows, clone the repository and use mfc.sh:
122+
git clone https://github.com/MFlowCode/MFC.git
123+
cd MFC
124+
./mfc.sh run <case.py>
125+
126+
Cantera 3.1.0 is pre-installed in the MFC virtual environment.
121127
EOS
122128
end
123129

0 commit comments

Comments
 (0)