Skip to content

Commit ae76acf

Browse files
Document usage of -c flag for ./mfc.sh test (#472)
Co-authored-by: Spencer Bryngelson <[email protected]>
1 parent 2810b09 commit ae76acf

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,6 @@ function(MFC_SETUP_TARGET)
465465
PRIVATE -gpu=unified
466466
)
467467
endif()
468-
469468
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
470469
target_compile_options(${ARGS_TARGET}
471470
PRIVATE -gpu=autocompare,debug

docs/documentation/testing.md

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,25 @@ To run MFC's test suite, run
55
./mfc.sh test -j <thread count>
66
```
77

8-
It will generate and run test cases, comparing their output to that of previous runs from versions of MFC considered to be accurate.
9-
*golden files*, stored in the `tests/` directory contain this data, by aggregating `.dat` files generated when running MFC.
10-
A test is considered passing when our error tolerances are met, in order to maintain a high level of stability and accuracy.
8+
It will generate and run test cases, comparing their output to previous runs from versions of MFC considered accurate.
9+
*golden files*, stored in the `tests/` directory contain this data, aggregating `.dat` files generated when running MFC.
10+
A test is considered passing when our error tolerances are met in order to maintain a high level of stability and accuracy.
1111
Run `./mfc.sh test -h` for a full list of accepted arguments.
1212

1313
Most notably, you can consult the full list of tests by running
14-
```
14+
```shell
1515
./mfc.sh test -l
1616
```
1717

1818
To restrict to a given range, use the `--from` (`-f`) and `--to` (`-t`) options.
1919
To run a (non-contiguous) subset of tests, use the `--only` (`-o`) option instead.
20+
To specify a computer, pass the `-c` flag to `./mfc.sh run` like so:
21+
```shell
22+
./mfc.sh test -j <thread count> -- -c <computer name>
23+
```
24+
where `<computer name>` could be `phoenix` or any of the others in the [templates](https://github.com/MFlowCode/MFC/tree/master/toolchain/templates)).
25+
You can create new templates with the appropriate run commands or omit this option.
26+
The use of `--` in the above command passes options to the `./mfc.sh run` command underlying the `./mfc.sh test`.
2027

2128
### Creating Tests
2229

@@ -74,7 +81,7 @@ for weno_order in [3, 5]:
7481
stack.pop()
7582
```
7683

77-
When pushing to the stack, or creating a new case with the `define_case_d` function, you must specify:
84+
When pushing to the stack or creating a new case with the `define_case_d` function, you must specify:
7885
- `stack`: The current stack.
7986
- `trace`: A human-readable string describing what you are currently varying.
8087
- `variations`: A Python dictionary with case parameter variations.
@@ -86,13 +93,13 @@ Finally, the case is appended to the `cases` list, which will be returned by the
8693

8794
### Testing Post Process
8895

89-
To test updated post process code, append the `-a` or `--test-all` option:
96+
To test the post-processing code, append the `-a` or `--test-all` option:
9097
```shell
9198
./mfc.sh test -a -j 8
9299
```
93100

94-
This argument will re-run the test stack with `parallel_io=True`, which generates silo_hdf5 files.
101+
This argument will re-run the test stack with `parallel_io='T'`, which generates silo_hdf5 files.
95102
It will also turn most write parameters (`*_wrt`) on.
96-
Then, it searches through the silo files using `h5dump` to ensure that there are no NaNs or Infinitys.
97-
Although adding this option does not guarantee that accurate silo files are generated, it does ensure that post process does not fail or produce malformed data.
103+
Then, it searches through the silo files using `h5dump` to ensure that there are no `NaN`s or `Infinity`s.
104+
Although adding this option does not guarantee that accurate `.silo` files are generated, it does ensure that the post-process code does not fail or produce malformed data.
98105

0 commit comments

Comments
 (0)