Skip to content

Commit bb22a53

Browse files
author
mohdsaid497566
committed
bench table fix
1 parent 3221273 commit bb22a53

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

toolchain/mfc/bench.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,13 @@ def diff():
111111
table.add_column("[bold]Pre Process[/bold]", justify="right")
112112
table.add_column("[bold]Simulation[/bold]", justify="right")
113113
table.add_column("[bold]Post Process[/bold]", justify="right")
114-
114+
115115
err = 0
116116
for slug in slugs:
117117
lhs_summary, rhs_summary = lhs["cases"][slug]["output_summary"], rhs["cases"][slug]["output_summary"]
118-
speedups = []
119-
120-
for target in sorted(DEFAULT_TARGETS, key=lambda t: t.runOrder):
118+
speedups = ['N/A', 'N/A', 'N/A']
119+
120+
for i, target in enumerate(sorted(DEFAULT_TARGETS, key=lambda t: t.runOrder)):
121121
if (target.name not in lhs_summary) or (target.name not in rhs_summary):
122122
cons.print(f"{target.name} not present in lhs_summary or rhs_summary - Case: {slug}")
123123
err = 1; continue
@@ -126,24 +126,27 @@ def diff():
126126
err = 1
127127
cons.print(f"lhs_summary or rhs_summary reports non-real exec time for {target.name} - Case: {slug}")
128128

129+
exec_time_speedup = "N/A"
129130
try:
130131
exec_time_value = lhs_summary[target.name]["exec"] / rhs_summary[target.name]["exec"]
131-
speedups = f"Exec: {exec_time_value:.2f}"
132+
exec_time_speedup = f"Exec: {exec_time_value:.2f}"
132133
if exec_time_value < 0.9:
133134
cons.print(f"[bold yellow]Warning[/bold yellow]: Exec time speedup for {target.name} is less than 0.9 - Case: {slug}")
134-
135+
speedups[i] = f"Exec: {exec_time_speedup}"
135136
if target == SIMULATION:
137+
grind_time_speedup = "N/A"
136138
if not math.isfinite(lhs_summary[target.name]["grind"]) or not math.isfinite(rhs_summary[target.name]["grind"]):
137139
err = 1
138140
cons.print(f"lhs_summary or rhs_summary reports non-real grind time for {target.name} - Case: {slug}")
139141

140142
grind_time_value = lhs_summary[target.name]["grind"] / rhs_summary[target.name]["grind"]
141-
speedups += f" & Grind: {grind_time_value:.2f}"
143+
grind_time_speedup += f" & Grind: {grind_time_value:.2f}"
142144
if grind_time_value <0.98:
143145
raise MFCException(f"Benchmarking failed since grind time speedup for {target.name} below acceptable threshold (<0.98) - Case: {slug}")
144146
except Exception as _:
145147
err = 1
146148
cons.print(f"lhs_summary or rhs_summary reports non-real grind time for {target.name} - Case: {slug}")
149+
speedups[i] += f" & Grind: {grind_time_speedup}"
147150

148151
table.add_row(f"[magenta]{slug}[/magenta]", *speedups)
149152

0 commit comments

Comments
 (0)