Revert "frontier changes"

This reverts commit 45da453.

Author: wilfonba

src/simulation/m_bubbles_EL.fpp

@@ -74,13 +74,6 @@ module m_bubbles_EL
 
     !$acc declare create(nBubs, Rmax_glb, Rmin_glb, q_beta, q_beta_idx)
 
-    integer :: remove_id !< Module variable for s_update_tmp_rkck
-    !$acc declare create(remove_id)
-
-    ! Module variables for s_write_void_evol
-    real(kind(0d0)) :: lag_voidmax, lag_voidavg, lag_vol
-    !$acc declare create(lag_voidmax, lag_voidavg, lag_vol)
-
 contains
 
     !> Initializes the lagrangian subgrid bubble solver
@@ -1168,16 +1161,13 @@ contains
 
         integer :: i, j, k, l, q
         real(kind(0d0)) :: radiusOld, velOld, aux_glb
+        integer :: remove_id
 
         call s_transfer_data_to_tmp()
 
         lag_largestep = 0d0
         remove_id = 0
-
-        !$acc update device(lag_largestep, remove_id)
-
-        !$acc parallel loop gang vector default(present) reduction(+:lag_largestep) &
-        !%acc reduction(MAX: remove_id) private(k) copyin(RKstep) copy(largstep, remove_id)
+        !$acc parallel loop gang vector default(present) reduction(+: lag_largestep) reduction(MAX: remove_id) private(k) copyin(RKstep)
         do k = 1, nBubs
 
             radiusOld = intfc_rad(k, 2)
@@ -1204,8 +1194,6 @@ contains
 
         end do
 
-        !$acc update host(lag_largestep, remove_id)
-
         if (remove_id /= 0) call s_remove_lag_bubble(remove_id)
 
 #ifdef MFC_MPI
@@ -1251,11 +1239,7 @@ contains
         integer :: i, j, k
 
         rkck_errmax = 0d0
-
-        !$acc update device(rkck_errmax)
-
-        !$acc parallel loop gang vector default(present) reduction(MAX: rkck_errmax) &
-        !$acc private(k) copy(rkck_errmax)
+        !$acc parallel loop gang vector default(present) reduction(MAX: rkck_errmax) private(k)
         do k = 1, nBubs
             errb = 0d0
 
@@ -1288,8 +1272,6 @@ contains
             rkck_errmax = max(rkck_errmax, errb)
         end do
 
-        !$acc update host(rkck_errmax)
-
     end subroutine s_calculate_rkck_truncation_error
 
     !>  This subroutine updates the conservative fields and the lagrangian variables after accepting the performed time step.
@@ -1312,10 +1294,10 @@ contains
         end do
 
         !$acc parallel loop collapse(4) gang vector default(present)
-        do l = 1, sys_size
-            do k = 0, p
-                do j = 0, n
-                    do i = 0, m
+        do i = 0, m
+            do j = 0, n
+                do k = 0, p
+                    do l = 1, sys_size
                         q_cons_ts(1)%vf(l)%sf(i, j, k) = q_cons_ts(2)%vf(l)%sf(i, j, k)
                     end do
                 end do
@@ -1646,9 +1628,11 @@ contains
     subroutine s_write_void_evol(qtime)
 
         real(kind(0d0)) :: qtime, volcell, voltot
+        real(kind(0d0)) :: lag_voidmax, lag_voidavg, lag_vol
         real(kind(0d0)) :: voidmax_glb, voidavg_glb, vol_glb
 
         integer :: i, j, k
+        integer, dimension(3) :: cell
 
         character(LEN=path_len + 2*name_len) :: file_loc
 
@@ -1657,6 +1641,11 @@ contains
             file_loc = trim(case_dir)//'/D/'//trim(file_loc)
             if (qtime == 0d0) then
                 open (12, FILE=trim(file_loc), FORM='formatted', position='rewind')
+                !write (12, *) 'currentTime, averageVoidFraction, ', &
+                !    'maximumVoidFraction, totalParticlesVolume'
+                !write (12, *) 'The averageVoidFraction value does ', &
+                !    'not reflect the real void fraction in the cloud since the ', &
+                !    'cells which do not have bubbles are not accounted'
             else
                 open (12, FILE=trim(file_loc), FORM='formatted', position='append')
             end if
@@ -1665,16 +1654,16 @@ contains
         lag_voidmax = 0d0
         lag_voidavg = 0d0
         lag_vol = 0d0
-
-        !$acc update device(lag_voidmax, lag_voidavg, lag_vol)
-
         !$acc parallel loop collapse(3) gang vector default(present) reduction(+:lag_vol,lag_voidavg) &
-        !$acc reduction(MAX:lag_voidmax) copy(lag_voidmax,lag_voidavg, lag_vol)
-        do k = 0, p
+        !$acc reduction(MAX:lag_voidmax) private(cell)
+        do i = 0, m
             do j = 0, n
-                do i = 0, p
+                do k = 0, p
                     lag_voidmax = max(lag_voidmax, 1d0 - q_beta%vf(1)%sf(i, j, k))
-                    call s_get_char_vol(i, j, k, volcell)
+                    cell(1) = i
+                    cell(2) = j
+                    cell(3) = k
+                    call s_get_char_vol(cell(1), cell(2), cell(3), volcell)
                     if ((1d0 - q_beta%vf(1)%sf(i, j, k)) > 5.0d-11) then
                         lag_voidavg = lag_voidavg + (1d0 - q_beta%vf(1)%sf(i, j, k))*volcell
                         lag_vol = lag_vol + volcell
@@ -1683,8 +1672,6 @@ contains
             end do
         end do
 
-        !$acc update host(lag_voidmax, lag_voidavg, lag_vol)
-
 #ifdef MFC_MPI
         if (num_procs > 1) then
             call s_mpi_allreduce_max(lag_voidmax, voidmax_glb)
@@ -1854,22 +1841,14 @@ contains
 
         integer :: k
 
-        Rmax_glb = 0d0
-        Rmin_glb = 0d0
-
-        !$acc update device(Rmax_glb, Rmin_glb)
-
-        !$acc parallel loop gang vector default(present) reduction(MAX: Rmax_glb) reduction(MIN: Rmin_glb) &
-        !$acc  private(k) copy(Rmax_glb, Rmin_glb)
+        !$acc parallel loop gang vector default(present) reduction(MAX: Rmax_glb) reduction(MIN: Rmin_glb) private(k)
         do k = 1, nBubs
             Rmax_glb = max(Rmax_glb, intfc_rad(k, 1)/bub_R0(k))
             Rmin_glb = min(Rmin_glb, intfc_rad(k, 1)/bub_R0(k))
             Rmax_stats(k) = max(Rmax_stats(k), intfc_rad(k, 1)/bub_R0(k))
             Rmin_stats(k) = min(Rmin_stats(k), intfc_rad(k, 1)/bub_R0(k))
         end do
 
-        !$acc update host(Rmax_glb, Rmin_glb)
-
     end subroutine s_calculate_lag_bubble_stats
 
     !>  Subroutine that writes the maximum and minimum radius of each bubble.

src/simulation/m_time_steppers.fpp

@@ -73,10 +73,6 @@ module m_time_steppers
 
     !$acc declare create(q_cons_ts,q_prim_vf,rhs_vf,rhs_ts_rkck,q_prim_ts, rhs_mv, rhs_pb, max_dt)
 
-    ! Module variables for rkck timestepper
-    real(kind(0d0)) :: lag_largestep, rkck_errmax
-    !$acc declare create(lag_largestep, rkck_errmax)
-
 contains
 
     !> The computation of parameters, the allocation of memory,
@@ -1048,7 +1044,7 @@ contains
         real(kind(0d0)), intent(out) :: time_avg
 
         logical :: restart_rkck_step, start_rkck_step
-        real(kind(0.d0)) :: dt_did
+        real(kind(0.d0)) :: lag_largestep, rkck_errmax, dt_did
         integer :: RKstep
 
         mytime = mytime - dt