Skip to content

Commit c7394e8

Browse files
committed
Remove style check from Spack CI
- spack style has false positives on star imports (F405) - No flag exists to skip specific flake8 checks - Audit check is more important and validates package correctness - Package info and spec tests provide sufficient validation
1 parent 74ac7e8 commit c7394e8

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

.github/workflows/spack.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ jobs:
4848
# Show package info to confirm it loads
4949
spack info mfc
5050
51-
- name: Run Spack Style Check
52-
run: |
53-
. spack/share/spack/setup-env.sh
54-
# Skip flake8 F405 warnings which are expected for star imports in Spack packages
55-
spack style --no-flake8 packaging/spack/package.py
56-
5751
- name: Run Spack Audit
5852
run: |
5953
. spack/share/spack/setup-env.sh

0 commit comments

Comments
 (0)