Finished first pass through pure subroutines

Author: prathi-wind

src/common/m_variables_conversion.fpp

@@ -79,7 +79,7 @@ contains
         !!  @param gamma Specific heat ratio function
         !!  @param pi_inf Liquid stiffness function
         !!  @param qv Fluid reference energy
-    impure subroutine s_convert_to_mixture_variables(q_vf, i, j, k, &
+    subroutine s_convert_to_mixture_variables(q_vf, i, j, k, &
                                               rho, gamma, pi_inf, qv, Re_K, G_K, G)
 
         type(scalar_field), dimension(sys_size), intent(in) :: q_vf
@@ -205,7 +205,7 @@ contains
         !! @param gamma  specific heat ratio function
         !! @param pi_inf liquid stiffness
         !! @param qv fluid reference energy
-    impure subroutine s_convert_mixture_to_mixture_variables(q_vf, i, j, k, &
+    subroutine s_convert_mixture_to_mixture_variables(q_vf, i, j, k, &
                                                       rho, gamma, pi_inf, qv, Re_K, G_K, G)
 
         type(scalar_field), dimension(sys_size), intent(in) :: q_vf
@@ -252,7 +252,7 @@ contains
         !! @param gamma specific heat ratio
         !! @param pi_inf liquid stiffness
         !! @param qv fluid reference energy
-    impure subroutine s_convert_species_to_mixture_variables_bubbles(q_vf, j, k, l, &
+    subroutine s_convert_species_to_mixture_variables_bubbles(q_vf, j, k, l, &
                                                               rho, gamma, pi_inf, qv, Re_K, G_K, G)
 
         type(scalar_field), dimension(sys_size), intent(in) :: q_vf
@@ -376,7 +376,7 @@ contains
         !! @param gamma specific heat ratio
         !! @param pi_inf liquid stiffness
         !! @param qv fluid reference energy
-    impure subroutine s_convert_species_to_mixture_variables(q_vf, k, l, r, rho, &
+    subroutine s_convert_species_to_mixture_variables(q_vf, k, l, r, rho, &
                                                       gamma, pi_inf, qv, Re_K, G_K, G)
 
         type(scalar_field), dimension(sys_size), intent(in) :: q_vf
@@ -816,7 +816,7 @@ contains
         !! @param ix Index bounds in first coordinate direction
         !! @param iy Index bounds in second coordinate direction
         !! @param iz Index bounds in third coordinate direction
-    impure subroutine s_convert_conservative_to_primitive_variables(qK_cons_vf, &
+    subroutine s_convert_conservative_to_primitive_variables(qK_cons_vf, &
                                                              q_T_sf, &
                                                              qK_prim_vf, &
                                                              ibounds, &

src/simulation/m_mpi_proxy.fpp

@@ -55,7 +55,7 @@ contains
         !!      available to the other processors. Then, the purpose of
         !!      this subroutine is to distribute the user inputs to the
         !!      remaining processors in the communicator.
-    subroutine s_mpi_bcast_user_inputs()
+    impure subroutine s_mpi_bcast_user_inputs()
 
 #ifdef MFC_MPI
 
@@ -213,7 +213,7 @@ contains
         !!      in each of the coordinate directions, approximately the
         !!      same number of cells, and then recomputing the affected
         !!      global parameters.
-    subroutine s_mpi_decompose_computational_domain
+    impure subroutine s_mpi_decompose_computational_domain
 
 #ifdef MFC_MPI
 
@@ -586,7 +586,7 @@ contains
         !!      directly from those of the cell-width distributions.
         !!  @param mpi_dir MPI communication coordinate direction
         !!  @param pbc_loc Processor boundary condition (PBC) location
-    subroutine s_mpi_sendrecv_grid_variables_buffers(mpi_dir, pbc_loc)
+    impure subroutine s_mpi_sendrecv_grid_variables_buffers(mpi_dir, pbc_loc)
 
         integer, intent(in) :: mpi_dir
         integer, intent(in) :: pbc_loc
@@ -766,7 +766,7 @@ contains
     !>  The goal of this procedure is to populate the buffers of
         !!      the cell-average conservative variables by communicating
         !!      with the neighboring processors.
-    subroutine s_mpi_sendrecv_ib_buffers(ib_markers, gp_layers)
+    impure subroutine s_mpi_sendrecv_ib_buffers(ib_markers, gp_layers)
 
         type(integer_field), intent(inout) :: ib_markers
         integer, intent(in) :: gp_layers
@@ -1612,7 +1612,7 @@ contains
 
     end subroutine s_mpi_sendrecv_ib_buffers
 
-    subroutine s_mpi_send_random_number(phi_rn, num_freq)
+    impure subroutine s_mpi_send_random_number(phi_rn, num_freq)
         integer, intent(in) :: num_freq
         real(wp), intent(inout), dimension(1:num_freq) :: phi_rn
 #ifdef MFC_MPI

src/simulation/m_qbmm.fpp

@@ -43,7 +43,7 @@ module m_qbmm
 
 contains
 
-    subroutine s_initialize_qbmm_module
+    impure subroutine s_initialize_qbmm_module
 
         integer :: i1, i2, q, i, j
 
@@ -411,7 +411,7 @@ contains
 
     end subroutine s_initialize_qbmm_module
 
-    subroutine s_compute_qbmm_rhs(idir, q_cons_vf, q_prim_vf, rhs_vf, flux_n_vf, pb, rhs_pb, mv, rhs_mv)
+    pure subroutine s_compute_qbmm_rhs(idir, q_cons_vf, q_prim_vf, rhs_vf, flux_n_vf, pb, rhs_pb, mv, rhs_mv)
 
         integer, intent(in) :: idir
         type(scalar_field), dimension(sys_size), intent(in) :: q_cons_vf, q_prim_vf
@@ -679,7 +679,7 @@ contains
 
 !Coefficient array for non-polytropic model (pb and mv values are accounted in wght_pb and wght_mv)
 
-    subroutine s_coeff_nonpoly(pres, rho, c, coeffs)
+    pure subroutine s_coeff_nonpoly(pres, rho, c, coeffs)
 #ifdef _CRAYFTN
         !DIR$ INLINEALWAYS s_coeff_nonpoly
 #else
@@ -752,7 +752,7 @@ contains
     end subroutine s_coeff_nonpoly
 
 !Coefficient array for polytropic model (pb for each R0 bin accounted for in wght_pb)
-    subroutine s_coeff(pres, rho, c, coeffs)
+    pure subroutine s_coeff(pres, rho, c, coeffs)
 #ifdef _CRAYFTN
         !DIR$ INLINEALWAYS s_coeff
 #else

src/simulation/m_rhs.fpp

@@ -172,7 +172,7 @@ contains
     !> The computation of parameters, the allocation of memory,
         !!      the association of pointers and/or the execution of any
         !!      other procedures that are necessary to setup the module.
-    subroutine s_initialize_rhs_module
+    impure subroutine s_initialize_rhs_module
 
         integer :: i, j, k, l, id !< Generic loop iterators
 
@@ -611,7 +611,7 @@ contains
 
     end subroutine s_initialize_rhs_module
 
-    subroutine s_compute_rhs(q_cons_vf, q_T_sf, q_prim_vf, bc_type, rhs_vf, pb, rhs_pb, mv, rhs_mv, t_step, time_avg, stage)
+    impure subroutine s_compute_rhs(q_cons_vf, q_T_sf, q_prim_vf, bc_type, rhs_vf, pb, rhs_pb, mv, rhs_mv, t_step, time_avg, stage)
 
         type(scalar_field), dimension(sys_size), intent(inout) :: q_cons_vf
         type(scalar_field), intent(inout) :: q_T_sf
@@ -1753,7 +1753,7 @@ contains
         !!      purpose, this pressure is finally corrected using the
         !!      mixture-total-energy equation.
         !!  @param q_cons_vf Cell-average conservative variables
-    subroutine s_pressure_relaxation_procedure(q_cons_vf)
+    pure subroutine s_pressure_relaxation_procedure(q_cons_vf)
 
         type(scalar_field), dimension(sys_size), intent(inout) :: q_cons_vf
 
@@ -2134,7 +2134,7 @@ contains
     end subroutine s_reconstruct_cell_boundary_values_first_order
 
     !> Module deallocation and/or disassociation procedures
-    subroutine s_finalize_rhs_module
+    impure subroutine s_finalize_rhs_module
 
         integer :: i, j, l
 

src/simulation/m_riemann_solvers.fpp

@@ -202,7 +202,7 @@ contains
         !! For more information please refer to:
         !!      1) s_compute_cartesian_viscous_source_flux
         !!      2) s_compute_cylindrical_viscous_source_flux
-    subroutine s_compute_viscous_source_flux(velL_vf, &
+    pure subroutine s_compute_viscous_source_flux(velL_vf, &
                                              dvelL_dx_vf, &
                                              dvelL_dy_vf, &
                                              dvelL_dz_vf, &
@@ -3311,7 +3311,7 @@ contains
     !>  The computation of parameters, the allocation of memory,
         !!      the association of pointers and/or the execution of any
         !!      other procedures that are necessary to setup the module.
-    subroutine s_initialize_riemann_solvers_module
+    impure subroutine s_initialize_riemann_solvers_module
 
         ! Allocating the variables that will be utilized to formulate the
         ! left, right, and average states of the Riemann problem, as well
@@ -3956,7 +3956,7 @@ contains
         !!  @param ix Index bounds in  first coordinate direction
         !!  @param iy Index bounds in second coordinate direction
         !!  @param iz Index bounds in  third coordinate direction
-    subroutine s_compute_cylindrical_viscous_source_flux(velL_vf, &
+    pure subroutine s_compute_cylindrical_viscous_source_flux(velL_vf, &
                                                          dvelL_dx_vf, &
                                                          dvelL_dy_vf, &
                                                          dvelL_dz_vf, &
@@ -4483,7 +4483,7 @@ contains
         !!  @param ix Index bounds in  first coordinate direction
         !!  @param iy Index bounds in second coordinate direction
         !!  @param iz Index bounds in  third coordinate direction
-    subroutine s_compute_cartesian_viscous_source_flux(velL_vf, &
+    pure subroutine s_compute_cartesian_viscous_source_flux(velL_vf, &
                                                        dvelL_dx_vf, &
                                                        dvelL_dy_vf, &
                                                        dvelL_dz_vf, &
@@ -4968,7 +4968,7 @@ contains
         !!  @param ix   Index bounds in  first coordinate direction
         !!  @param iy   Index bounds in second coordinate direction
         !!  @param iz   Index bounds in  third coordinate direction
-    subroutine s_finalize_riemann_solver(flux_vf, flux_src_vf, &
+    pure subroutine s_finalize_riemann_solver(flux_vf, flux_src_vf, &
                                          flux_gsrc_vf, &
                                          norm_dir, ix, iy, iz)
 
@@ -5127,7 +5127,7 @@ contains
     end subroutine s_finalize_riemann_solver
 
     !> Module deallocation and/or disassociation procedures
-    subroutine s_finalize_riemann_solvers_module
+    impure subroutine s_finalize_riemann_solvers_module
 
         if (viscous) then
             @:DEALLOCATE(Re_avg_rsx_vf)

src/simulation/m_sim_helpers.f90

@@ -29,7 +29,7 @@ module m_sim_helpers
         !! @param j x index
         !! @param k y index
         !! @param l z index
-    subroutine s_compute_enthalpy(q_prim_vf, pres, rho, gamma, pi_inf, Re, H, alpha, vel, vel_sum, j, k, l)
+    pure subroutine s_compute_enthalpy(q_prim_vf, pres, rho, gamma, pi_inf, Re, H, alpha, vel, vel_sum, j, k, l)
 #ifdef _CRAYFTN
         !DIR$ INLINEALWAYS s_compute_enthalpy
 #else
@@ -97,7 +97,7 @@ end subroutine s_compute_enthalpy
         !! @param icfl_sf cell centered inviscid cfl number
         !! @param vcfl_sf (optional) cell centered viscous cfl number
         !! @param Rc_sf (optional) cell centered Rc
-    subroutine s_compute_stability_from_dt(vel, c, rho, Re_l, j, k, l, icfl_sf, vcfl_sf, Rc_sf)
+    pure subroutine s_compute_stability_from_dt(vel, c, rho, Re_l, j, k, l, icfl_sf, vcfl_sf, Rc_sf)
         !$acc routine seq
         real(wp), intent(in), dimension(num_vels) :: vel
         real(wp), intent(in) :: c, rho
@@ -194,7 +194,7 @@ end subroutine s_compute_stability_from_dt
         !! @param j x coordinate
         !! @param k y coordinate
         !! @param l z coordinate
-    subroutine s_compute_dt_from_cfl(vel, c, max_dt, rho, Re_l, j, k, l)
+    pure subroutine s_compute_dt_from_cfl(vel, c, max_dt, rho, Re_l, j, k, l)
         !$acc routine seq
         real(wp), dimension(num_vels), intent(in) :: vel
         real(wp), intent(in) :: c, rho
@@ -268,9 +268,9 @@ subroutine s_compute_dt_from_cfl(vel, c, max_dt, rho, Re_l, j, k, l)
 
     end subroutine s_compute_dt_from_cfl
 
-    subroutine s_assign_default_bc_type(bc_type)
+    pure subroutine s_assign_default_bc_type(bc_type)
 
-        type(integer_field), dimension(1:num_dims, -1:1), intent(in) :: bc_type
+        type(integer_field), dimension(1:num_dims, -1:1), intent(inout) :: bc_type
 
         bc_type(1, -1)%sf(:, :, :) = bc_x%beg
         bc_type(1, 1)%sf(:, :, :) = bc_x%end

src/simulation/m_start_up.fpp

@@ -112,7 +112,7 @@ contains
 
    !> Read data files. Dispatch subroutine that replaces procedure pointer.
         !! @param q_cons_vf Conservative variables
-    subroutine s_read_data_files(q_cons_vf)
+    impure subroutine s_read_data_files(q_cons_vf)
 
         type(scalar_field), &
             dimension(sys_size), &
@@ -130,7 +130,7 @@ contains
     !>  The purpose of this procedure is to first verify that an
         !!      input file has been made available by the user. Provided
         !!      that this is so, the input file is then read in.
-    subroutine s_read_input_file
+    impure subroutine s_read_input_file
 
         ! Relative path to the input file provided by the user
         character(LEN=name_len), parameter :: file_path = './simulation.inp'
@@ -228,7 +228,7 @@ contains
     !> The goal of this procedure is to verify that each of the
     !!      user provided inputs is valid and that their combination
     !!      constitutes a meaningful configuration for the simulation.
-    subroutine s_check_input_file
+    impure subroutine s_check_input_file
 
         ! Relative path to the current directory file in the case directory
         character(LEN=path_len) :: file_path
@@ -256,7 +256,7 @@ contains
         !!              up the latter. This procedure also calculates the cell-
         !!              width distributions from the cell-boundary locations.
         !! @param q_cons_vf Cell-averaged conservative variables
-    subroutine s_read_serial_data_files(q_cons_vf)
+    impure subroutine s_read_serial_data_files(q_cons_vf)
 
         type(scalar_field), dimension(sys_size), intent(INOUT) :: q_cons_vf
 
@@ -501,7 +501,7 @@ contains
     end subroutine s_read_serial_data_files
 
         !! @param q_cons_vf Conservative variables
-    subroutine s_read_parallel_data_files(q_cons_vf)
+    impure subroutine s_read_parallel_data_files(q_cons_vf)
 
         type(scalar_field), &
             dimension(sys_size), &
@@ -963,7 +963,7 @@ contains
         !!          of the grid variables, which are constituted of the cell-
         !!          boundary locations and cell-width distributions, based on
         !!          the boundary conditions.
-    subroutine s_populate_grid_variables_buffers
+    impure subroutine s_populate_grid_variables_buffers
 
         integer :: i !< Generic loop iterator
 
@@ -1239,7 +1239,7 @@ contains
 
     end subroutine s_initialize_internal_energy_equations
 
-    subroutine s_perform_time_step(t_step, time_avg, time_final, io_time_avg, io_time_final, proc_time, io_proc_time, file_exists, start, finish, nt)
+    impure subroutine s_perform_time_step(t_step, time_avg, time_final, io_time_avg, io_time_final, proc_time, io_proc_time, file_exists, start, finish, nt)
         integer, intent(inout) :: t_step
         real(wp), intent(inout) :: time_avg, time_final
         real(wp), intent(inout) :: io_time_avg, io_time_final
@@ -1329,7 +1329,7 @@ contains
 
     end subroutine s_perform_time_step
 
-    subroutine s_save_performance_metrics(t_step, time_avg, time_final, io_time_avg, io_time_final, proc_time, io_proc_time, file_exists, start, finish, nt)
+    impure subroutine s_save_performance_metrics(t_step, time_avg, time_final, io_time_avg, io_time_final, proc_time, io_proc_time, file_exists, start, finish, nt)
 
         integer, intent(inout) :: t_step
         real(wp), intent(inout) :: time_avg, time_final
@@ -1391,7 +1391,7 @@ contains
 
     end subroutine s_save_performance_metrics
 
-    subroutine s_save_data(t_step, start, finish, io_time_avg, nt)
+    impure subroutine s_save_data(t_step, start, finish, io_time_avg, nt)
         integer, intent(inout) :: t_step
         real(wp), intent(inout) :: start, finish, io_time_avg
         integer, intent(inout) :: nt
@@ -1460,7 +1460,7 @@ contains
 
     end subroutine s_save_data
 
-    subroutine s_initialize_modules
+    impure subroutine s_initialize_modules
 
         call s_initialize_global_parameters_module()
         !Quadrature weights and nodes for polydisperse simulations
@@ -1558,7 +1558,7 @@ contains
 
     end subroutine s_initialize_modules
 
-    subroutine s_initialize_mpi_domain
+    impure subroutine s_initialize_mpi_domain
         integer :: ierr
 #ifdef MFC_OpenACC
         real(wp) :: starttime, endtime
@@ -1669,7 +1669,7 @@ contains
         end if
     end subroutine s_initialize_gpu_vars
 
-    subroutine s_finalize_modules
+    impure subroutine s_finalize_modules
 
         call s_finalize_time_steppers_module()
         if (hypoelasticity) call s_finalize_hypoelastic_module()

src/simulation/m_surface_tension.fpp

@@ -44,7 +44,7 @@ module m_surface_tension
 
 contains
 
-    subroutine s_initialize_surface_tension_module
+    impure subroutine s_initialize_surface_tension_module
 
         @:ALLOCATE(c_divs(1:num_dims + 1))
 
@@ -225,7 +225,7 @@ contains
 
     end subroutine s_compute_capilary_source_flux
 
-    subroutine s_get_capilary(q_prim_vf, bc_type)
+    impure subroutine s_get_capilary(q_prim_vf, bc_type)
 
         type(scalar_field), dimension(sys_size), intent(in) :: q_prim_vf
         type(integer_field), dimension(1:num_dims, -1:1), intent(in) :: bc_type
@@ -376,7 +376,7 @@ contains
 
     end subroutine s_reconstruct_cell_boundary_values_capillary
 
-    subroutine s_finalize_surface_tension_module
+    impure subroutine s_finalize_surface_tension_module
 
         do j = 1, num_dims
             @:DEALLOCATE(c_divs(j)%sf)