fix

Author: Archith Iyer

.github/workflows/bench.yml

@@ -20,7 +20,8 @@ jobs:
 
   self:
     name: Georgia Tech | Phoenix (NVHPC)
-    if: github.repository == 'MFlowCode/MFC'
+    if: github.repository == 'MFlowCode/MFC' && needs.file-changes.outputs.checkall == 'true'
+    needs: file-changes
     strategy:
       matrix:
         device: ['cpu', 'gpu']
@@ -33,12 +34,12 @@ jobs:
       ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
     steps:
       - name: Clone - PR
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: pr
 
       - name: Clone - Master
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: MFlowCode/MFC
           ref: master
@@ -56,7 +57,7 @@ jobs:
           (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml)
 
       - name: Archive Logs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if:   always()
         with:
           name: logs-${{ matrix.device }}

.github/workflows/phoenix/bench.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-n_ranks=4
+n_ranks=12
 
 if [ "$job_device" == "gpu" ]; then
     n_ranks=$(nvidia-smi -L | wc -l)        # number of GPUs on node
@@ -9,7 +9,7 @@ if [ "$job_device" == "gpu" ]; then
 fi
 
 if ["$job_device" == "gpu"]; then
-    ./mfc.sh bench --mem 8 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
+    ./mfc.sh bench --mem 12 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
 else
     ./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix $device_opts -n $n_ranks
 fi

.github/workflows/phoenix/submit.sh

@@ -41,7 +41,7 @@ sbatch <<EOT
 #SBATCH --account=gts-sbryngelson3 # charge account
 #SBATCH -N1                        # Number of nodes required
 $sbatch_device_opts
-#SBATCH -t 04:00:00                # Duration of the job (Ex: 15 mins)
+#SBATCH -t 02:00:00                # Duration of the job (Ex: 15 mins)
 #SBATCH -q embers                  # QOS Name
 #SBATCH -o$job_slug.out            # Combined output and error messages file
 #SBATCH -W                         # Do not exit until the submitted job terminates.

toolchain/mfc/bench.py

@@ -61,7 +61,7 @@ def bench(targets = None):
                 ["--targets"] + [t.name for t in targets] +
                 ["--output-summary", summary_filepath] +
                 case.args +
-                ["--", ARG('mem')],
+                ["--", "--gbpp", ARG('mem')],
                 stdout=log_file,
                 stderr=subprocess.STDOUT)
 
@@ -168,3 +168,4 @@ def _lock_to_str(lock):
 
     if err != 0:
         raise MFCException("Benchmarking failed")
+