Switch to checking for dead links in the docs/CI HTML via Lychee #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 42.96% 42.96%
=======================================
Files 61 61
Lines 16339 16339
Branches 1881 1881
=======================================
Hits 7020 7020
Misses 8278 8278
Partials 1041 1041 ☔ View full report in Codecov by Sentry. |
Member
Author
|
this isn't right. need to switch to something that checks HTML not markdown. trying what I update: fixed. |
sbryngelson
added
continuous-integration
sbryngelson
changed the title
sbryngelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to try to fix #671 and #716 at the same time
This PR moves the link checking to the HTML files created by the documentation build/CI.
Lychee is now used to check for dead links.
It works, and finds dead links that have been around a long time. It is currently configured to pass CI even if it finds dead links, but once the dead links are fixed, we will change this.