From ff0e0501a93f94ccc6102c2556877cd6fb9b8a0a Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 15:57:41 -0500 Subject: [PATCH 01/10] Update line-count.yml --- .github/workflows/line-count.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/line-count.yml b/.github/workflows/line-count.yml index 87ba313945..cc5f908ca6 100644 --- a/.github/workflows/line-count.yml +++ b/.github/workflows/line-count.yml @@ -49,5 +49,5 @@ jobs: cd $BASE export MFC_PR=$PR pwd - ./mfc.sh count_diff + ./mfc.sh count_diff << EOF > $GITHUB_STEP_SUMMARY From 2f4ffa47f5f8618c3248c8cf126cbae7805d9412 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 15:58:57 -0500 Subject: [PATCH 02/10] Update lint.yml --- .github/workflows/lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index acb1025b6e..927d935454 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,4 +1,4 @@ -name: Lint +name: Lint Toolchain on: [push, pull_request, workflow_dispatch] @@ -11,4 +11,4 @@ jobs: - uses: actions/checkout@v4 - name: Lint the toolchain - run: ./mfc.sh lint + run: ./mfc.sh lint << EOF > $GITHUB_STEP_SUMMARY From 6e2d94b527364355569ec217572c437b26c1f627 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 15:59:19 -0500 Subject: [PATCH 03/10] Rename lint.yml to lint-toolchain.yml --- .github/workflows/{lint.yml => lint-toolchain.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{lint.yml => lint-toolchain.yml} (100%) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint-toolchain.yml similarity index 100% rename from .github/workflows/lint.yml rename to .github/workflows/lint-toolchain.yml From bd4c1ecb20a847472b0969cb0d570fc7b1734e04 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 15:59:36 -0500 Subject: [PATCH 04/10] Update lint-source.yml --- .github/workflows/lint-source.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint-source.yml b/.github/workflows/lint-source.yml index 29e1716e24..15f1df5033 100644 --- a/.github/workflows/lint-source.yml +++ b/.github/workflows/lint-source.yml @@ -1,10 +1,10 @@ -name: Lint Source Code +name: Lint Source on: [push, pull_request, workflow_dispatch] jobs: lint: - name: Lint Source Code + name: Lint Source runs-on: macos-latest steps: From 45145c34d988705f36653a4ff5e1da01e238b12f Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 16:01:35 -0500 Subject: [PATCH 05/10] Update lint-source.yml --- .github/workflows/lint-source.yml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-source.yml b/.github/workflows/lint-source.yml index 15f1df5033..f941a34aac 100644 --- a/.github/workflows/lint-source.yml +++ b/.github/workflows/lint-source.yml @@ -3,9 +3,24 @@ name: Lint Source on: [push, pull_request, workflow_dispatch] jobs: + file-changes: + name: Detect File Changes + runs-on: 'ubuntu-latest' + outputs: + checkall: ${{ steps.changes.outputs.checkall }} + steps: + - name: Clone + uses: actions/checkout@v4 + + - name: Detect Changes + uses: dorny/paths-filter@v3 + id: changes + with: + filters: ".github/file-filter.yml" + lint: name: Lint Source - runs-on: macos-latest + runs-on: 'ubuntu-latest' steps: - uses: actions/checkout@v4 From dcf54a05e2747387b52ba45ee50a5da8f45752d5 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 16:15:58 -0500 Subject: [PATCH 06/10] Update lint-toolchain.yml --- .github/workflows/lint-toolchain.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-toolchain.yml b/.github/workflows/lint-toolchain.yml index 927d935454..c0e822bb07 100644 --- a/.github/workflows/lint-toolchain.yml +++ b/.github/workflows/lint-toolchain.yml @@ -11,4 +11,4 @@ jobs: - uses: actions/checkout@v4 - name: Lint the toolchain - run: ./mfc.sh lint << EOF > $GITHUB_STEP_SUMMARY + run: ./mfc.sh lint > $GITHUB_STEP_SUMMARY From e392f7ff9cc0e5dd63e13445b5499d924b07a4dc Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 16:16:43 -0500 Subject: [PATCH 07/10] Update line-count.yml --- .github/workflows/line-count.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/line-count.yml b/.github/workflows/line-count.yml index cc5f908ca6..af5d53e0e5 100644 --- a/.github/workflows/line-count.yml +++ b/.github/workflows/line-count.yml @@ -49,5 +49,5 @@ jobs: cd $BASE export MFC_PR=$PR pwd - ./mfc.sh count_diff << EOF > $GITHUB_STEP_SUMMARY + ./mfc.sh count_diff > $GITHUB_STEP_SUMMARY From 328eb4f7855813881bb2596ae53703be243f322d Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 16:38:13 -0500 Subject: [PATCH 08/10] Update bench.yml --- .github/workflows/bench.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index a22901e632..d9de23b60a 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -53,8 +53,10 @@ jobs: - name: Generate & Post Comment run: | + echo "::group::Performance" (cd pr && . ./mfc.sh load -c p -m g) (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml) + echo "::endgroup::" - name: Archive Logs uses: actions/upload-artifact@v4 From 8507ad60db1ce6c9525e5ae63101b38143de78fc Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 18 Nov 2024 22:30:50 -0500 Subject: [PATCH 09/10] Update bench.yml --- .github/workflows/bench.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index d9de23b60a..e3adf0a2d0 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -53,10 +53,8 @@ jobs: - name: Generate & Post Comment run: | - echo "::group::Performance" (cd pr && . ./mfc.sh load -c p -m g) - (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml) - echo "::endgroup::" + (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml) > $GITHUB_STEP_SUMMARY - name: Archive Logs uses: actions/upload-artifact@v4 From 39b0217bd37a4f07e7d8fdca675d758a88ae8094 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Tue, 19 Nov 2024 11:16:59 -0500 Subject: [PATCH 10/10] rename --- .github/workflows/bench.yml | 2 +- .github/workflows/line-count.yml | 4 ++-- .github/workflows/lint-source.yml | 10 ++-------- .github/workflows/lint-toolchain.yml | 4 ++-- 4 files changed, 7 insertions(+), 13 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index e3adf0a2d0..a22901e632 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -54,7 +54,7 @@ jobs: - name: Generate & Post Comment run: | (cd pr && . ./mfc.sh load -c p -m g) - (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml) > $GITHUB_STEP_SUMMARY + (cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml) - name: Archive Logs uses: actions/upload-artifact@v4 diff --git a/.github/workflows/line-count.yml b/.github/workflows/line-count.yml index af5d53e0e5..fafa970226 100644 --- a/.github/workflows/line-count.yml +++ b/.github/workflows/line-count.yml @@ -1,4 +1,4 @@ -name: Check Line Counts +name: Lines of Code on: [push, pull_request, workflow_dispatch] @@ -49,5 +49,5 @@ jobs: cd $BASE export MFC_PR=$PR pwd - ./mfc.sh count_diff > $GITHUB_STEP_SUMMARY + ./mfc.sh count_diff diff --git a/.github/workflows/lint-source.yml b/.github/workflows/lint-source.yml index f941a34aac..d425d449b8 100644 --- a/.github/workflows/lint-source.yml +++ b/.github/workflows/lint-source.yml @@ -18,7 +18,7 @@ jobs: with: filters: ".github/file-filter.yml" - lint: + lint-source: name: Lint Source runs-on: 'ubuntu-latest' @@ -29,10 +29,4 @@ jobs: run: pip install fortitude-lint ansi2txt - name: Lint the source code - run: fortitude check --ignore=E001,S001,S101,M011,F001,S041,T001 ./src/*/* &> lint.txt || true - - - name: Sanitize - run: cat lint.txt | ansi2txt > lint2.txt - - - name: Output Summary - run: cat lint2.txt << EOF > $GITHUB_STEP_SUMMARY + run: fortitude check --ignore=E001,S001,S101,M011,F001,S041,T001 ./src/*/* || true diff --git a/.github/workflows/lint-toolchain.yml b/.github/workflows/lint-toolchain.yml index c0e822bb07..59f48378b6 100644 --- a/.github/workflows/lint-toolchain.yml +++ b/.github/workflows/lint-toolchain.yml @@ -3,7 +3,7 @@ name: Lint Toolchain on: [push, pull_request, workflow_dispatch] jobs: - docs: + lint-toolchain: name: Lint Toolchain runs-on: ubuntu-latest @@ -11,4 +11,4 @@ jobs: - uses: actions/checkout@v4 - name: Lint the toolchain - run: ./mfc.sh lint > $GITHUB_STEP_SUMMARY + run: ./mfc.sh lint