Fix cross-compile, stale artifacts, packaging errors, and memory leaks

- Set cross-compile flags based on host architecture so universal
  builds work on both Intel and Apple Silicon Macs
- Remove stale ffmpeg/universal dir before single-arch builds to
  prevent linking against outdated libs
- Add error checking to plugin packaging (RESULT_VARIABLE + FATAL_ERROR)
- Fix memory leaks in ConfigModel: use stack allocation instead of
  malloc without free

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: naxIO

create-pluginfile.cmake

@@ -15,11 +15,17 @@ if(WIN32)
     execute_process(
         COMMAND "C:/Program Files/7-Zip/7z.exe" a "${PLUGIN_OUTPUT}" -tzip -mx=9 -mm=Deflate "*"
         WORKING_DIRECTORY "${CMAKE_INSTALL_PREFIX}"
+        RESULT_VARIABLE zip_result
     )
 else()
     # Use zip on Linux/macOS
     execute_process(
         COMMAND zip -r -9 "${PLUGIN_OUTPUT}" .
         WORKING_DIRECTORY "${CMAKE_INSTALL_PREFIX}"
+        RESULT_VARIABLE zip_result
     )
 endif()
+
+if(NOT zip_result EQUAL 0)
+    message(FATAL_ERROR "Failed to create plugin package (exit code: ${zip_result})")
+endif()

ffmpeg/build-scripts/build_ffmpeg.sh

@@ -356,13 +356,24 @@ build_single_arch() {
 }
 
 if [[ "$build_mac_universal" == "true" ]]; then
-	# Build arm64 (native on Apple Silicon)
+	host_arch="$(uname -m)"
+	cross_compile_flags="--enable-cross-compile --target-os=darwin"
+
+	# Build arm64 (cross-compile on Intel, native on Apple Silicon)
 	echo "=== Building FFmpeg for arm64 ==="
-	build_single_arch "aarch64" "arm64" "clang -arch arm64" ""
+	if [[ "$host_arch" == "x86_64" ]]; then
+		build_single_arch "aarch64" "arm64" "clang -arch arm64" "$cross_compile_flags"
+	else
+		build_single_arch "aarch64" "arm64" "clang -arch arm64" ""
+	fi
 
-	# Build x86_64 (cross-compile on Apple Silicon)
+	# Build x86_64 (native on Intel, cross-compile on Apple Silicon)
 	echo "=== Building FFmpeg for x86_64 ==="
-	build_single_arch "x86_64" "x64" "clang -arch x86_64" "--enable-cross-compile --target-os=darwin"
+	if [[ "$host_arch" == "arm64" ]]; then
+		build_single_arch "x86_64" "x64" "clang -arch x86_64" "$cross_compile_flags"
+	else
+		build_single_arch "x86_64" "x64" "clang -arch x86_64" ""
+	fi
 
 	# Combine into universal binaries using lipo
 	echo "=== Creating universal binaries with lipo ==="
@@ -379,6 +390,9 @@ if [[ "$build_mac_universal" == "true" ]]; then
 
 	./copy_binaries.sh
 else
+	# Remove stale universal artifacts to prevent copy_binaries.sh from
+	# copying outdated libs into lib_mac_universal
+	rm -rf ../ffmpeg/universal
 	build_single_arch "$arch" "$archprefix" "" ""
 	./copy_binaries.sh
 fi

src/ConfigModel.cpp

@@ -221,7 +221,7 @@ void ConfigModel::setSoundInfo( int itemId, const SoundInfo &info )
 QString ConfigModel::GetConfigPath()
 {
 	// Find config path for config class
-	char* configPath = (char*)malloc(PATH_BUFSIZE);
+	char configPath[PATH_BUFSIZE];
 	ts3Functions.getConfigPath(configPath, PATH_BUFSIZE);
 	return QString::fromUtf8(configPath);
 }
@@ -433,7 +433,7 @@ void ConfigModel::setBubbleColsBuild(int build)
 //---------------------------------------------------------------
 std::vector<SoundInfo> ConfigModel::getInitialSounds()
 {
-	char* pluginPath = (char*)malloc(PATH_BUFSIZE);
+	char pluginPath[PATH_BUFSIZE];
 	ts3Functions.getPluginPath(pluginPath, PATH_BUFSIZE, getPluginID());
 	QString fullPath = QString::fromUtf8(pluginPath);
 	QChar last = fullPath[fullPath.count() - 1];