Skip to content

Fix deprecated scipy.ndimage import paths #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
evertdeman wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix deprecated scipy.ndimage import paths #129

evertdeman wants to merge 3 commits into from

Conversation

@evertdeman
Copy link

@evertdeman evertdeman commented Nov 22, 2024

I am getting some warning like

../usr/local/lib/python3.10/dist-packages/batchgenerators/augmentations/utils.py:23
  /usr/local/lib/python3.10/dist-packages/batchgenerators/augmentations/utils.py:23: DeprecationWarning: Please use `label` from the `scipy.ndimage` namespace, the `scipy.ndimage.measurements` namespace is deprecated.
    from scipy.ndimage.measurements import label as lb

this should fix that

@evertdeman
Copy link
Author

evertdeman commented Dec 11, 2024

Ah, I see there is another PR open for this: #108

Any reason we should not merge this?

@truenicoco
Copy link

truenicoco commented Jan 13, 2026

@FabianIsensee any way to merge this? This is a trivial change.

Maybe you never noticed the warnings because DeprecationWarnings are suppressed by default and you typically only see them via test suites runners which "unsuppress" them (pytest does this). I saw some references to https://grugbrain.dev/ in the nnUNet source code, if I may quote it to try to convince you:

test save grug many, many uncountable time and grug love and respect test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evertdeman @truenicoco